Currently rpc.BlockNumber is marshalled to JSON as a numeric value, which is
wrong because BlockNumber.UnmarshalJSON() wants it to either be hex-encoded
or string "earliest"/"latest"/"pending". As a result, the call chain
    rpc.BlockNumberOrHashWithNumber(123) -> json.Marshal() -> json.Unmarshal()
fails with error "cannot unmarshal object into Go value of type string".
		
	
		
			
				
	
	
		
			156 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			156 lines
		
	
	
		
			6.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2015 The go-ethereum Authors
 | 
						|
// This file is part of the go-ethereum library.
 | 
						|
//
 | 
						|
// The go-ethereum library is free software: you can redistribute it and/or modify
 | 
						|
// it under the terms of the GNU Lesser General Public License as published by
 | 
						|
// the Free Software Foundation, either version 3 of the License, or
 | 
						|
// (at your option) any later version.
 | 
						|
//
 | 
						|
// The go-ethereum library is distributed in the hope that it will be useful,
 | 
						|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 | 
						|
// GNU Lesser General Public License for more details.
 | 
						|
//
 | 
						|
// You should have received a copy of the GNU Lesser General Public License
 | 
						|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 | 
						|
package rpc
 | 
						|
 | 
						|
import (
 | 
						|
	"encoding/json"
 | 
						|
	"reflect"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/ethereum/go-ethereum/common"
 | 
						|
	"github.com/ethereum/go-ethereum/common/math"
 | 
						|
)
 | 
						|
 | 
						|
func TestBlockNumberJSONUnmarshal(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		input    string
 | 
						|
		mustFail bool
 | 
						|
		expected BlockNumber
 | 
						|
	}{
 | 
						|
		0:  {`"0x"`, true, BlockNumber(0)},
 | 
						|
		1:  {`"0x0"`, false, BlockNumber(0)},
 | 
						|
		2:  {`"0X1"`, false, BlockNumber(1)},
 | 
						|
		3:  {`"0x00"`, true, BlockNumber(0)},
 | 
						|
		4:  {`"0x01"`, true, BlockNumber(0)},
 | 
						|
		5:  {`"0x1"`, false, BlockNumber(1)},
 | 
						|
		6:  {`"0x12"`, false, BlockNumber(18)},
 | 
						|
		7:  {`"0x7fffffffffffffff"`, false, BlockNumber(math.MaxInt64)},
 | 
						|
		8:  {`"0x8000000000000000"`, true, BlockNumber(0)},
 | 
						|
		9:  {"0", true, BlockNumber(0)},
 | 
						|
		10: {`"ff"`, true, BlockNumber(0)},
 | 
						|
		11: {`"pending"`, false, PendingBlockNumber},
 | 
						|
		12: {`"latest"`, false, LatestBlockNumber},
 | 
						|
		13: {`"earliest"`, false, EarliestBlockNumber},
 | 
						|
		14: {`someString`, true, BlockNumber(0)},
 | 
						|
		15: {`""`, true, BlockNumber(0)},
 | 
						|
		16: {``, true, BlockNumber(0)},
 | 
						|
	}
 | 
						|
 | 
						|
	for i, test := range tests {
 | 
						|
		var num BlockNumber
 | 
						|
		err := json.Unmarshal([]byte(test.input), &num)
 | 
						|
		if test.mustFail && err == nil {
 | 
						|
			t.Errorf("Test %d should fail", i)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if !test.mustFail && err != nil {
 | 
						|
			t.Errorf("Test %d should pass but got err: %v", i, err)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if num != test.expected {
 | 
						|
			t.Errorf("Test %d got unexpected value, want %d, got %d", i, test.expected, num)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestBlockNumberOrHash_UnmarshalJSON(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		input    string
 | 
						|
		mustFail bool
 | 
						|
		expected BlockNumberOrHash
 | 
						|
	}{
 | 
						|
		0:  {`"0x"`, true, BlockNumberOrHash{}},
 | 
						|
		1:  {`"0x0"`, false, BlockNumberOrHashWithNumber(0)},
 | 
						|
		2:  {`"0X1"`, false, BlockNumberOrHashWithNumber(1)},
 | 
						|
		3:  {`"0x00"`, true, BlockNumberOrHash{}},
 | 
						|
		4:  {`"0x01"`, true, BlockNumberOrHash{}},
 | 
						|
		5:  {`"0x1"`, false, BlockNumberOrHashWithNumber(1)},
 | 
						|
		6:  {`"0x12"`, false, BlockNumberOrHashWithNumber(18)},
 | 
						|
		7:  {`"0x7fffffffffffffff"`, false, BlockNumberOrHashWithNumber(math.MaxInt64)},
 | 
						|
		8:  {`"0x8000000000000000"`, true, BlockNumberOrHash{}},
 | 
						|
		9:  {"0", true, BlockNumberOrHash{}},
 | 
						|
		10: {`"ff"`, true, BlockNumberOrHash{}},
 | 
						|
		11: {`"pending"`, false, BlockNumberOrHashWithNumber(PendingBlockNumber)},
 | 
						|
		12: {`"latest"`, false, BlockNumberOrHashWithNumber(LatestBlockNumber)},
 | 
						|
		13: {`"earliest"`, false, BlockNumberOrHashWithNumber(EarliestBlockNumber)},
 | 
						|
		14: {`someString`, true, BlockNumberOrHash{}},
 | 
						|
		15: {`""`, true, BlockNumberOrHash{}},
 | 
						|
		16: {``, true, BlockNumberOrHash{}},
 | 
						|
		17: {`"0x0000000000000000000000000000000000000000000000000000000000000000"`, false, BlockNumberOrHashWithHash(common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000000"), false)},
 | 
						|
		18: {`{"blockHash":"0x0000000000000000000000000000000000000000000000000000000000000000"}`, false, BlockNumberOrHashWithHash(common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000000"), false)},
 | 
						|
		19: {`{"blockHash":"0x0000000000000000000000000000000000000000000000000000000000000000","requireCanonical":false}`, false, BlockNumberOrHashWithHash(common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000000"), false)},
 | 
						|
		20: {`{"blockHash":"0x0000000000000000000000000000000000000000000000000000000000000000","requireCanonical":true}`, false, BlockNumberOrHashWithHash(common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000000"), true)},
 | 
						|
		21: {`{"blockNumber":"0x1"}`, false, BlockNumberOrHashWithNumber(1)},
 | 
						|
		22: {`{"blockNumber":"pending"}`, false, BlockNumberOrHashWithNumber(PendingBlockNumber)},
 | 
						|
		23: {`{"blockNumber":"latest"}`, false, BlockNumberOrHashWithNumber(LatestBlockNumber)},
 | 
						|
		24: {`{"blockNumber":"earliest"}`, false, BlockNumberOrHashWithNumber(EarliestBlockNumber)},
 | 
						|
		25: {`{"blockNumber":"0x1", "blockHash":"0x0000000000000000000000000000000000000000000000000000000000000000"}`, true, BlockNumberOrHash{}},
 | 
						|
	}
 | 
						|
 | 
						|
	for i, test := range tests {
 | 
						|
		var bnh BlockNumberOrHash
 | 
						|
		err := json.Unmarshal([]byte(test.input), &bnh)
 | 
						|
		if test.mustFail && err == nil {
 | 
						|
			t.Errorf("Test %d should fail", i)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if !test.mustFail && err != nil {
 | 
						|
			t.Errorf("Test %d should pass but got err: %v", i, err)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		hash, hashOk := bnh.Hash()
 | 
						|
		expectedHash, expectedHashOk := test.expected.Hash()
 | 
						|
		num, numOk := bnh.Number()
 | 
						|
		expectedNum, expectedNumOk := test.expected.Number()
 | 
						|
		if bnh.RequireCanonical != test.expected.RequireCanonical ||
 | 
						|
			hash != expectedHash || hashOk != expectedHashOk ||
 | 
						|
			num != expectedNum || numOk != expectedNumOk {
 | 
						|
			t.Errorf("Test %d got unexpected value, want %v, got %v", i, test.expected, bnh)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestBlockNumberOrHash_WithNumber_MarshalAndUnmarshal(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		name   string
 | 
						|
		number int64
 | 
						|
	}{
 | 
						|
		{"max", math.MaxInt64},
 | 
						|
		{"pending", int64(PendingBlockNumber)},
 | 
						|
		{"latest", int64(LatestBlockNumber)},
 | 
						|
		{"earliest", int64(EarliestBlockNumber)},
 | 
						|
	}
 | 
						|
	for _, test := range tests {
 | 
						|
		test := test
 | 
						|
		t.Run(test.name, func(t *testing.T) {
 | 
						|
			bnh := BlockNumberOrHashWithNumber(BlockNumber(test.number))
 | 
						|
			marshalled, err := json.Marshal(bnh)
 | 
						|
			if err != nil {
 | 
						|
				t.Fatal("cannot marshal:", err)
 | 
						|
			}
 | 
						|
			var unmarshalled BlockNumberOrHash
 | 
						|
			err = json.Unmarshal(marshalled, &unmarshalled)
 | 
						|
			if err != nil {
 | 
						|
				t.Fatal("cannot unmarshal:", err)
 | 
						|
			}
 | 
						|
			if !reflect.DeepEqual(bnh, unmarshalled) {
 | 
						|
				t.Fatalf("wrong result: expected %v, got %v", bnh, unmarshalled)
 | 
						|
			}
 | 
						|
		})
 | 
						|
	}
 | 
						|
}
 |