Reworked the EVM gas instructions to use 64bit integers rather than arbitrary size big ints. All gas operations, be it additions, multiplications or divisions, are checked and guarded against 64 bit integer overflows. In additon, most of the protocol paramaters in the params package have been converted to uint64 and are now constants rather than variables. * common/math: added overflow check ops * core: vmenv, env renamed to evm * eth, internal/ethapi, les: unmetered eth_call and cancel methods * core/vm: implemented big.Int pool for evm instructions * core/vm: unexported intPool methods & verification methods * core/vm: added memoryGasCost overflow check and test
		
			
				
	
	
		
			51 lines
		
	
	
		
			875 B
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			51 lines
		
	
	
		
			875 B
		
	
	
	
		
			Go
		
	
	
	
	
	
| package math
 | |
| 
 | |
| import (
 | |
| 	gmath "math"
 | |
| 	"testing"
 | |
| )
 | |
| 
 | |
| type operation byte
 | |
| 
 | |
| const (
 | |
| 	sub operation = iota
 | |
| 	add
 | |
| 	mul
 | |
| )
 | |
| 
 | |
| func TestOverflow(t *testing.T) {
 | |
| 	for i, test := range []struct {
 | |
| 		x        uint64
 | |
| 		y        uint64
 | |
| 		overflow bool
 | |
| 		op       operation
 | |
| 	}{
 | |
| 		// add operations
 | |
| 		{gmath.MaxUint64, 1, true, add},
 | |
| 		{gmath.MaxUint64 - 1, 1, false, add},
 | |
| 
 | |
| 		// sub operations
 | |
| 		{0, 1, true, sub},
 | |
| 		{0, 0, false, sub},
 | |
| 
 | |
| 		// mul operations
 | |
| 		{10, 10, false, mul},
 | |
| 		{gmath.MaxUint64, 2, true, mul},
 | |
| 		{gmath.MaxUint64, 1, false, mul},
 | |
| 	} {
 | |
| 		var overflows bool
 | |
| 		switch test.op {
 | |
| 		case sub:
 | |
| 			_, overflows = SafeSub(test.x, test.y)
 | |
| 		case add:
 | |
| 			_, overflows = SafeAdd(test.x, test.y)
 | |
| 		case mul:
 | |
| 			_, overflows = SafeMul(test.x, test.y)
 | |
| 		}
 | |
| 
 | |
| 		if test.overflow != overflows {
 | |
| 			t.Errorf("%d failed. Expected test to be %v, got %v", i, test.overflow, overflows)
 | |
| 		}
 | |
| 	}
 | |
| }
 |