From 0fbb4f400309b97faeb8e864e5923afe89bf7b16 Mon Sep 17 00:00:00 2001 From: ruslanpa Date: Tue, 10 Feb 2015 09:23:59 +0200 Subject: [PATCH] [refactor] Remove unnecessary declarations in command pattern. --- command/src/main/java/com/iluwatar/Goblin.java | 4 ++-- command/src/main/java/com/iluwatar/InvisibilitySpell.java | 4 ---- command/src/main/java/com/iluwatar/ShrinkSpell.java | 6 ------ command/src/main/java/com/iluwatar/Wizard.java | 5 ++--- 4 files changed, 4 insertions(+), 15 deletions(-) diff --git a/command/src/main/java/com/iluwatar/Goblin.java b/command/src/main/java/com/iluwatar/Goblin.java index 4e50915f9..6bb614554 100644 --- a/command/src/main/java/com/iluwatar/Goblin.java +++ b/command/src/main/java/com/iluwatar/Goblin.java @@ -3,8 +3,8 @@ package com.iluwatar; public class Goblin extends Target { public Goblin() { - this.setSize(Size.NORMAL); - this.setVisibility(Visibility.VISIBLE); + setSize(Size.NORMAL); + setVisibility(Visibility.VISIBLE); } @Override diff --git a/command/src/main/java/com/iluwatar/InvisibilitySpell.java b/command/src/main/java/com/iluwatar/InvisibilitySpell.java index b95a24f7e..9a35a9df3 100644 --- a/command/src/main/java/com/iluwatar/InvisibilitySpell.java +++ b/command/src/main/java/com/iluwatar/InvisibilitySpell.java @@ -4,10 +4,6 @@ public class InvisibilitySpell extends Command { private Target target; - public InvisibilitySpell() { - target = null; - } - @Override public void execute(Target target) { target.setVisibility(Visibility.INVISIBLE); diff --git a/command/src/main/java/com/iluwatar/ShrinkSpell.java b/command/src/main/java/com/iluwatar/ShrinkSpell.java index fe444a972..44a5b7144 100644 --- a/command/src/main/java/com/iluwatar/ShrinkSpell.java +++ b/command/src/main/java/com/iluwatar/ShrinkSpell.java @@ -3,14 +3,8 @@ package com.iluwatar; public class ShrinkSpell extends Command { private Size oldSize; - private Target target; - public ShrinkSpell() { - oldSize = null; - target = null; - } - @Override public void execute(Target target) { oldSize = target.getSize(); diff --git a/command/src/main/java/com/iluwatar/Wizard.java b/command/src/main/java/com/iluwatar/Wizard.java index 63aa560c7..e3d19be1f 100644 --- a/command/src/main/java/com/iluwatar/Wizard.java +++ b/command/src/main/java/com/iluwatar/Wizard.java @@ -5,9 +5,8 @@ public class Wizard extends Target { private Command previousSpell; public Wizard() { - this.setSize(Size.NORMAL); - this.setVisibility(Visibility.VISIBLE); - previousSpell = null; + setSize(Size.NORMAL); + setVisibility(Visibility.VISIBLE); } public void castSpell(Command command, Target target) {