Fixing squid:S1698 - Objects should be compared with equals() and squid:HiddenFieldCheck - Local variables should not shadow class fields

2015-12-22 15:10:09 +05:00
parent 3d8c64d76d
commit 191078735f
5 changed files with 9 additions and 9 deletions
--- a/mediator/src/main/java/com/iluwatar/mediator/PartyImpl.java
+++ b/mediator/src/main/java/com/iluwatar/mediator/PartyImpl.java
@ -19,7 +19,7 @@ public class PartyImpl implements Party {
  @Override
  public void act(PartyMember actor, Action action) {
    for (PartyMember member : members) {
-      if (member != actor) {
+      if (!member.equals(actor)) {
        member.partyAction(action);
      }
    }