gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixing squid:S1698 - Objects should be compared with equals() and squid:HiddenFieldCheck - Local variables should not shadow class fields

Browse Source
This commit is contained in:
Kirill Vlasov
2015-12-22 15:10:09 +05:00
parent 3d8c64d76d
commit 191078735f
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
model-view-presenter/src/main/java/com/iluwatar/model/view/presenter/FileSelectorJFrame.java
View File

@ -140,11 +140,11 @@ public class FileSelectorJFrame extends JFrame implements FileSelectorView, Acti
@Override
public void actionPerformed(ActionEvent e) {
if (e.getSource() == this.ok) {
if (this.ok.equals(e.getSource())) {
this.fileName = this.input.getText();
presenter.fileNameChanged();
presenter.confirmed();
} else if (e.getSource() == this.cancel) {
} else if (this.cancel.equals(e.getSource())) {
presenter.cancelled();
}
}