gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for Issue #549 : Add Fallbacks in Aggregator Service (#971)

Browse Source 
*  Fix for Issue##549

Catch ClientProtocolException and Update Error Logs

* Fix indentation, checkstyle errors

* Fix for Issue #549
Add fallbacks in Aggregator service when other microservices fail

* Make ProductInventoryClientImpl return null instead of zero in case of failure
This commit is contained in:
Arpit Jain 2019-11-01 23:31:30 +05:30 committed by Ilkka Seppälä
parent 55b0341c8d
commit 1d4a7681e2
3 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java
View File

@ -51,9 +51,23 @@ public class Aggregator {
*/ */
@RequestMapping(path = "/product", method = RequestMethod.GET) @RequestMapping(path = "/product", method = RequestMethod.GET)
public Product getProduct() { public Product getProduct() {
var product = new Product(); var product = new Product();
product.setTitle(informationClient.getProductTitle()); String productTitle = informationClient.getProductTitle();
product.setProductInventories(inventoryClient.getProductInventories()); Integer productInventory = inventoryClient.getProductInventories();
if (productTitle != null) {
product.setTitle(productTitle);
} else {
product.setTitle("Error: Fetching Product Title Failed"); //Fallback to error message
}
if (productInventory != null) {
product.setProductInventories(productInventory);
} else {
product.setProductInventories(-1); //Fallback to default error inventory
}
return product; return product;
} }

2
aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClient.java
View File

@ -28,5 +28,5 @@ package com.iluwatar.aggregator.microservices;
*/ */
public interface ProductInventoryClient { public interface ProductInventoryClient {
int getProductInventories(); Integer getProductInventories();
} }

10
aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.java
View File

@ -42,8 +42,8 @@ public class ProductInventoryClientImpl implements ProductInventoryClient {
private static final Logger LOGGER = LoggerFactory.getLogger(ProductInventoryClientImpl.class); private static final Logger LOGGER = LoggerFactory.getLogger(ProductInventoryClientImpl.class);
@Override @Override
public int getProductInventories() { public Integer getProductInventories() {
var response = "0"; var response = "";
var request = HttpRequest.newBuilder().GET().uri(URI.create("http://localhost:51516/inventories")).build(); var request = HttpRequest.newBuilder().GET().uri(URI.create("http://localhost:51516/inventories")).build();
var client = HttpClient.newHttpClient(); var client = HttpClient.newHttpClient();
@ -55,6 +55,10 @@ public class ProductInventoryClientImpl implements ProductInventoryClient {
} catch (InterruptedException ie) { } catch (InterruptedException ie) {
LOGGER.error("InterruptedException Occurred", ie); LOGGER.error("InterruptedException Occurred", ie);
} }
return Integer.parseInt(response); if("".equalsIgnoreCase(response)) {
return null;
} else {
return Integer.parseInt(response);
}
} }
} }