gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix Sonar critical issue - fix code smells

Browse Source
This commit is contained in:
atayal
2021-10-31 19:28:22 +05:30
parent a845e67922
commit 2495aedbb0
1 changed files with 73 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

146
commander/src/main/java/com/iluwatar/commander/Commander.java
View File

@@ -90,8 +90,8 @@ public class Commander {
private static final Logger LOG = LoggerFactory.getLogger(Commander.class); private static final Logger LOG = LoggerFactory.getLogger(Commander.class);
//we could also have another db where it stores all orders //we could also have another db where it stores all orders
private static final String ORDER = "Order "; private static final String ORDER_ID = "Order {}";
private static final String REQUEST_ID = " request Id: "; private static final String REQUEST_ID = " request Id: {}";
private static final String ERROR_CONNECTING_MSG_SVC = private static final String ERROR_CONNECTING_MSG_SVC =
": Error in connecting to messaging service "; ": Error in connecting to messaging service ";
private static final String TRY_CONNECTING_MSG_SVC = private static final String TRY_CONNECTING_MSG_SVC =
@@ -125,17 +125,17 @@ public class Commander {
Retry.Operation op = (l) -> { Retry.Operation op = (l) -> {
if (!l.isEmpty()) { if (!l.isEmpty()) {
if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) { if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) {
LOG.debug(ORDER + order.id + ": Error in connecting to shipping service, " LOG.debug(ORDER_ID + ": Error in connecting to shipping service, "
+ "trying again.."); + "trying again..", order.id);
} else { } else {
LOG.debug(ORDER + order.id + ": Error in creating shipping request.."); LOG.debug(ORDER_ID + ": Error in creating shipping request..", order.id);
} }
throw l.remove(0); throw l.remove(0);
} }
String transactionId = shippingService.receiveRequest(order.item, order.user.address); String transactionId = shippingService.receiveRequest(order.item, order.user.address);
//could save this transaction id in a db too //could save this transaction id in a db too
LOG.info(ORDER + order.id + ": Shipping placed successfully, transaction id: " LOG.info(ORDER_ID + ": Shipping placed successfully, transaction id: "
+ transactionId); + transactionId, order.id);
LOG.info("Order has been placed and will be shipped to you. Please wait while we make your" LOG.info("Order has been placed and will be shipped to you. Please wait while we make your"
+ " payment... "); + " payment... ");
sendPaymentRequest(order); sendPaymentRequest(order);
@@ -145,19 +145,19 @@ public class Commander {
LOG.info("Shipping is currently not possible to your address. We are working on the problem" LOG.info("Shipping is currently not possible to your address. We are working on the problem"
+ " and will get back to you asap."); + " and will get back to you asap.");
finalSiteMsgShown = true; finalSiteMsgShown = true;
LOG.info(ORDER + order.id + ": Shipping not possible to address, trying to add problem " LOG.info(ORDER_ID + ": Shipping not possible to address, trying to add problem "
+ "to employee db.."); + "to employee db..", order.id);
employeeHandleIssue(o); employeeHandleIssue(o);
} else if (ItemUnavailableException.class.isAssignableFrom(err.getClass())) { } else if (ItemUnavailableException.class.isAssignableFrom(err.getClass())) {
LOG.info("This item is currently unavailable. We will inform you as soon as the item " LOG.info("This item is currently unavailable. We will inform you as soon as the item "
+ "becomes available again."); + "becomes available again.");
finalSiteMsgShown = true; finalSiteMsgShown = true;
LOG.info(ORDER + order.id + ": Item " + order.item + " unavailable, trying to add " LOG.info(ORDER_ID + ": Item " + order.item + " unavailable, trying to add "
+ "problem to employee handle.."); + "problem to employee handle..", order.id);
employeeHandleIssue(o); employeeHandleIssue(o);
} else { } else {
LOG.info("Sorry, there was a problem in creating your order. Please try later."); LOG.info("Sorry, there was a problem in creating your order. Please try later.");
LOG.error(ORDER + order.id + ": Shipping service unavailable, order not placed.."); LOG.error(ORDER_ID + ": Shipping service unavailable, order not placed..", order.id);
finalSiteMsgShown = true; finalSiteMsgShown = true;
} }
}; };
@@ -171,7 +171,7 @@ public class Commander {
if (order.paid.equals(PaymentStatus.TRYING)) { if (order.paid.equals(PaymentStatus.TRYING)) {
order.paid = PaymentStatus.NOT_DONE; order.paid = PaymentStatus.NOT_DONE;
sendPaymentFailureMessage(order); sendPaymentFailureMessage(order);
LOG.error(ORDER + order.id + ": Payment time for order over, failed and returning.."); LOG.error(ORDER_ID + ": Payment time for order over, failed and returning..", order.id);
} //if succeeded or failed, would have been dequeued, no attempt to make payment } //if succeeded or failed, would have been dequeued, no attempt to make payment
return; return;
} }
@@ -180,17 +180,17 @@ public class Commander {
Retry.Operation op = (l) -> { Retry.Operation op = (l) -> {
if (!l.isEmpty()) { if (!l.isEmpty()) {
if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) { if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) {
LOG.debug(ORDER + order.id + ": Error in connecting to payment service," LOG.debug(ORDER_ID + ": Error in connecting to payment service,"
+ " trying again.."); + " trying again..", order.id);
} else { } else {
LOG.debug(ORDER + order.id + ": Error in creating payment request.."); LOG.debug(ORDER_ID + ": Error in creating payment request..", order.id);
} }
throw l.remove(0); throw l.remove(0);
} }
if (order.paid.equals(PaymentStatus.TRYING)) { if (order.paid.equals(PaymentStatus.TRYING)) {
var transactionId = paymentService.receiveRequest(order.price); var transactionId = paymentService.receiveRequest(order.price);
order.paid = PaymentStatus.DONE; order.paid = PaymentStatus.DONE;
LOG.info(ORDER + order.id + ": Payment successful, transaction Id: " + transactionId); LOG.info(ORDER_ID + ": Payment successful, transaction Id: " + transactionId, order.id);
if (!finalSiteMsgShown) { if (!finalSiteMsgShown) {
LOG.info("Payment made successfully, thank you for shopping with us!!"); LOG.info("Payment made successfully, thank you for shopping with us!!");
finalSiteMsgShown = true; finalSiteMsgShown = true;
@@ -206,7 +206,7 @@ public class Commander {
+ "Meanwhile, your order has been converted to COD and will be shipped."); + "Meanwhile, your order has been converted to COD and will be shipped.");
finalSiteMsgShown = true; finalSiteMsgShown = true;
} }
LOG.error(ORDER + order.id + ": Payment details incorrect, failed.."); LOG.error(ORDER_ID + ": Payment details incorrect, failed..", order.id);
o.paid = PaymentStatus.NOT_DONE; o.paid = PaymentStatus.NOT_DONE;
sendPaymentFailureMessage(o); sendPaymentFailureMessage(o);
} else { } else {
@@ -216,7 +216,7 @@ public class Commander {
+ "asap. Don't worry, your order has been placed and will be shipped."); + "asap. Don't worry, your order has been placed and will be shipped.");
finalSiteMsgShown = true; finalSiteMsgShown = true;
} }
LOG.warn(ORDER + order.id + ": Payment error, going to queue.."); LOG.warn(ORDER_ID + ": Payment error, going to queue..", order.id);
sendPaymentPossibleErrorMsg(o); sendPaymentPossibleErrorMsg(o);
} }
if (o.paid.equals(PaymentStatus.TRYING) && System if (o.paid.equals(PaymentStatus.TRYING) && System
@@ -241,7 +241,7 @@ public class Commander {
if (System.currentTimeMillis() - qt.order.createdTime >= this.queueTime) { if (System.currentTimeMillis() - qt.order.createdTime >= this.queueTime) {
// since payment time is lesser than queuetime it would have already failed.. // since payment time is lesser than queuetime it would have already failed..
// additional check not needed // additional check not needed
LOG.trace(ORDER + qt.order.id + ": Queue time for order over, failed.."); LOG.trace(ORDER_ID + ": Queue time for order over, failed..", qt.order.id);
return; return;
} else if (qt.taskType.equals(TaskType.PAYMENT) && !qt.order.paid.equals(PaymentStatus.TRYING) } else if (qt.taskType.equals(TaskType.PAYMENT) && !qt.order.paid.equals(PaymentStatus.TRYING)
|| qt.taskType.equals(TaskType.MESSAGING) && (qt.messageType == 1 || qt.taskType.equals(TaskType.MESSAGING) && (qt.messageType == 1
@@ -249,30 +249,30 @@ public class Commander {
|| qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL) || qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL)
|| qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) || qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL))
|| qt.taskType.equals(TaskType.EMPLOYEE_DB) && qt.order.addedToEmployeeHandle) { || qt.taskType.equals(TaskType.EMPLOYEE_DB) && qt.order.addedToEmployeeHandle) {
LOG.trace(ORDER + qt.order.id + ": Not queueing task since task already done.."); LOG.trace(ORDER_ID + ": Not queueing task since task already done..", qt.order.id);
return; return;
} }
var list = queue.exceptionsList; var list = queue.exceptionsList;
Thread t = new Thread(() -> { Thread t = new Thread(() -> {
Retry.Operation op = (list1) -> { Retry.Operation op = (list1) -> {
if (!list1.isEmpty()) { if (!list1.isEmpty()) {
LOG.warn(ORDER + qt.order.id + ": Error in connecting to queue db, trying again.."); LOG.warn(ORDER_ID + ": Error in connecting to queue db, trying again..", qt.order.id);
throw list1.remove(0); throw list1.remove(0);
} }
queue.add(qt); queue.add(qt);
queueItems++; queueItems++;
LOG.info(ORDER + qt.order.id + ": " + qt.getType() + " task enqueued.."); LOG.info(ORDER_ID + ": " + qt.getType() + " task enqueued..", qt.order.id);
tryDoingTasksInQueue(); tryDoingTasksInQueue();
}; };
Retry.HandleErrorIssue<QueueTask> handleError = (qt1, err) -> { Retry.HandleErrorIssue<QueueTask> handleError = (qt1, err) -> {
if (qt1.taskType.equals(TaskType.PAYMENT)) { if (qt1.taskType.equals(TaskType.PAYMENT)) {
qt1.order.paid = PaymentStatus.NOT_DONE; qt1.order.paid = PaymentStatus.NOT_DONE;
sendPaymentFailureMessage(qt1.order); sendPaymentFailureMessage(qt1.order);
LOG.error(ORDER + qt1.order.id + ": Unable to enqueue payment task," LOG.error(ORDER_ID + ": Unable to enqueue payment task,"
+ " payment failed.."); + " payment failed..", qt1.order.id);
} }
LOG.error(ORDER + qt1.order.id + ": Unable to enqueue task of type " + qt1.getType() LOG.error(ORDER_ID + ": Unable to enqueue task of type " + qt1.getType()
+ ", trying to add to employee handle.."); + ", trying to add to employee handle..", qt1.order.id);
employeeHandleIssue(qt1.order); employeeHandleIssue(qt1.order);
}; };
var r = new Retry<>(op, handleError, numOfRetries, retryDuration, var r = new Retry<>(op, handleError, numOfRetries, retryDuration,
@@ -335,7 +335,7 @@ public class Commander {
private void sendSuccessMessage(Order order) { private void sendSuccessMessage(Order order) {
if (System.currentTimeMillis() - order.createdTime >= this.messageTime) { if (System.currentTimeMillis() - order.createdTime >= this.messageTime) {
LOG.trace(ORDER + order.id + ": Message time for order over, returning.."); LOG.trace(ORDER_ID + ": Message time for order over, returning..", order.id);
return; return;
} }
var list = messagingService.exceptionsList; var list = messagingService.exceptionsList;
@@ -361,8 +361,8 @@ public class Commander {
&& System.currentTimeMillis() - o.createdTime < messageTime) { && System.currentTimeMillis() - o.createdTime < messageTime) {
var qt = new QueueTask(order, TaskType.MESSAGING, 2); var qt = new QueueTask(order, TaskType.MESSAGING, 2);
updateQueue(qt); updateQueue(qt);
LOG.info(ORDER + order.id + ": Error in sending Payment Success message, trying to" LOG.info(ORDER_ID + ": Error in sending Payment Success message, trying to"
+ " queue task and add to employee handle.."); + " queue task and add to employee handle..", order.id);
employeeHandleIssue(order); employeeHandleIssue(order);
} }
} }
@@ -371,11 +371,11 @@ public class Commander {
return (l) -> { return (l) -> {
if (!l.isEmpty()) { if (!l.isEmpty()) {
if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) { if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) {
LOG.debug(ORDER + order.id + ERROR_CONNECTING_MSG_SVC LOG.debug(ORDER_ID + ERROR_CONNECTING_MSG_SVC
+ "(Payment Success msg), trying again.."); + "(Payment Success msg), trying again..", order.id);
} else { } else {
LOG.debug(ORDER + order.id + ": Error in creating Payment Success" LOG.debug(ORDER_ID + ": Error in creating Payment Success"
+ " messaging request.."); + " messaging request..", order.id);
} }
throw l.remove(0); throw l.remove(0);
} }
@@ -383,15 +383,15 @@ public class Commander {
&& !order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) { && !order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) {
var requestId = messagingService.receiveRequest(2); var requestId = messagingService.receiveRequest(2);
order.messageSent = MessageSent.PAYMENT_SUCCESSFUL; order.messageSent = MessageSent.PAYMENT_SUCCESSFUL;
LOG.info(ORDER + order.id + ": Payment Success message sent," LOG.info(ORDER_ID + ": Payment Success message sent,"
+ REQUEST_ID + requestId); + REQUEST_ID, order.id, requestId);
} }
}; };
} }
private void sendPaymentFailureMessage(Order order) { private void sendPaymentFailureMessage(Order order) {
if (System.currentTimeMillis() - order.createdTime >= this.messageTime) { if (System.currentTimeMillis() - order.createdTime >= this.messageTime) {
LOG.trace(ORDER + order.id + ": Message time for order over, returning.."); LOG.trace(ORDER_ID + ": Message time for order over, returning..", order.id);
return; return;
} }
var list = messagingService.exceptionsList; var list = messagingService.exceptionsList;
@@ -419,8 +419,8 @@ public class Commander {
&& System.currentTimeMillis() - o.createdTime < messageTime) { && System.currentTimeMillis() - o.createdTime < messageTime) {
var qt = new QueueTask(order, TaskType.MESSAGING, 0); var qt = new QueueTask(order, TaskType.MESSAGING, 0);
updateQueue(qt); updateQueue(qt);
LOG.warn(ORDER + order.id + ": Error in sending Payment Failure message, " LOG.warn(ORDER_ID + ": Error in sending Payment Failure message, "
+ "trying to queue task and add to employee handle.."); + "trying to queue task and add to employee handle..", order.id);
employeeHandleIssue(o); employeeHandleIssue(o);
} }
} }
@@ -428,11 +428,11 @@ public class Commander {
private void handlePaymentFailureRetryOperation(Order order, List<Exception> l) throws Exception { private void handlePaymentFailureRetryOperation(Order order, List<Exception> l) throws Exception {
if (!l.isEmpty()) { if (!l.isEmpty()) {
if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) { if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) {
LOG.debug(ORDER + order.id + ERROR_CONNECTING_MSG_SVC LOG.debug(ORDER_ID + ERROR_CONNECTING_MSG_SVC
+ "(Payment Failure msg), trying again.."); + "(Payment Failure msg), trying again..", order.id);
} else { } else {
LOG.debug(ORDER + order.id + ": Error in creating Payment Failure" LOG.debug(ORDER_ID + ": Error in creating Payment Failure"
+ " message request.."); + " message request..", order.id);
} }
throw l.remove(0); throw l.remove(0);
} }
@@ -440,8 +440,8 @@ public class Commander {
&& !order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) { && !order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) {
var requestId = messagingService.receiveRequest(0); var requestId = messagingService.receiveRequest(0);
order.messageSent = MessageSent.PAYMENT_FAIL; order.messageSent = MessageSent.PAYMENT_FAIL;
LOG.info(ORDER + order.id + ": Payment Failure message sent successfully," LOG.info(ORDER_ID + ": Payment Failure message sent successfully,"
+ REQUEST_ID + requestId); + REQUEST_ID, order.id, requestId);
} }
} }
@@ -475,8 +475,8 @@ public class Commander {
&& System.currentTimeMillis() - o.createdTime < messageTime) { && System.currentTimeMillis() - o.createdTime < messageTime) {
var qt = new QueueTask(order, TaskType.MESSAGING, 1); var qt = new QueueTask(order, TaskType.MESSAGING, 1);
updateQueue(qt); updateQueue(qt);
LOG.warn(ORDER + order.id + ": Error in sending Payment Error message, " LOG.warn(ORDER_ID + ": Error in sending Payment Error message, "
+ "trying to queue task and add to employee handle.."); + "trying to queue task and add to employee handle..", order.id);
employeeHandleIssue(o); employeeHandleIssue(o);
} }
} }
@@ -485,11 +485,11 @@ public class Commander {
throws Exception { throws Exception {
if (!l.isEmpty()) { if (!l.isEmpty()) {
if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) { if (DatabaseUnavailableException.class.isAssignableFrom(l.get(0).getClass())) {
LOG.debug(ORDER + order.id + ERROR_CONNECTING_MSG_SVC LOG.debug(ORDER_ID + ERROR_CONNECTING_MSG_SVC
+ "(Payment Error msg), trying again.."); + "(Payment Error msg), trying again..", order.id);
} else { } else {
LOG.debug(ORDER + order.id + ": Error in creating Payment Error" LOG.debug(ORDER_ID + ": Error in creating Payment Error"
+ " messaging request.."); + " messaging request..", order.id);
} }
throw l.remove(0); throw l.remove(0);
} }
@@ -497,28 +497,28 @@ public class Commander {
.equals(MessageSent.NONE_SENT)) { .equals(MessageSent.NONE_SENT)) {
var requestId = messagingService.receiveRequest(1); var requestId = messagingService.receiveRequest(1);
order.messageSent = MessageSent.PAYMENT_TRYING; order.messageSent = MessageSent.PAYMENT_TRYING;
LOG.info(ORDER + order.id + ": Payment Error message sent successfully," LOG.info(ORDER_ID + ": Payment Error message sent successfully,"
+ REQUEST_ID + requestId); + REQUEST_ID, order.id, requestId);
} }
} }
private void employeeHandleIssue(Order order) { private void employeeHandleIssue(Order order) {
if (System.currentTimeMillis() - order.createdTime >= this.employeeTime) { if (System.currentTimeMillis() - order.createdTime >= this.employeeTime) {
LOG.trace(ORDER + order.id + ": Employee handle time for order over, returning.."); LOG.trace(ORDER_ID + ": Employee handle time for order over, returning..", order.id);
return; return;
} }
var list = employeeDb.exceptionsList; var list = employeeDb.exceptionsList;
var t = new Thread(() -> { var t = new Thread(() -> {
Retry.Operation op = (l) -> { Retry.Operation op = (l) -> {
if (!l.isEmpty()) { if (!l.isEmpty()) {
LOG.warn(ORDER + order.id + ": Error in connecting to employee handle," LOG.warn(ORDER_ID + ": Error in connecting to employee handle,"
+ " trying again.."); + " trying again..", order.id);
throw l.remove(0); throw l.remove(0);
} }
if (!order.addedToEmployeeHandle) { if (!order.addedToEmployeeHandle) {
employeeDb.receiveRequest(order); employeeDb.receiveRequest(order);
order.addedToEmployeeHandle = true; order.addedToEmployeeHandle = true;
LOG.info(ORDER + order.id + ": Added order to employee database"); LOG.info(ORDER_ID + ": Added order to employee database", order.id);
} }
}; };
Retry.HandleErrorIssue<Order> handleError = (o, err) -> { Retry.HandleErrorIssue<Order> handleError = (o, err) -> {
@@ -526,8 +526,8 @@ public class Commander {
.currentTimeMillis() - order.createdTime < employeeTime) { .currentTimeMillis() - order.createdTime < employeeTime) {
var qt = new QueueTask(order, TaskType.EMPLOYEE_DB, -1); var qt = new QueueTask(order, TaskType.EMPLOYEE_DB, -1);
updateQueue(qt); updateQueue(qt);
LOG.warn(ORDER + order.id + ": Error in adding to employee db," LOG.warn(ORDER_ID + ": Error in adding to employee db,"
+ " trying to queue task.."); + " trying to queue task..", order.id);
} }
}; };
var r = new Retry<>(op, handleError, numOfRetries, retryDuration, var r = new Retry<>(op, handleError, numOfRetries, retryDuration,
@@ -545,51 +545,51 @@ public class Commander {
if (queueItems != 0) { if (queueItems != 0) {
var qt = queue.peek(); //this should probably be cloned here var qt = queue.peek(); //this should probably be cloned here
//this is why we have retry for doTasksInQueue //this is why we have retry for doTasksInQueue
LOG.trace(ORDER + qt.order.id + ": Started doing task of type " + qt.getType()); LOG.trace(ORDER_ID + ": Started doing task of type " + qt.getType(), qt.order.id);
if (qt.getFirstAttemptTime() == -1) { if (qt.getFirstAttemptTime() == -1) {
qt.setFirstAttemptTime(System.currentTimeMillis()); qt.setFirstAttemptTime(System.currentTimeMillis());
} }
if (System.currentTimeMillis() - qt.getFirstAttemptTime() >= queueTaskTime) { if (System.currentTimeMillis() - qt.getFirstAttemptTime() >= queueTaskTime) {
tryDequeue(); tryDequeue();
LOG.trace(ORDER + qt.order.id + ": This queue task of type " + qt.getType() LOG.trace(ORDER_ID + ": This queue task of type " + qt.getType()
+ " does not need to be done anymore (timeout), dequeue.."); + " does not need to be done anymore (timeout), dequeue..", qt.order.id);
} else { } else {
if (qt.taskType.equals(TaskType.PAYMENT)) { if (qt.taskType.equals(TaskType.PAYMENT)) {
if (!qt.order.paid.equals(PaymentStatus.TRYING)) { if (!qt.order.paid.equals(PaymentStatus.TRYING)) {
tryDequeue(); tryDequeue();
LOG.trace(ORDER + qt.order.id + ": This payment task already done, dequeueing.."); LOG.trace(ORDER_ID + ": This payment task already done, dequeueing..", qt.order.id);
} else { } else {
sendPaymentRequest(qt.order); sendPaymentRequest(qt.order);
LOG.debug(ORDER + qt.order.id + ": Trying to connect to payment service.."); LOG.debug(ORDER_ID + ": Trying to connect to payment service..", qt.order.id);
} }
} else if (qt.taskType.equals(TaskType.MESSAGING)) { } else if (qt.taskType.equals(TaskType.MESSAGING)) {
if (qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL) if (qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL)
|| qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) { || qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) {
tryDequeue(); tryDequeue();
LOG.trace(ORDER + qt.order.id + ": This messaging task already done, dequeue.."); LOG.trace(ORDER_ID + ": This messaging task already done, dequeue..", qt.order.id);
} else if (qt.messageType == 1 && (!qt.order.messageSent.equals(MessageSent.NONE_SENT) } else if (qt.messageType == 1 && (!qt.order.messageSent.equals(MessageSent.NONE_SENT)
|| !qt.order.paid.equals(PaymentStatus.TRYING))) { || !qt.order.paid.equals(PaymentStatus.TRYING))) {
tryDequeue(); tryDequeue();
LOG.trace(ORDER + qt.order.id + ": This messaging task does not need to be done," LOG.trace(ORDER_ID + ": This messaging task does not need to be done,"
+ " dequeue.."); + " dequeue..", qt.order.id);
} else if (qt.messageType == 0) { } else if (qt.messageType == 0) {
sendPaymentFailureMessage(qt.order); sendPaymentFailureMessage(qt.order);
LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC); LOG.debug(ORDER_ID + TRY_CONNECTING_MSG_SVC, qt.order.id);
} else if (qt.messageType == 1) { } else if (qt.messageType == 1) {
sendPaymentPossibleErrorMsg(qt.order); sendPaymentPossibleErrorMsg(qt.order);
LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC); LOG.debug(ORDER_ID + TRY_CONNECTING_MSG_SVC, qt.order.id);
} else if (qt.messageType == 2) { } else if (qt.messageType == 2) {
sendSuccessMessage(qt.order); sendSuccessMessage(qt.order);
LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC); LOG.debug(ORDER_ID + TRY_CONNECTING_MSG_SVC, qt.order.id);
} }
} else if (qt.taskType.equals(TaskType.EMPLOYEE_DB)) { } else if (qt.taskType.equals(TaskType.EMPLOYEE_DB)) {
if (qt.order.addedToEmployeeHandle) { if (qt.order.addedToEmployeeHandle) {
tryDequeue(); tryDequeue();
LOG.trace(ORDER + qt.order.id + ": This employee handle task already done," LOG.trace(ORDER_ID + ": This employee handle task already done,"
+ " dequeue.."); + " dequeue..", qt.order.id);
} else { } else {
employeeHandleIssue(qt.order); employeeHandleIssue(qt.order);
LOG.debug(ORDER + qt.order.id + ": Trying to connect to employee handle.."); LOG.debug(ORDER_ID + ": Trying to connect to employee handle..", qt.order.id);
} }
} }
} }