Minor refactorings and code style changes (#807)
* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals * Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments * Removed unused import from Promise * Addressed review comments * Addressed checkstyle issue
This commit is contained in:
@ -171,11 +171,11 @@ public class SimpleFluentIterable<E> implements FluentIterable<E> {
|
||||
/**
|
||||
* @return a FluentIterable from a given iterable. Calls the SimpleFluentIterable constructor.
|
||||
*/
|
||||
public static final <E> FluentIterable<E> from(Iterable<E> iterable) {
|
||||
public static <E> FluentIterable<E> from(Iterable<E> iterable) {
|
||||
return new SimpleFluentIterable<>(iterable);
|
||||
}
|
||||
|
||||
public static final <E> FluentIterable<E> fromCopyOf(Iterable<E> iterable) {
|
||||
public static <E> FluentIterable<E> fromCopyOf(Iterable<E> iterable) {
|
||||
List<E> copy = FluentIterable.copyToList(iterable);
|
||||
return new SimpleFluentIterable<>(copy);
|
||||
}
|
||||
|
@ -179,15 +179,15 @@ public abstract class FluentIterableTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testForEach() throws Exception {
|
||||
public void testForEach() {
|
||||
final List<Integer> integers = Arrays.asList(1, 2, 3);
|
||||
|
||||
final Consumer<Integer> consumer = mock(Consumer.class);
|
||||
createFluentIterable(integers).forEach(consumer);
|
||||
|
||||
verify(consumer, times(1)).accept(Integer.valueOf(1));
|
||||
verify(consumer, times(1)).accept(Integer.valueOf(2));
|
||||
verify(consumer, times(1)).accept(Integer.valueOf(3));
|
||||
verify(consumer, times(1)).accept(1);
|
||||
verify(consumer, times(1)).accept(2);
|
||||
verify(consumer, times(1)).accept(3);
|
||||
verifyNoMoreInteractions(consumer);
|
||||
|
||||
}
|
||||
|
Reference in New Issue
Block a user