gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Minor refactorings and code style changes (#807)

Browse Source 
* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals

* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

* Removed unused import from Promise

* Addressed review comments

* Addressed checkstyle issue
This commit is contained in:
Narendra Pathai
2018-10-23 13:45:41 +05:30
committed by GitHub
parent 25ed7c09c5
commit 2aa9e78ddd
112 changed files with 312 additions and 463 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java
View File

@ -27,6 +27,7 @@ import java.io.FileReader;
import java.io.IOException;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
/**
* The Module pattern can be considered a Creational pattern and a Structural pattern. It manages
@ -88,7 +89,7 @@ public final class FileLoggerModuleTest {
fileLoggerModule.prepare();
/* Test if nothing is printed in file */
assertEquals(readFirstLine(OUTPUT_FILE), null);
assertNull(readFirstLine(OUTPUT_FILE));
/* Unprepare to cleanup the modules */
fileLoggerModule.unprepare();
@ -113,7 +114,7 @@ public final class FileLoggerModuleTest {
fileLoggerModule.printErrorString(ERROR);
/* Test if 'Message' is printed in file */
assertEquals(readFirstLine(ERROR_FILE), ERROR);
assertEquals(ERROR, readFirstLine(ERROR_FILE));
/* Unprepare to cleanup the modules */
fileLoggerModule.unprepare();
@ -135,7 +136,7 @@ public final class FileLoggerModuleTest {
fileLoggerModule.prepare();
/* Test if nothing is printed in file */
assertEquals(readFirstLine(ERROR_FILE), null);
assertNull(readFirstLine(ERROR_FILE));
/* Unprepare to cleanup the modules */
fileLoggerModule.unprepare();
@ -150,11 +151,7 @@ public final class FileLoggerModuleTest {
private static final String readFirstLine(final String file) {
String firstLine = null;
BufferedReader bufferedReader = null;
try {
/* Create a buffered reader */
bufferedReader = new BufferedReader(new FileReader(file));
try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
while (bufferedReader.ready()) {
@ -166,15 +163,6 @@ public final class FileLoggerModuleTest {
} catch (final IOException e) {
LOGGER.error("ModuleTest::readFirstLine()", e);
} finally {
if (bufferedReader != null) {
try {
bufferedReader.close();
} catch (final IOException e) {
LOGGER.error("ModuleTest::readFirstLine()", e);
}
}
}
return firstLine;