Minor refactorings and code style changes (#807)

* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals

* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

* Removed unused import from Promise

* Addressed review comments

* Addressed checkstyle issue

promise/src/main/java/com/iluwatar/promise/App.java

@@ -155,19 +155,15 @@ public class App {
    * This is an async method and does not wait until the file is downloaded.
    */
   private Promise<String> download(String urlString) {
-    Promise<String> downloadPromise = new Promise<String>()
+    return new Promise<String>()
         .fulfillInAsync(
-            () -> {
-              return Utility.downloadFile(urlString);
-            }, executor)
+            () -> Utility.downloadFile(urlString), executor)
         .onError(
             throwable -> {
               throwable.printStackTrace();
               taskCompleted();
             }
         );
-
-    return downloadPromise;
   }
 
   private void stop() throws InterruptedException {

promise/src/main/java/com/iluwatar/promise/Utility.java

@@ -32,7 +32,6 @@ import java.io.FileWriter;
 import java.io.IOException;
 import java.io.InputStreamReader;
 import java.io.Reader;
-import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.HashMap;
 import java.util.Iterator;
@@ -111,7 +110,7 @@ public class Utility {
    * Downloads the contents from the given urlString, and stores it in a temporary directory.
    * @return the absolute path of the file downloaded.
    */
-  public static String downloadFile(String urlString) throws MalformedURLException, IOException {
+  public static String downloadFile(String urlString) throws IOException {
     LOGGER.info("Downloading contents from url: {}", urlString);
     URL url = new URL(urlString);
     File file = File.createTempFile("promise_pattern", null);

promise/src/test/java/com/iluwatar/promise/PromiseTest.java

@@ -76,12 +76,8 @@ public class PromiseTest {
   private void testWaitingForeverForPromiseToBeFulfilled() 
       throws InterruptedException, TimeoutException {
     Promise<Integer> promise = new Promise<>();
-    promise.fulfillInAsync(new Callable<Integer>() {
-
-      @Override
-      public Integer call() throws Exception {
-        throw new RuntimeException("Barf!");
-      }
+    promise.fulfillInAsync(() -> {
+      throw new RuntimeException("Barf!");
     }, executor);
     
     try {
@@ -104,12 +100,8 @@ public class PromiseTest {
   private void testWaitingSomeTimeForPromiseToBeFulfilled() 
       throws InterruptedException, TimeoutException {
     Promise<Integer> promise = new Promise<>();
-    promise.fulfillInAsync(new Callable<Integer>() {
-
-      @Override
-      public Integer call() throws Exception {
-        throw new RuntimeException("Barf!");
-      }
+    promise.fulfillInAsync(() -> {
+      throw new RuntimeException("Barf!");
     }, executor);
     
     try {
@@ -150,12 +142,8 @@ public class PromiseTest {
       throws InterruptedException, ExecutionException, TimeoutException {
     Promise<Void> dependentPromise = promise
         .fulfillInAsync(new NumberCrunchingTask(), executor)
-        .thenAccept(new Consumer<Integer>() {
-
-          @Override
-          public void accept(Integer value) {
-            throw new RuntimeException("Barf!");
-          }
+        .thenAccept(value -> {
+          throw new RuntimeException("Barf!");
         });
 
     try {
@@ -198,12 +186,8 @@ public class PromiseTest {
       throws InterruptedException, ExecutionException, TimeoutException {
     Promise<String> dependentPromise = promise
         .fulfillInAsync(new NumberCrunchingTask(), executor)
-        .thenApply(new Function<Integer, String>() {
-
-          @Override
-          public String apply(Integer value) {
-            throw new RuntimeException("Barf!");
-          }
+        .thenApply(value -> {
+          throw new RuntimeException("Barf!");
         });
 
     try {