Minor refactorings and code style changes (#807)

* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals

* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

* Removed unused import from Promise

* Addressed review comments

* Addressed checkstyle issue

queue-load-leveling/src/main/java/com/iluwatar/queue/load/leveling/App.java

@@ -110,8 +110,6 @@ public class App {
         LOGGER.info("Executor was shut down and Exiting.");
         executor.shutdownNow();
       }
-    } catch (InterruptedException ie) {
-      LOGGER.error(ie.getMessage());
     } catch (Exception e) {
       LOGGER.error(e.getMessage());
     }

queue-load-leveling/src/main/java/com/iluwatar/queue/load/leveling/ServiceExecutor.java

@@ -58,8 +58,6 @@ public class ServiceExecutor implements Runnable {
 
         Thread.sleep(1000);
       }
-    } catch (InterruptedException ie) {
-      LOGGER.error(ie.getMessage());
     } catch (Exception e) {
       LOGGER.error(e.getMessage());
     }

queue-load-leveling/src/main/java/com/iluwatar/queue/load/leveling/TaskGenerator.java

@@ -80,8 +80,6 @@ public class TaskGenerator implements Task, Runnable {
         // Make the current thread to sleep after every Message submission.
         Thread.sleep(1000);
       }
-    } catch (InterruptedException ie) {
-      LOGGER.error(ie.getMessage());
     } catch (Exception e) {
       LOGGER.error(e.getMessage());
     }

queue-load-leveling/src/test/java/com/iluwatar/queue/load/leveling/MessageQueueTest.java

@@ -42,7 +42,7 @@ public class MessageQueueTest {
     msgQueue.submitMsg(new Message("MessageQueue Test"));
     
     // retrieve message
-    assertEquals(msgQueue.retrieveMsg().getMsg(), "MessageQueue Test");
+    assertEquals("MessageQueue Test", msgQueue.retrieveMsg().getMsg());
   }
 
 }

queue-load-leveling/src/test/java/com/iluwatar/queue/load/leveling/MessageTest.java

@@ -39,6 +39,6 @@ public class MessageTest {
     // Parameterized constructor test.
     String testMsg = "Message Test";
     Message msg = new Message(testMsg);
-    assertEquals(msg.getMsg(), testMsg);
+    assertEquals(testMsg, msg.getMsg());
   }
 }