gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Minor refactorings and code style changes (#807)

Browse Source 
* Made minor changes in some patterns such as removed throws clause where not needed, changed incorrect order of arguments in assertEquals

* Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

* Removed unused import from Promise

* Addressed review comments

* Addressed checkstyle issue
This commit is contained in:
Narendra Pathai
2018-10-23 13:45:41 +05:30
committed by GitHub
parent 25ed7c09c5
commit 2aa9e78ddd
112 changed files with 312 additions and 463 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
servant/src/test/java/com/iluwatar/servant/QueenTest.java
View File

@ -36,7 +36,7 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
public class QueenTest {
@Test
public void testNotFlirtyUncomplemented() throws Exception {
public void testNotFlirtyUncomplemented() {
final Queen queen = new Queen();
queen.setFlirtiness(false);
queen.changeMood();
@ -44,7 +44,7 @@ public class QueenTest {
}
@Test
public void testNotFlirtyComplemented() throws Exception {
public void testNotFlirtyComplemented() {
final Queen queen = new Queen();
queen.setFlirtiness(false);
queen.receiveCompliments();
@ -53,14 +53,14 @@ public class QueenTest {
}
@Test
public void testFlirtyUncomplemented() throws Exception {
public void testFlirtyUncomplemented() {
final Queen queen = new Queen();
queen.changeMood();
assertFalse(queen.getMood());
}
@Test
public void testFlirtyComplemented() throws Exception {
public void testFlirtyComplemented() {
final Queen queen = new Queen();
queen.receiveCompliments();
queen.changeMood();

8
servant/src/test/java/com/iluwatar/servant/ServantTest.java
View File

@ -41,7 +41,7 @@ import static org.mockito.Mockito.when;
public class ServantTest {
@Test
public void testFeed() throws Exception {
public void testFeed() {
final Royalty royalty = mock(Royalty.class);
final Servant servant = new Servant("test");
servant.feed(royalty);
@ -50,7 +50,7 @@ public class ServantTest {
}
@Test
public void testGiveWine() throws Exception {
public void testGiveWine() {
final Royalty royalty = mock(Royalty.class);
final Servant servant = new Servant("test");
servant.giveWine(royalty);
@ -59,7 +59,7 @@ public class ServantTest {
}
@Test
public void testGiveCompliments() throws Exception {
public void testGiveCompliments() {
final Royalty royalty = mock(Royalty.class);
final Servant servant = new Servant("test");
servant.giveCompliments(royalty);
@ -68,7 +68,7 @@ public class ServantTest {
}
@Test
public void testCheckIfYouWillBeHanged() throws Exception {
public void testCheckIfYouWillBeHanged() {
final Royalty goodMoodRoyalty = mock(Royalty.class);
when(goodMoodRoyalty.getMood()).thenReturn(true);