gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: Remove unnecessary and possibly not threadsafe flag (#1811)

Browse Source
This commit is contained in:
Morteza Adigozalpour 2021-09-07 20:43:47 +02:00 committed by GitHub
parent e2ebb59fe7
commit 3126ad3106
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java
View File

@ -36,16 +36,12 @@ public final class ThreadSafeDoubleCheckLocking {
private static volatile ThreadSafeDoubleCheckLocking instance; private static volatile ThreadSafeDoubleCheckLocking instance;
private static boolean flag = true;
/** /**
* private constructor to prevent client from instantiating. * private constructor to prevent client from instantiating.
*/ */
private ThreadSafeDoubleCheckLocking() { private ThreadSafeDoubleCheckLocking() {
// to prevent instantiating by Reflection call // to prevent instantiating by Reflection call
if (flag) { if (instance != null) {
flag = false;
} else {
throw new IllegalStateException("Already initialized."); throw new IllegalStateException("Already initialized.");
} }
} }

4
singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java
View File

@ -34,9 +34,7 @@ public final class ThreadSafeLazyLoadedIvoryTower {
private ThreadSafeLazyLoadedIvoryTower() { private ThreadSafeLazyLoadedIvoryTower() {
// Protect against instantiation via reflection // Protect against instantiation via reflection
if (instance == null) { if (instance != null) {
instance = this;
} else {
throw new IllegalStateException("Already initialized."); throw new IllegalStateException("Already initialized.");
} }
} }