gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix Sonar critical issue - Define constant instead of duplicating the literal

Browse Source
This commit is contained in:
atayal
2021-10-30 23:26:11 +05:30
parent 31ed864f7a
commit 3476a80ef5
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
commander/src/main/java/com/iluwatar/commander/Commander.java
View File

@ -93,6 +93,7 @@ public class Commander {
private static final String ORDER = "Order "; private static final String ORDER = "Order ";
private static final String REQUEST_ID = " request Id: "; private static final String REQUEST_ID = " request Id: ";
private static final String ERROR_CONNECTING_MSG_SVC = ": Error in connecting to messaging service "; private static final String ERROR_CONNECTING_MSG_SVC = ": Error in connecting to messaging service ";
private static final String TRY_CONNECTING_MSG_SVC = ": Trying to connect to messaging service..";
Commander(EmployeeHandle empDb, PaymentService paymentService, ShippingService shippingService, Commander(EmployeeHandle empDb, PaymentService paymentService, ShippingService shippingService,
MessagingService messagingService, QueueDatabase qdb, int numOfRetries, MessagingService messagingService, QueueDatabase qdb, int numOfRetries,
@ -571,13 +572,13 @@ public class Commander {
+ " dequeue.."); + " dequeue..");
} else if (qt.messageType == 0) { } else if (qt.messageType == 0) {
sendPaymentFailureMessage(qt.order); sendPaymentFailureMessage(qt.order);
LOG.debug(ORDER + qt.order.id + ": Trying to connect to messaging service.."); LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC);
} else if (qt.messageType == 1) { } else if (qt.messageType == 1) {
sendPaymentPossibleErrorMsg(qt.order); sendPaymentPossibleErrorMsg(qt.order);
LOG.debug(ORDER + qt.order.id + ": Trying to connect to messaging service.."); LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC);
} else if (qt.messageType == 2) { } else if (qt.messageType == 2) {
sendSuccessMessage(qt.order); sendSuccessMessage(qt.order);
LOG.debug(ORDER + qt.order.id + ": Trying to connect to messaging service.."); LOG.debug(ORDER + qt.order.id + TRY_CONNECTING_MSG_SVC);
} }
} else if (qt.taskType.equals(TaskType.EMPLOYEE_DB)) { } else if (qt.taskType.equals(TaskType.EMPLOYEE_DB)) {
if (qt.order.addedToEmployeeHandle) { if (qt.order.addedToEmployeeHandle) {