From 3791a80978d126370c8be5be4d0f3b97925d23f4 Mon Sep 17 00:00:00 2001
From: Mohammed Ezzat <mohamed.ezzat@aurea.com>
Date: Mon, 22 Feb 2016 19:15:51 +0200
Subject: [PATCH] squid:S2325 - private methods that don't access instance data
 should be static

---
 .../java/com/iluwatar/facade/DwarvenGoldmineFacade.java     | 2 +-
 .../java/com/iluwatar/front/controller/FrontController.java | 2 +-
 .../main/java/com/iluwatar/reactor/app/LoggingHandler.java  | 6 +++---
 .../java/com/iluwatar/reactor/framework/NioReactor.java     | 2 +-
 .../com/iluwatar/reader/writer/lock/ReaderWriterLock.java   | 2 +-
 .../src/main/java/com/iluwatar/repository/AppConfig.java    | 2 +-
 6 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java b/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java
index 9e3aa29c3..4f6e3be4c 100644
--- a/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java
+++ b/facade/src/main/java/com/iluwatar/facade/DwarvenGoldmineFacade.java
@@ -60,7 +60,7 @@ public class DwarvenGoldmineFacade {
     makeActions(workers, DwarvenMineWorker.Action.GO_HOME, DwarvenMineWorker.Action.GO_TO_SLEEP);
   }
 
-  private void makeActions(Collection<DwarvenMineWorker> workers,
+  private static void makeActions(Collection<DwarvenMineWorker> workers,
       DwarvenMineWorker.Action... actions) {
     for (DwarvenMineWorker worker : workers) {
       worker.action(actions);
diff --git a/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java b/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java
index f5537c39b..6e2cccb0f 100644
--- a/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java
+++ b/front-controller/src/main/java/com/iluwatar/front/controller/FrontController.java
@@ -44,7 +44,7 @@ public class FrontController {
     }
   }
 
-  private Class getCommandClass(String request) {
+  private static Class getCommandClass(String request) {
     Class result;
     try {
       result = Class.forName("com.iluwatar.front.controller." + request + "Command");
diff --git a/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java b/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java
index 88716728c..c8eee2d81 100644
--- a/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java
+++ b/reactor/src/main/java/com/iluwatar/reactor/app/LoggingHandler.java
@@ -58,7 +58,7 @@ public class LoggingHandler implements ChannelHandler {
     }
   }
 
-  private void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {
+  private static void sendReply(AbstractNioChannel channel, DatagramPacket incomingPacket, SelectionKey key) {
     /*
      * Create a reply acknowledgement datagram packet setting the receiver to the sender of incoming
      * message.
@@ -69,12 +69,12 @@ public class LoggingHandler implements ChannelHandler {
     channel.write(replyPacket, key);
   }
 
-  private void sendReply(AbstractNioChannel channel, SelectionKey key) {
+  private static void sendReply(AbstractNioChannel channel, SelectionKey key) {
     ByteBuffer buffer = ByteBuffer.wrap(ACK);
     channel.write(buffer, key);
   }
 
-  private void doLogging(ByteBuffer data) {
+  private static void doLogging(ByteBuffer data) {
     // assuming UTF-8 :(
     System.out.println(new String(data.array(), 0, data.limit()));
   }
diff --git a/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java b/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java
index 716f88801..3d5ebf5a0 100644
--- a/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java
+++ b/reactor/src/main/java/com/iluwatar/reactor/framework/NioReactor.java
@@ -186,7 +186,7 @@ public class NioReactor {
     }
   }
 
-  private void onChannelWritable(SelectionKey key) throws IOException {
+  private static void onChannelWritable(SelectionKey key) throws IOException {
     AbstractNioChannel channel = (AbstractNioChannel) key.attachment();
     channel.flush(key);
   }
diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java
index c8f59edd5..f08ed805d 100644
--- a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java
+++ b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/ReaderWriterLock.java
@@ -89,7 +89,7 @@ public class ReaderWriterLock implements ReadWriteLock {
     return globalMutex.isEmpty();
   }
 
-  private void waitUninterruptibly(Object o) {
+  private static void waitUninterruptibly(Object o) {
     try {
       o.wait();
     } catch (InterruptedException e) {
diff --git a/repository/src/main/java/com/iluwatar/repository/AppConfig.java b/repository/src/main/java/com/iluwatar/repository/AppConfig.java
index 285ecfbfe..3e7093358 100644
--- a/repository/src/main/java/com/iluwatar/repository/AppConfig.java
+++ b/repository/src/main/java/com/iluwatar/repository/AppConfig.java
@@ -76,7 +76,7 @@ public class AppConfig {
   /**
    * Properties for Jpa
    */
-  private Properties jpaProperties() {
+  private static Properties jpaProperties() {
     Properties properties = new Properties();
     properties.setProperty("hibernate.dialect", "org.hibernate.dialect.H2Dialect");
     properties.setProperty("hibernate.hbm2ddl.auto", "create-drop");