From 37be2bb2a4a1dee126f50df3f3abae9d78d2eacc Mon Sep 17 00:00:00 2001 From: atayal Date: Fri, 5 Nov 2021 16:59:40 +0530 Subject: [PATCH] sonar fix - add test cases for CommanderTest --- .../com/iluwatar/commander/CommanderTest.java | 28 +++++++++++++++++-- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/commander/src/test/java/com/iluwatar/commander/CommanderTest.java b/commander/src/test/java/com/iluwatar/commander/CommanderTest.java index e8f5daa4f..ba066a732 100644 --- a/commander/src/test/java/com/iluwatar/commander/CommanderTest.java +++ b/commander/src/test/java/com/iluwatar/commander/CommanderTest.java @@ -53,7 +53,7 @@ class CommanderTest { queueTime, queueTaskTime, paymentTime, messageTime, employeeTime); } - private Commander buildCommanderObject2() { + private Commander buildCommanderObjectUnknownException() { PaymentService paymentService = new PaymentService (new PaymentDatabase(), new IllegalStateException()); var shippingService = new ShippingService(new ShippingDatabase()); @@ -67,6 +67,20 @@ class CommanderTest { queueTime, queueTaskTime, paymentTime, messageTime, employeeTime); } + private Commander buildCommanderObjectNoException() { + PaymentService paymentService = new PaymentService + (new PaymentDatabase()); + var shippingService = new ShippingService(new ShippingDatabase()); + var messagingService = new MessagingService(new MessagingDatabase()); + var employeeHandle = new EmployeeHandle + (new EmployeeDatabase(), new IllegalStateException()); + var qdb = new QueueDatabase + (new DatabaseUnavailableException(), new IllegalStateException()); + return new Commander(employeeHandle, paymentService, shippingService, + messagingService, qdb, numOfRetries, retryDuration, + queueTime, queueTaskTime, paymentTime, messageTime, employeeTime); + } + private Commander buildCommanderObjectWithDB() { return buildCommanderObjectWithoutDB(false, false, new IllegalStateException()); } @@ -140,8 +154,16 @@ class CommanderTest { } @Test - void testPlaceOrder2() throws Exception { - Commander c = buildCommanderObject2(); + void testPlaceOrderNoException() throws Exception { + Commander c = buildCommanderObjectNoException(); + var order = new Order(new User("K", "J"), "pen", 1f); + c.placeOrder(order); + assertFalse(StringUtils.isBlank(order.id)); + } + + @Test + void testPlaceOrderUnknownException() throws Exception { + Commander c = buildCommanderObjectUnknownException(); var order = new Order(new User("K", "J"), "pen", 1f); c.placeOrder(order); assertFalse(StringUtils.isBlank(order.id));