diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/App.java b/semaphore/src/main/java/com/iluwatar/semaphore/App.java index e1f43cf97..ccf3dc4ab 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/App.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/App.java @@ -25,18 +25,17 @@ package com.iluwatar.semaphore; /** * A Semaphore mediates access by a group of threads to a pool of resources. - *

- * In this example a group of customers are taking fruit from a fruit shop. - * There is a bowl each of apples, oranges and lemons. Only one customer can - * access a bowl simultaneously. A Semaphore is used to indicate how many - * resources are currently available and must be acquired in order for a bowl - * to be given to a customer. Customers continually try to take fruit until - * there is no fruit left in the shop. + * + *

In this example a group of customers are taking fruit from a fruit shop. There is a bowl each + * of apples, oranges and lemons. Only one customer can access a bowl simultaneously. A Semaphore is + * used to indicate how many resources are currently available and must be acquired in order for a + * bowl to be given to a customer. Customers continually try to take fruit until there is no fruit + * left in the shop. */ public class App { - + /** - * main method + * main method. */ public static void main(String[] args) { FruitShop shop = new FruitShop(); @@ -47,5 +46,5 @@ public class App { new Customer("Ringo", shop).start(); new Customer("George", shop).start(); } - + } diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/Customer.java b/semaphore/src/main/java/com/iluwatar/semaphore/Customer.java index 4e380f92a..97c9cf0e0 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/Customer.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/Customer.java @@ -27,8 +27,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * A Customer attempts to repeatedly take Fruit from the FruitShop by - * taking Fruit from FruitBowl instances. + * A Customer attempts to repeatedly take Fruit from the FruitShop by taking Fruit from FruitBowl + * instances. */ public class Customer extends Thread { @@ -38,36 +38,35 @@ public class Customer extends Thread { * Name of the Customer. */ private final String name; - + /** * The FruitShop he is using. */ private final FruitShop fruitShop; - + /** * Their bowl of Fruit. */ private final FruitBowl fruitBowl; - + /** - * Customer constructor + * Customer constructor. */ public Customer(String name, FruitShop fruitShop) { this.name = name; this.fruitShop = fruitShop; this.fruitBowl = new FruitBowl(); } - + /** - * The Customer repeatedly takes Fruit from the FruitShop until no Fruit - * remains. - */ + * The Customer repeatedly takes Fruit from the FruitShop until no Fruit remains. + */ public void run() { - + while (fruitShop.countFruit() > 0) { FruitBowl bowl = fruitShop.takeBowl(); Fruit fruit; - + if (bowl != null && (fruit = bowl.take()) != null) { LOGGER.info("{} took an {}", name, fruit); fruitBowl.put(fruit); @@ -76,7 +75,7 @@ public class Customer extends Thread { } LOGGER.info("{} took {}", name, fruitBowl); - + } - + } diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/Fruit.java b/semaphore/src/main/java/com/iluwatar/semaphore/Fruit.java index 05872be9d..d94764dbe 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/Fruit.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/Fruit.java @@ -29,7 +29,7 @@ package com.iluwatar.semaphore; public class Fruit { /** - * Enumeration of Fruit Types + * Enumeration of Fruit Types. */ public enum FruitType { ORANGE, APPLE, LEMON @@ -46,7 +46,7 @@ public class Fruit { } /** - * toString method + * toString method. */ public String toString() { switch (type) { diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/FruitBowl.java b/semaphore/src/main/java/com/iluwatar/semaphore/FruitBowl.java index 8696709a0..9089f9c73 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/FruitBowl.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/FruitBowl.java @@ -23,19 +23,20 @@ package com.iluwatar.semaphore; -import java.util.List; import java.util.ArrayList; +import java.util.List; /** - * A FruitBowl contains Fruit. + * A FruitBowl contains Fruit. */ public class FruitBowl { - + private List fruit = new ArrayList<>(); /** - * - * @return The amount of Fruit left in the bowl. + * Returns the amount of fruits left in bowl. + * + * @return The amount of Fruit left in the bowl. */ public int countFruit() { return fruit.size(); @@ -43,15 +44,16 @@ public class FruitBowl { /** * Put an item of Fruit into the bowl. - * + * * @param f fruit */ public void put(Fruit f) { fruit.add(f); } - + /** * Take an item of Fruit out of the bowl. + * * @return The Fruit taken out of the bowl, or null if empty. */ public Fruit take() { @@ -61,15 +63,15 @@ public class FruitBowl { return fruit.remove(0); } } - + /** - * toString method - */ + * toString method. + */ public String toString() { int apples = 0; int oranges = 0; int lemons = 0; - + for (Fruit f : fruit) { switch (f.getType()) { case APPLE: @@ -84,7 +86,7 @@ public class FruitBowl { default: } } - + return apples + " Apples, " + oranges + " Oranges, and " + lemons + " Lemons"; } } diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/FruitShop.java b/semaphore/src/main/java/com/iluwatar/semaphore/FruitShop.java index cd71955fb..ba826fb09 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/FruitShop.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/FruitShop.java @@ -27,32 +27,32 @@ package com.iluwatar.semaphore; * A FruitShop contains three FruitBowl instances and controls access to them. */ public class FruitShop { - + /** * The FruitBowl instances stored in the class. */ private FruitBowl[] bowls = { - new FruitBowl(), - new FruitBowl(), - new FruitBowl() + new FruitBowl(), + new FruitBowl(), + new FruitBowl() }; /** * Access flags for each of the FruitBowl instances. */ private boolean[] available = { - true, - true, - true + true, + true, + true }; /** * The Semaphore that controls access to the class resources. */ private Semaphore semaphore; - + /** - * FruitShop constructor + * FruitShop constructor. */ public FruitShop() { for (int i = 0; i < 100; i++) { @@ -60,30 +60,30 @@ public class FruitShop { bowls[1].put(new Fruit(Fruit.FruitType.ORANGE)); bowls[2].put(new Fruit(Fruit.FruitType.LEMON)); } - + semaphore = new Semaphore(3); } /** - * + * Returns the amount of fruits left in shop. + * * @return The amount of Fruit left in the shop. */ public synchronized int countFruit() { return bowls[0].countFruit() + bowls[1].countFruit() + bowls[2].countFruit(); } - + /** - * Method called by Customer to get a FruitBowl from the shop. This method - * will try to acquire the Semaphore before returning the first available - * FruitBowl. - */ + * Method called by Customer to get a FruitBowl from the shop. This method will try to acquire the + * Semaphore before returning the first available FruitBowl. + */ public synchronized FruitBowl takeBowl() { - + FruitBowl bowl = null; - + try { semaphore.acquire(); - + if (available[0]) { bowl = bowls[0]; available[0] = false; @@ -94,7 +94,7 @@ public class FruitShop { bowl = bowls[2]; available[2] = false; } - + } catch (InterruptedException e) { e.printStackTrace(); } finally { @@ -102,20 +102,19 @@ public class FruitShop { } return bowl; } - + /** - * Method called by a Customer instance to return a FruitBowl to the shop. - * This method releases the Semaphore, making the FruitBowl available to - * another Customer. - */ + * Method called by a Customer instance to return a FruitBowl to the shop. This method releases + * the Semaphore, making the FruitBowl available to another Customer. + */ public synchronized void returnBowl(FruitBowl bowl) { if (bowl == bowls[0]) { available[0] = true; } else if (bowl == bowls[1]) { available[1] = true; } else if (bowl == bowls[2]) { - available [2] = true; + available[2] = true; } } - + } diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/Lock.java b/semaphore/src/main/java/com/iluwatar/semaphore/Lock.java index df7df2cf0..5679e2a05 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/Lock.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/Lock.java @@ -27,9 +27,9 @@ package com.iluwatar.semaphore; * Lock is an interface for a lock which can be acquired and released. */ public interface Lock { - + void acquire() throws InterruptedException; - + void release(); - + } diff --git a/semaphore/src/main/java/com/iluwatar/semaphore/Semaphore.java b/semaphore/src/main/java/com/iluwatar/semaphore/Semaphore.java index 9dfe79316..48b008fdd 100644 --- a/semaphore/src/main/java/com/iluwatar/semaphore/Semaphore.java +++ b/semaphore/src/main/java/com/iluwatar/semaphore/Semaphore.java @@ -33,30 +33,29 @@ public class Semaphore implements Lock { * The number of concurrent resource accesses which are allowed. */ private int counter; - + public Semaphore(int licenses) { this.licenses = licenses; - this.counter = licenses; + this.counter = licenses; } - + /** - * Returns the number of licenses managed by the Semaphore + * Returns the number of licenses managed by the Semaphore. */ public int getNumLicenses() { return licenses; } - + /** - * Returns the number of available licenses + * Returns the number of available licenses. */ public int getAvailableLicenses() { - return counter; + return counter; } - + /** - * Method called by a thread to acquire the lock. If there are no resources - * available this will wait until the lock has been released to re-attempt - * the acquire. + * Method called by a thread to acquire the lock. If there are no resources available this will + * wait until the lock has been released to re-attempt the acquire. */ public synchronized void acquire() throws InterruptedException { while (counter == 0) { @@ -64,7 +63,7 @@ public class Semaphore implements Lock { } counter = counter - 1; } - + /** * Method called by a thread to release the lock. */ diff --git a/servant/src/main/java/com/iluwatar/servant/App.java b/servant/src/main/java/com/iluwatar/servant/App.java index 35a26dbcc..fcebec5bf 100644 --- a/servant/src/main/java/com/iluwatar/servant/App.java +++ b/servant/src/main/java/com/iluwatar/servant/App.java @@ -23,29 +23,27 @@ package com.iluwatar.servant; +import java.util.List; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.List; - /** * Servant offers some functionality to a group of classes without defining that functionality in * each of them. A Servant is a class whose instance provides methods that take care of a desired * service, while objects for which the servant does something, are taken as parameters. - *

- * In this example {@link Servant} is serving {@link King} and {@link Queen}. * + *

In this example {@link Servant} is serving {@link King} and {@link Queen}. */ public class App { private static final Logger LOGGER = LoggerFactory.getLogger(App.class); - static Servant jenkins = new Servant("Jenkins"); - static Servant travis = new Servant("Travis"); + private static Servant jenkins = new Servant("Jenkins"); + private static Servant travis = new Servant("Travis"); /** - * Program entry point + * Program entry point. */ public static void main(String[] args) { scenario(jenkins, 1); @@ -53,7 +51,7 @@ public class App { } /** - * Can add a List with enum Actions for variable scenarios + * Can add a List with enum Actions for variable scenarios. */ public static void scenario(Servant servant, int compliment) { King k = new King(); diff --git a/servant/src/main/java/com/iluwatar/servant/King.java b/servant/src/main/java/com/iluwatar/servant/King.java index 19db41201..1017ef378 100644 --- a/servant/src/main/java/com/iluwatar/servant/King.java +++ b/servant/src/main/java/com/iluwatar/servant/King.java @@ -24,9 +24,7 @@ package com.iluwatar.servant; /** - * - * King - * + * King. */ public class King implements Royalty { diff --git a/servant/src/main/java/com/iluwatar/servant/Queen.java b/servant/src/main/java/com/iluwatar/servant/Queen.java index 3e4fa486f..416efaade 100644 --- a/servant/src/main/java/com/iluwatar/servant/Queen.java +++ b/servant/src/main/java/com/iluwatar/servant/Queen.java @@ -24,9 +24,7 @@ package com.iluwatar.servant; /** - * - * Queen - * + * Queen. */ public class Queen implements Royalty { diff --git a/servant/src/main/java/com/iluwatar/servant/Royalty.java b/servant/src/main/java/com/iluwatar/servant/Royalty.java index 88c301ffe..959d108f0 100644 --- a/servant/src/main/java/com/iluwatar/servant/Royalty.java +++ b/servant/src/main/java/com/iluwatar/servant/Royalty.java @@ -24,9 +24,7 @@ package com.iluwatar.servant; /** - * - * Royalty - * + * Royalty. */ interface Royalty { diff --git a/servant/src/main/java/com/iluwatar/servant/Servant.java b/servant/src/main/java/com/iluwatar/servant/Servant.java index 97d6107c4..856f7806b 100644 --- a/servant/src/main/java/com/iluwatar/servant/Servant.java +++ b/servant/src/main/java/com/iluwatar/servant/Servant.java @@ -26,16 +26,14 @@ package com.iluwatar.servant; import java.util.List; /** - * - * Servant - * + * Servant. */ public class Servant { public String name; /** - * Constructor + * Constructor. */ public Servant(String name) { this.name = name; @@ -54,7 +52,7 @@ public class Servant { } /** - * Check if we will be hanged + * Check if we will be hanged. */ public boolean checkIfYouWillBeHanged(List tableGuests) { boolean anotherDay = true; diff --git a/serverless/src/main/java/com/iluwatar/serverless/baas/api/AbstractDynamoDbHandler.java b/serverless/src/main/java/com/iluwatar/serverless/baas/api/AbstractDynamoDbHandler.java index eff21f879..43465f529 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/baas/api/AbstractDynamoDbHandler.java +++ b/serverless/src/main/java/com/iluwatar/serverless/baas/api/AbstractDynamoDbHandler.java @@ -30,13 +30,13 @@ import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBMapper; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyResponseEvent; import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; - import java.io.Serializable; import java.util.HashMap; import java.util.Map; /** - * abstract dynamodb handler + * abstract dynamodb handler. + * * @param - serializable collection */ public abstract class AbstractDynamoDbHandler { @@ -78,10 +78,10 @@ public abstract class AbstractDynamoDbHandler { } /** - * API Gateway response + * API Gateway response. * * @param statusCode - status code - * @param body - Object body + * @param body - Object body * @return - api gateway proxy response */ protected APIGatewayProxyResponseEvent apiGatewayProxyResponseEvent(Integer statusCode, T body) { diff --git a/serverless/src/main/java/com/iluwatar/serverless/baas/api/FindPersonApiHandler.java b/serverless/src/main/java/com/iluwatar/serverless/baas/api/FindPersonApiHandler.java index 3e0bde023..11066c744 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/baas/api/FindPersonApiHandler.java +++ b/serverless/src/main/java/com/iluwatar/serverless/baas/api/FindPersonApiHandler.java @@ -28,14 +28,12 @@ import com.amazonaws.services.lambda.runtime.RequestHandler; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyResponseEvent; import com.iluwatar.serverless.baas.model.Person; +import java.util.Map; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.Map; - /** - * find person from persons collection - * Created by dheeraj.mummar on 3/5/18. + * find person from persons collection Created by dheeraj.mummar on 3/5/18. */ public class FindPersonApiHandler extends AbstractDynamoDbHandler implements RequestHandler { @@ -44,10 +42,11 @@ public class FindPersonApiHandler extends AbstractDynamoDbHandler private static final Integer SUCCESS_STATUS_CODE = 200; @Override - public APIGatewayProxyResponseEvent handleRequest(APIGatewayProxyRequestEvent apiGatewayProxyRequestEvent, - Context context) { + public APIGatewayProxyResponseEvent handleRequest( + APIGatewayProxyRequestEvent apiGatewayProxyRequestEvent, Context context) { Map pathParameters = apiGatewayProxyRequestEvent.getPathParameters(); - pathParameters.keySet().stream().map(key -> key + "=" + pathParameters.get(key)).forEach(LOG::info); + pathParameters.keySet().stream().map(key -> key + "=" + pathParameters.get(key)) + .forEach(LOG::info); Person person = this.getDynamoDbMapper().load(Person.class, apiGatewayProxyRequestEvent .getPathParameters().get("id")); diff --git a/serverless/src/main/java/com/iluwatar/serverless/baas/api/SavePersonApiHandler.java b/serverless/src/main/java/com/iluwatar/serverless/baas/api/SavePersonApiHandler.java index 502f12258..0bc121853 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/baas/api/SavePersonApiHandler.java +++ b/serverless/src/main/java/com/iluwatar/serverless/baas/api/SavePersonApiHandler.java @@ -28,14 +28,12 @@ import com.amazonaws.services.lambda.runtime.RequestHandler; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyResponseEvent; import com.iluwatar.serverless.baas.model.Person; +import java.io.IOException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io.IOException; - /** - * save person into persons collection - * Created by dheeraj.mummar on 3/4/18. + * save person into persons collection Created by dheeraj.mummar on 3/4/18. */ public class SavePersonApiHandler extends AbstractDynamoDbHandler implements RequestHandler { @@ -45,8 +43,8 @@ public class SavePersonApiHandler extends AbstractDynamoDbHandler private static final Integer BAD_REQUEST_STATUS_CODE = 400; @Override - public APIGatewayProxyResponseEvent handleRequest(APIGatewayProxyRequestEvent - apiGatewayProxyRequestEvent, Context context) { + public APIGatewayProxyResponseEvent handleRequest( + APIGatewayProxyRequestEvent apiGatewayProxyRequestEvent, Context context) { APIGatewayProxyResponseEvent apiGatewayProxyResponseEvent; Person person; try { diff --git a/serverless/src/main/java/com/iluwatar/serverless/baas/model/Address.java b/serverless/src/main/java/com/iluwatar/serverless/baas/model/Address.java index c2e8fdac6..710cde531 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/baas/model/Address.java +++ b/serverless/src/main/java/com/iluwatar/serverless/baas/model/Address.java @@ -25,12 +25,10 @@ package com.iluwatar.serverless.baas.model; import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBAttribute; import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBDocument; - import java.io.Serializable; /** - * Address class - * Created by dheeraj.mummarareddy on 3/4/18. + * Address class Created by dheeraj.mummarareddy on 3/4/18. */ @DynamoDBDocument public class Address implements Serializable { diff --git a/serverless/src/main/java/com/iluwatar/serverless/baas/model/Person.java b/serverless/src/main/java/com/iluwatar/serverless/baas/model/Person.java index cf8a30d3f..3c97aae11 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/baas/model/Person.java +++ b/serverless/src/main/java/com/iluwatar/serverless/baas/model/Person.java @@ -28,12 +28,10 @@ import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBAutoGeneratedKey; import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBHashKey; import com.amazonaws.services.dynamodbv2.datamodeling.DynamoDBTable; import com.fasterxml.jackson.annotation.JsonProperty; - import java.io.Serializable; /** - * Person class - * Created by dheeraj.mummarareddy on 3/4/18. + * Person class Created by dheeraj.mummarareddy on 3/4/18. */ @DynamoDBTable(tableName = "persons") public class Person implements Serializable { diff --git a/serverless/src/main/java/com/iluwatar/serverless/faas/ApiGatewayResponse.java b/serverless/src/main/java/com/iluwatar/serverless/faas/ApiGatewayResponse.java index 8de042161..94fe7b4f9 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/faas/ApiGatewayResponse.java +++ b/serverless/src/main/java/com/iluwatar/serverless/faas/ApiGatewayResponse.java @@ -25,12 +25,11 @@ package com.iluwatar.serverless.faas; import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; - import java.io.Serializable; import java.util.Map; /** - * Api gateway response + * Api gateway response. * * @param serializable object */ @@ -44,11 +43,11 @@ public class ApiGatewayResponse implements Serializable private final Boolean isBase64Encoded; /** - * api gateway response + * api gateway response. * - * @param statusCode - http status code - * @param body - response body - * @param headers - response headers + * @param statusCode - http status code + * @param body - response body + * @param headers - response headers * @param isBase64Encoded - base64Encoded flag */ public ApiGatewayResponse(Integer statusCode, String body, Map headers, @@ -60,7 +59,7 @@ public class ApiGatewayResponse implements Serializable } /** - * http status code + * http status code. * * @return statusCode - http status code */ @@ -69,7 +68,7 @@ public class ApiGatewayResponse implements Serializable } /** - * response body + * response body. * * @return string body */ @@ -78,7 +77,7 @@ public class ApiGatewayResponse implements Serializable } /** - * response headers + * response headers. * * @return response headers */ @@ -87,7 +86,7 @@ public class ApiGatewayResponse implements Serializable } /** - * base64Encoded flag, API Gateway expects the property to be called "isBase64Encoded" + * base64Encoded flag, API Gateway expects the property to be called "isBase64Encoded". * * @return base64Encoded flag */ @@ -96,7 +95,8 @@ public class ApiGatewayResponse implements Serializable } /** - * ApiGatewayResponse Builder class + * ApiGatewayResponse Builder class. + * * @param Serializable object */ public static class ApiGatewayResponseBuilder { @@ -107,7 +107,8 @@ public class ApiGatewayResponse implements Serializable private Boolean isBase64Encoded; /** - * http status code + * http status code. + * * @param statusCode - http status code * @return ApiGatewayResponseBuilder */ @@ -117,7 +118,8 @@ public class ApiGatewayResponse implements Serializable } /** - * Serializable body + * Serializable body. + * * @param body - Serializable object * @return ApiGatewayResponseBuilder */ @@ -127,7 +129,8 @@ public class ApiGatewayResponse implements Serializable } /** - * response headers + * response headers. + * * @param headers - response headers * @return ApiGatewayResponseBuilder */ @@ -137,7 +140,8 @@ public class ApiGatewayResponse implements Serializable } /** - * base64Encoded glag + * base64Encoded flag. + * * @param isBase64Encoded - base64Encoded flag * @return ApiGatewayResponseBuilder */ @@ -147,7 +151,7 @@ public class ApiGatewayResponse implements Serializable } /** - * build ApiGatewayResponse + * build ApiGatewayResponse. * * @return ApiGatewayResponse */ diff --git a/serverless/src/main/java/com/iluwatar/serverless/faas/LambdaInfo.java b/serverless/src/main/java/com/iluwatar/serverless/faas/LambdaInfo.java index 8fec38457..7cb93ebf4 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/faas/LambdaInfo.java +++ b/serverless/src/main/java/com/iluwatar/serverless/faas/LambdaInfo.java @@ -26,7 +26,7 @@ package com.iluwatar.serverless.faas; import java.io.Serializable; /** - * Lambda context information + * Lambda context information. */ public class LambdaInfo implements Serializable { @@ -110,22 +110,28 @@ public class LambdaInfo implements Serializable { LambdaInfo that = (LambdaInfo) o; - if (awsRequestId != null ? !awsRequestId.equals(that.awsRequestId) : that.awsRequestId != null) { + if (awsRequestId != null ? !awsRequestId + .equals(that.awsRequestId) : that.awsRequestId != null) { return false; } - if (logGroupName != null ? !logGroupName.equals(that.logGroupName) : that.logGroupName != null) { + if (logGroupName != null ? !logGroupName + .equals(that.logGroupName) : that.logGroupName != null) { return false; } - if (logStreamName != null ? !logStreamName.equals(that.logStreamName) : that.logStreamName != null) { + if (logStreamName != null ? !logStreamName + .equals(that.logStreamName) : that.logStreamName != null) { return false; } - if (functionName != null ? !functionName.equals(that.functionName) : that.functionName != null) { + if (functionName != null ? !functionName + .equals(that.functionName) : that.functionName != null) { return false; } - if (functionVersion != null ? !functionVersion.equals(that.functionVersion) : that.functionVersion != null) { + if (functionVersion != null ? !functionVersion + .equals(that.functionVersion) : that.functionVersion != null) { return false; } - return memoryLimitInMb != null ? memoryLimitInMb.equals(that.memoryLimitInMb) : that.memoryLimitInMb == null; + return memoryLimitInMb != null ? memoryLimitInMb + .equals(that.memoryLimitInMb) : that.memoryLimitInMb == null; } @Override diff --git a/serverless/src/main/java/com/iluwatar/serverless/faas/api/LambdaInfoApiHandler.java b/serverless/src/main/java/com/iluwatar/serverless/faas/api/LambdaInfoApiHandler.java index 62b73ee57..a16358a54 100644 --- a/serverless/src/main/java/com/iluwatar/serverless/faas/api/LambdaInfoApiHandler.java +++ b/serverless/src/main/java/com/iluwatar/serverless/faas/api/LambdaInfoApiHandler.java @@ -23,22 +23,20 @@ package com.iluwatar.serverless.faas.api; -import com.iluwatar.serverless.faas.ApiGatewayResponse; - import com.amazonaws.services.lambda.runtime.Context; import com.amazonaws.services.lambda.runtime.RequestHandler; +import com.iluwatar.serverless.faas.ApiGatewayResponse; import com.iluwatar.serverless.faas.LambdaInfo; +import java.util.HashMap; +import java.util.Map; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.util.HashMap; -import java.util.Map; - /** - * LambdaInfoApiHandler - simple api to get lambda context - * Created by dheeraj.mummar on 2/5/18. + * LambdaInfoApiHandler - simple api to get lambda context Created by dheeraj.mummar on 2/5/18. */ -public class LambdaInfoApiHandler implements RequestHandler, ApiGatewayResponse> { +public class LambdaInfoApiHandler + implements RequestHandler, ApiGatewayResponse> { private static final Logger LOG = LoggerFactory.getLogger(LambdaInfoApiHandler.class); private static final Integer SUCCESS_STATUS_CODE = 200; @@ -49,16 +47,17 @@ public class LambdaInfoApiHandler implements RequestHandler, LOG.info("received: " + input); return new ApiGatewayResponse - .ApiGatewayResponseBuilder() - .headers(headers()) - .statusCode(SUCCESS_STATUS_CODE) - .body(lambdaInfo(context)) - .build(); + .ApiGatewayResponseBuilder() + .headers(headers()) + .statusCode(SUCCESS_STATUS_CODE) + .body(lambdaInfo(context)) + .build(); } /** - * lambdaInfo + * lambdaInfo. + * * @param context - Lambda context * @return LambdaInfo */ diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/app/App.java b/service-layer/src/main/java/com/iluwatar/servicelayer/app/App.java index 0e87e987b..22e170085 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/app/App.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/app/App.java @@ -23,19 +23,15 @@ package com.iluwatar.servicelayer.app; -import java.util.List; - import com.iluwatar.servicelayer.magic.MagicService; import com.iluwatar.servicelayer.magic.MagicServiceImpl; import com.iluwatar.servicelayer.spell.Spell; -import com.iluwatar.servicelayer.spell.SpellDao; import com.iluwatar.servicelayer.spell.SpellDaoImpl; import com.iluwatar.servicelayer.spellbook.Spellbook; -import com.iluwatar.servicelayer.spellbook.SpellbookDao; import com.iluwatar.servicelayer.spellbook.SpellbookDaoImpl; import com.iluwatar.servicelayer.wizard.Wizard; -import com.iluwatar.servicelayer.wizard.WizardDao; import com.iluwatar.servicelayer.wizard.WizardDaoImpl; +import java.util.List; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -43,28 +39,27 @@ import org.slf4j.LoggerFactory; /** * Service layer defines an application's boundary with a layer of services that establishes a set * of available operations and coordinates the application's response in each operation. - *

- * Enterprise applications typically require different kinds of interfaces to the data they store - * and the logic they implement: data loaders, user interfaces, integration gateways, and others. - * Despite their different purposes, these interfaces often need common interactions with the - * application to access and manipulate its data and invoke its business logic. The interactions may - * be complex, involving transactions across multiple resources and the coordination of several + * + *

Enterprise applications typically require different kinds of interfaces to the data they + * store and the logic they implement: data loaders, user interfaces, integration gateways, and + * others. Despite their different purposes, these interfaces often need common interactions with + * the application to access and manipulate its data and invoke its business logic. The interactions + * may be complex, involving transactions across multiple resources and the coordination of several * responses to an action. Encoding the logic of the interactions separately in each interface * causes a lot of duplication. - *

- * The example application demonstrates interactions between a client ({@link App}) and a service ( - * {@link MagicService}). The service is implemented with 3-layer architecture (entity, dao, - * service). For persistence the example uses in-memory H2 database which is populated on each - * application startup. * + *

The example application demonstrates interactions between a client ({@link App}) and a + * service ({@link MagicService}). The service is implemented with 3-layer architecture (entity, + * dao, service). For persistence the example uses in-memory H2 database which is populated on each + * application startup. */ public class App { private static final Logger LOGGER = LoggerFactory.getLogger(App.class); /** - * Program entry point - * + * Program entry point. + * * @param args command line args */ public static void main(String[] args) { @@ -75,7 +70,7 @@ public class App { } /** - * Initialize data + * Initialize data. */ public static void initData() { // spells @@ -180,7 +175,7 @@ public class App { } /** - * Query the data + * Query the data. */ public static void queryData() { var service = diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/common/BaseEntity.java b/service-layer/src/main/java/com/iluwatar/servicelayer/common/BaseEntity.java index d58ffd2c9..ca76e5218 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/common/BaseEntity.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/common/BaseEntity.java @@ -28,37 +28,35 @@ import javax.persistence.InheritanceType; import javax.persistence.MappedSuperclass; /** - * * Base class for entities. - * */ @MappedSuperclass @Inheritance(strategy = InheritanceType.TABLE_PER_CLASS) public abstract class BaseEntity { /** - * Indicates the unique id of this entity + * Indicates the unique id of this entity. * * @return The id of the entity, or 'null' when not persisted */ public abstract Long getId(); /** - * Set the id of this entity + * Set the id of this entity. * * @param id The new id */ public abstract void setId(Long id); /** - * Get the name of this entity + * Get the name of this entity. * * @return The name of the entity */ public abstract String getName(); /** - * Set the name of this entity + * Set the name of this entity. * * @param name The new name */ diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/common/Dao.java b/service-layer/src/main/java/com/iluwatar/servicelayer/common/Dao.java index 1fb41d0c8..aefcacafb 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/common/Dao.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/common/Dao.java @@ -26,11 +26,9 @@ package com.iluwatar.servicelayer.common; import java.util.List; /** - * * Dao interface. * - * @param - * + * @param Type of Entity */ public interface Dao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/common/DaoBaseImpl.java b/service-layer/src/main/java/com/iluwatar/servicelayer/common/DaoBaseImpl.java index 8d93002e6..3c2ae6ed9 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/common/DaoBaseImpl.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/common/DaoBaseImpl.java @@ -23,23 +23,18 @@ package com.iluwatar.servicelayer.common; +import com.iluwatar.servicelayer.hibernate.HibernateUtil; import java.lang.reflect.ParameterizedType; import java.util.List; - import org.hibernate.Criteria; -import org.hibernate.Session; import org.hibernate.SessionFactory; import org.hibernate.Transaction; import org.hibernate.criterion.Restrictions; -import com.iluwatar.servicelayer.hibernate.HibernateUtil; - /** - * * Base class for Dao implementations. * - * @param - * + * @param Type of Entity */ public abstract class DaoBaseImpl implements Dao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java b/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java index 673918711..44c4c12a2 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/hibernate/HibernateUtil.java @@ -26,7 +26,6 @@ package com.iluwatar.servicelayer.hibernate; import com.iluwatar.servicelayer.spell.Spell; import com.iluwatar.servicelayer.spellbook.Spellbook; import com.iluwatar.servicelayer.wizard.Wizard; - import org.hibernate.SessionFactory; import org.hibernate.cfg.Configuration; import org.slf4j.Logger; @@ -40,7 +39,7 @@ public final class HibernateUtil { private static final Logger LOGGER = LoggerFactory.getLogger(HibernateUtil.class); /** - * The cached session factory + * The cached session factory. */ private static volatile SessionFactory sessionFactory; diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicService.java b/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicService.java index f0780b338..ce4f01700 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicService.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicService.java @@ -23,17 +23,14 @@ package com.iluwatar.servicelayer.magic; -import java.util.List; - import com.iluwatar.servicelayer.spell.Spell; import com.iluwatar.servicelayer.spellbook.Spellbook; import com.iluwatar.servicelayer.wizard.Wizard; +import java.util.List; /** - * * Service interface. - * */ public interface MagicService { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicServiceImpl.java b/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicServiceImpl.java index cf8d35207..962487bd9 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicServiceImpl.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/magic/MagicServiceImpl.java @@ -23,20 +23,17 @@ package com.iluwatar.servicelayer.magic; -import java.util.ArrayList; -import java.util.List; - import com.iluwatar.servicelayer.spell.Spell; import com.iluwatar.servicelayer.spell.SpellDao; import com.iluwatar.servicelayer.spellbook.Spellbook; import com.iluwatar.servicelayer.spellbook.SpellbookDao; import com.iluwatar.servicelayer.wizard.Wizard; import com.iluwatar.servicelayer.wizard.WizardDao; +import java.util.ArrayList; +import java.util.List; /** - * * Service implementation. - * */ public class MagicServiceImpl implements MagicService { @@ -45,7 +42,7 @@ public class MagicServiceImpl implements MagicService { private SpellDao spellDao; /** - * Constructor + * Constructor. */ public MagicServiceImpl(WizardDao wizardDao, SpellbookDao spellbookDao, SpellDao spellDao) { this.wizardDao = wizardDao; diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/Spell.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/Spell.java index cc456c124..9528c6ff9 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/Spell.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/Spell.java @@ -23,6 +23,8 @@ package com.iluwatar.servicelayer.spell; +import com.iluwatar.servicelayer.common.BaseEntity; +import com.iluwatar.servicelayer.spellbook.Spellbook; import javax.persistence.Column; import javax.persistence.Entity; import javax.persistence.GeneratedValue; @@ -31,13 +33,8 @@ import javax.persistence.JoinColumn; import javax.persistence.ManyToOne; import javax.persistence.Table; -import com.iluwatar.servicelayer.common.BaseEntity; -import com.iluwatar.servicelayer.spellbook.Spellbook; - /** - * * Spell entity. - * */ @Entity @Table(name = "SPELL") @@ -54,13 +51,14 @@ public class Spell extends BaseEntity { @JoinColumn(name = "SPELLBOOK_ID_FK", referencedColumnName = "SPELLBOOK_ID") private Spellbook spellbook; - public Spell() {} + public Spell() { + } public Spell(String name) { this(); this.name = name; } - + public Long getId() { return id; } @@ -68,7 +66,7 @@ public class Spell extends BaseEntity { public void setId(Long id) { this.id = id; } - + public String getName() { return name; } diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDao.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDao.java index cb7989176..616379717 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDao.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDao.java @@ -26,9 +26,7 @@ package com.iluwatar.servicelayer.spell; import com.iluwatar.servicelayer.common.Dao; /** - * * SpellDao interface. - * */ public interface SpellDao extends Dao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDaoImpl.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDaoImpl.java index 7a68d372b..06e898a88 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDaoImpl.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spell/SpellDaoImpl.java @@ -24,16 +24,11 @@ package com.iluwatar.servicelayer.spell; import com.iluwatar.servicelayer.common.DaoBaseImpl; - -import org.hibernate.Criteria; -import org.hibernate.Session; import org.hibernate.Transaction; import org.hibernate.criterion.Restrictions; /** - * * SpellDao implementation. - * */ public class SpellDaoImpl extends DaoBaseImpl implements SpellDao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/Spellbook.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/Spellbook.java index 481fa20db..b781499b9 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/Spellbook.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/Spellbook.java @@ -23,9 +23,11 @@ package com.iluwatar.servicelayer.spellbook; +import com.iluwatar.servicelayer.common.BaseEntity; +import com.iluwatar.servicelayer.spell.Spell; +import com.iluwatar.servicelayer.wizard.Wizard; import java.util.HashSet; import java.util.Set; - import javax.persistence.CascadeType; import javax.persistence.Column; import javax.persistence.Entity; @@ -36,14 +38,8 @@ import javax.persistence.ManyToMany; import javax.persistence.OneToMany; import javax.persistence.Table; -import com.iluwatar.servicelayer.common.BaseEntity; -import com.iluwatar.servicelayer.spell.Spell; -import com.iluwatar.servicelayer.wizard.Wizard; - /** - * * Spellbook entity. - * */ @Entity @Table(name = "SPELLBOOK") @@ -71,7 +67,7 @@ public class Spellbook extends BaseEntity { this(); this.name = name; } - + public Long getId() { return id; } @@ -79,7 +75,7 @@ public class Spellbook extends BaseEntity { public void setId(Long id) { this.id = id; } - + public String getName() { return name; } diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDao.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDao.java index 11cb66789..6ff95b183 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDao.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDao.java @@ -26,9 +26,7 @@ package com.iluwatar.servicelayer.spellbook; import com.iluwatar.servicelayer.common.Dao; /** - * * SpellbookDao interface. - * */ public interface SpellbookDao extends Dao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDaoImpl.java b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDaoImpl.java index 473cfaabd..dcacd2786 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDaoImpl.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/spellbook/SpellbookDaoImpl.java @@ -23,17 +23,12 @@ package com.iluwatar.servicelayer.spellbook; -import org.hibernate.Criteria; -import org.hibernate.Session; +import com.iluwatar.servicelayer.common.DaoBaseImpl; import org.hibernate.Transaction; import org.hibernate.criterion.Restrictions; -import com.iluwatar.servicelayer.common.DaoBaseImpl; - /** - * * SpellbookDao implementation. - * */ public class SpellbookDaoImpl extends DaoBaseImpl implements SpellbookDao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/Wizard.java b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/Wizard.java index 05e65faf3..c973d433a 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/Wizard.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/Wizard.java @@ -23,9 +23,10 @@ package com.iluwatar.servicelayer.wizard; +import com.iluwatar.servicelayer.common.BaseEntity; +import com.iluwatar.servicelayer.spellbook.Spellbook; import java.util.HashSet; import java.util.Set; - import javax.persistence.CascadeType; import javax.persistence.Column; import javax.persistence.Entity; @@ -34,13 +35,8 @@ import javax.persistence.Id; import javax.persistence.ManyToMany; import javax.persistence.Table; -import com.iluwatar.servicelayer.common.BaseEntity; -import com.iluwatar.servicelayer.spellbook.Spellbook; - /** - * * Wizard entity. - * */ @Entity @Table(name = "WIZARD") @@ -64,7 +60,7 @@ public class Wizard extends BaseEntity { this(); this.name = name; } - + public Long getId() { return id; } @@ -72,7 +68,7 @@ public class Wizard extends BaseEntity { public void setId(Long id) { this.id = id; } - + public String getName() { return name; } diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDao.java b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDao.java index 945509dc5..6f966e8ea 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDao.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDao.java @@ -26,9 +26,7 @@ package com.iluwatar.servicelayer.wizard; import com.iluwatar.servicelayer.common.Dao; /** - * * WizardDao interface. - * */ public interface WizardDao extends Dao { diff --git a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDaoImpl.java b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDaoImpl.java index e16f150d0..ee2f2a038 100644 --- a/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDaoImpl.java +++ b/service-layer/src/main/java/com/iluwatar/servicelayer/wizard/WizardDaoImpl.java @@ -23,18 +23,15 @@ package com.iluwatar.servicelayer.wizard; +import com.iluwatar.servicelayer.common.DaoBaseImpl; +import com.iluwatar.servicelayer.spellbook.Spellbook; import org.hibernate.Criteria; import org.hibernate.Session; import org.hibernate.Transaction; import org.hibernate.criterion.Restrictions; -import com.iluwatar.servicelayer.common.DaoBaseImpl; -import com.iluwatar.servicelayer.spellbook.Spellbook; - /** - * * WizardDao implementation. - * */ public class WizardDaoImpl extends DaoBaseImpl implements WizardDao { diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/App.java b/service-locator/src/main/java/com/iluwatar/servicelocator/App.java index 49d871ca9..efc25bd89 100644 --- a/service-locator/src/main/java/com/iluwatar/servicelocator/App.java +++ b/service-locator/src/main/java/com/iluwatar/servicelocator/App.java @@ -24,24 +24,22 @@ package com.iluwatar.servicelocator; /** - * * The Service Locator pattern is a design pattern used in software development to encapsulate the * processes involved in obtaining a service with a strong abstraction layer. This pattern uses a * central registry known as the "service locator", which on request returns the information * necessary to perform a certain task. - *

- * In this example we use the Service locator pattern to lookup JNDI-services and cache them for + * + *

In this example we use the Service locator pattern to lookup JNDI-services and cache them for * subsequent requests. - *

- * + *
+ * * @author saifasif - * */ public class App { /** - * Program entry point - * + * Program entry point. + * * @param args command line args */ public static void main(String[] args) { diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/Service.java b/service-locator/src/main/java/com/iluwatar/servicelocator/Service.java index 805b3e92c..2635afe4f 100644 --- a/service-locator/src/main/java/com/iluwatar/servicelocator/Service.java +++ b/service-locator/src/main/java/com/iluwatar/servicelocator/Service.java @@ -25,10 +25,10 @@ package com.iluwatar.servicelocator; /** * This is going to be the parent service interface which we will use to create our services. All - * services will have a

- * - * @author saifasif + * services will have a * + * @author saifasif */ public interface Service { diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceCache.java b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceCache.java index e32585b6b..2f3bc9c15 100644 --- a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceCache.java +++ b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceCache.java @@ -23,11 +23,10 @@ package com.iluwatar.servicelocator; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - import java.util.HashMap; import java.util.Map; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; /** * The service cache implementation which will cache services that are being created. On first hit, @@ -59,14 +58,14 @@ public class ServiceCache { if (serviceJndiName.equals(serviceName)) { cachedService = serviceCache.get(serviceJndiName); LOGGER.info("(cache call) Fetched service {}({}) from cache... !", - cachedService.getName(), cachedService.getId()); + cachedService.getName(), cachedService.getId()); } } return cachedService; } /** - * Adds the service into the cache map + * Adds the service into the cache map. * * @param newService a {@link Service} */ diff --git a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceImpl.java b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceImpl.java index b2440c838..62e77af00 100644 --- a/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceImpl.java +++ b/service-locator/src/main/java/com/iluwatar/servicelocator/ServiceImpl.java @@ -41,7 +41,7 @@ public class ServiceImpl implements Service { private final int id; /** - * Constructor + * Constructor. */ public ServiceImpl(String serviceName) { // set the service name