gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sonar bug fix & test cases

Browse Source
This commit is contained in:
atayal
2021-11-12 07:43:54 +05:30
parent 1eb13a8d4e
commit 3a6a20c5db
2 changed files with 33 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
commander/src/main/java/com/iluwatar/commander/Commander.java
View File

@ -250,7 +250,7 @@ public class Commander {
|| qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL) || qt.order.messageSent.equals(MessageSent.PAYMENT_FAIL)
|| qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL)) || qt.order.messageSent.equals(MessageSent.PAYMENT_SUCCESSFUL))
|| qt.taskType.equals(TaskType.EMPLOYEE_DB) && qt.order.addedToEmployeeHandle) { || qt.taskType.equals(TaskType.EMPLOYEE_DB) && qt.order.addedToEmployeeHandle) {
LOG.trace(ORDER_ID + ": Not queueing task since task already done..", qt.order.id); LOG.trace("Order " + qt.order.id + ": Not queueing task since task already done..");
return; return;
} }
var list = queue.exceptionsList; var list = queue.exceptionsList;
@ -420,8 +420,8 @@ public class Commander {
&& System.currentTimeMillis() - o.createdTime < messageTime) { && System.currentTimeMillis() - o.createdTime < messageTime) {
var qt = new QueueTask(order, TaskType.MESSAGING, 0); var qt = new QueueTask(order, TaskType.MESSAGING, 0);
updateQueue(qt); updateQueue(qt);
LOG.warn(ORDER_ID + ": Error in sending Payment Failure message, " LOG.warn("Order " + order.id + ": Error in sending Payment Failure message, "
+ "trying to queue task and add to employee handle..", order.id); + "trying to queue task and add to employee handle..");
employeeHandleIssue(o); employeeHandleIssue(o);
} }
} }

30
commander/src/test/java/com/iluwatar/commander/CommanderTest.java
View File

@ -79,6 +79,28 @@ class CommanderTest {
queueTime, queueTaskTime, paymentTime, messageTime, employeeTime); queueTime, queueTaskTime, paymentTime, messageTime, employeeTime);
} }
private Commander buildCommanderObjectVanilla() {
PaymentService paymentService = new PaymentService
(new PaymentDatabase(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException());
var shippingService = new ShippingService(new ShippingDatabase());
var messagingService = new MessagingService(new MessagingDatabase());
var employeeHandle = new EmployeeHandle
(new EmployeeDatabase(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException());
var qdb = new QueueDatabase
(new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException(),
new DatabaseUnavailableException(), new DatabaseUnavailableException());
return new Commander(employeeHandle, paymentService, shippingService,
messagingService, qdb, numOfRetries, retryDuration,
queueTime, queueTaskTime, paymentTime, messageTime, employeeTime);
}
private Commander buildCommanderObjectUnknownException() { private Commander buildCommanderObjectUnknownException() {
PaymentService paymentService = new PaymentService PaymentService paymentService = new PaymentService
(new PaymentDatabase(), new IllegalStateException()); (new PaymentDatabase(), new IllegalStateException());
@ -207,6 +229,14 @@ class CommanderTest {
} }
} }
@Test
void testPlaceOrderVanilla() throws Exception {
Commander c = buildCommanderObjectVanilla();
var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
@Test @Test
void testPlaceOrder() throws Exception { void testPlaceOrder() throws Exception {
Commander c = buildCommanderObject(true); Commander c = buildCommanderObject(true);