Merge pull request #548 from muditporwal/master

Checkstyle improvements #539 : Added JavaDocType Rule

observer/src/main/java/com/iluwatar/observer/generic/Observer.java

@@ -23,8 +23,10 @@
 package com.iluwatar.observer.generic;
 
 /**
- * 
  * Observer
+ * @param <S> Observable
+ * @param <O> Observer
+ * @param <A> Action
  */
 public interface Observer<S extends Observable<S, O, A>, O extends Observer<S, O, A>, A> {
 

observer/src/test/java/com/iluwatar/observer/WeatherObserverTest.java

@@ -22,18 +22,18 @@
  */
 package com.iluwatar.observer;
 
+import static org.junit.Assert.assertEquals;
+
 import com.iluwatar.observer.utils.InMemoryAppender;
+import java.util.function.Supplier;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.function.Supplier;
-
-import static org.junit.Assert.assertEquals;
-
 /**
  * Date: 12/27/15 - 11:44 AM
- *
+ * Weather Observer Tests
+ * @param <O> Type of WeatherObserver
  * @author Jeroen Meulemeester
  */
 public abstract class WeatherObserverTest<O extends WeatherObserver> {

observer/src/test/java/com/iluwatar/observer/generic/ObserverTest.java

@@ -22,19 +22,19 @@
  */
 package com.iluwatar.observer.generic;
 
+import static org.junit.Assert.assertEquals;
+
 import com.iluwatar.observer.WeatherType;
 import com.iluwatar.observer.utils.InMemoryAppender;
+import java.util.function.Supplier;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
-import java.util.function.Supplier;
-
-import static org.junit.Assert.assertEquals;
-
 /**
  * Date: 12/27/15 - 11:44 AM
- *
+ * Test for Observers
+ * @param <O> Type of Observer
  * @author Jeroen Meulemeester
  */
 public abstract class ObserverTest<O extends Observer> {

observer/src/test/java/com/iluwatar/observer/utils/InMemoryAppender.java

@@ -30,6 +30,9 @@ import org.slf4j.LoggerFactory;
 import java.util.LinkedList;
 import java.util.List;
 
+/**
+ * InMemory Log Appender Util.
+ */
 public class InMemoryAppender extends AppenderBase<ILoggingEvent> {
   private List<ILoggingEvent> log = new LinkedList<>();