gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Code cleanup (#1461)

Browse Source 
* Code cleanup

* Fix flux tests

* Fix checkstyle errors

* Fix compile error
This commit is contained in:
Ilkka Seppälä
2020-07-30 20:28:47 +03:00
committed by GitHub
parent 5381387026
commit 417f21ed3d
243 changed files with 1154 additions and 1162 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
layers/README.md
View File

@ -79,7 +79,7 @@ public class CakeViewImpl implements View {
private static final Logger LOGGER = LoggerFactory.getLogger(CakeViewImpl.class);
private CakeBakingService cakeBakingService;
private final CakeBakingService cakeBakingService;
public CakeViewImpl(CakeBakingService cakeBakingService) {
this.cakeBakingService = cakeBakingService;

2
layers/src/main/java/com/iluwatar/layers/app/App.java
View File

@ -80,7 +80,7 @@ import java.util.List;
*/
public class App {
private static CakeBakingService cakeBakingService = new CakeBakingServiceImpl();
private static final CakeBakingService cakeBakingService = new CakeBakingServiceImpl();
/**
* Application entry point.

2
layers/src/main/java/com/iluwatar/layers/service/CakeBakingServiceImpl.java
View File

@ -52,7 +52,7 @@ import org.springframework.transaction.annotation.Transactional;
@Transactional
public class CakeBakingServiceImpl implements CakeBakingService {
private AbstractApplicationContext context;
private final AbstractApplicationContext context;
public CakeBakingServiceImpl() {
this.context = new ClassPathXmlApplicationContext("applicationContext.xml");

2
layers/src/main/java/com/iluwatar/layers/view/CakeViewImpl.java
View File

@ -34,7 +34,7 @@ public class CakeViewImpl implements View {
private static final Logger LOGGER = LoggerFactory.getLogger(CakeViewImpl.class);
private CakeBakingService cakeBakingService;
private final CakeBakingService cakeBakingService;
public CakeViewImpl(CakeBakingService cakeBakingService) {
this.cakeBakingService = cakeBakingService;

2
layers/src/test/java/com/iluwatar/layers/view/CakeViewImplTest.java
View File

@ -90,7 +90,7 @@ public class CakeViewImplTest {
private class InMemoryAppender extends AppenderBase<ILoggingEvent> {
private List<ILoggingEvent> log = new LinkedList<>();
private final List<ILoggingEvent> log = new LinkedList<>();
public InMemoryAppender(Class clazz) {
((Logger) LoggerFactory.getLogger(clazz)).addAppender(this);