sonar bug fix & test cases

This commit is contained in:
atayal
2021-11-12 10:41:28 +05:30
parent 9d0d5e38ee
commit 44338f32b4

View File

@ -27,11 +27,11 @@ class CommanderTest {
private final int numOfRetries = 1; private final int numOfRetries = 1;
private final long retryDuration = 1_000; private final long retryDuration = 1_000;
private final long queueTime = 1_00; private long queueTime = 1_00;
private long queueTaskTime = 1_000; private long queueTaskTime = 1_000;
private long paymentTime = 6_000; private long paymentTime = 6_000;
private final long messageTime = 5_000; private long messageTime = 5_000;
private final long employeeTime = 2_000; private long employeeTime = 2_000;
private static List<Exception> exceptionList = new ArrayList<>(); private static List<Exception> exceptionList = new ArrayList<>();
@ -255,22 +255,18 @@ class CommanderTest {
@Test @Test
void testPlaceOrderNoException1() throws Exception { void testPlaceOrderNoException1() throws Exception {
Commander c = buildCommanderObjectNoPaymentException1(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
c.placeOrder(order); queueTaskTime *= d;
assertFalse(StringUtils.isBlank(order.id)); Commander c = buildCommanderObjectNoPaymentException1();
var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderNoException2() throws Exception { void testPlaceOrderNoException2() throws Exception {
Commander c = buildCommanderObjectNoPaymentException2();
var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
@Test
void testPlaceOrderNoException2a() throws Exception {
for (double d = 0.1; d < 2; d = d + 0.1) { for (double d = 0.1; d < 2; d = d + 0.1) {
paymentTime *= d; paymentTime *= d;
queueTaskTime *= d; queueTaskTime *= d;
@ -283,134 +279,205 @@ class CommanderTest {
@Test @Test
void testPlaceOrderNoException3() throws Exception { void testPlaceOrderNoException3() throws Exception {
Commander c = buildCommanderObjectNoPaymentException3(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
c.placeOrder(order); queueTaskTime *= d;
assertFalse(StringUtils.isBlank(order.id)); Commander c = buildCommanderObjectNoPaymentException3();
var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderNoException4() throws Exception { void testPlaceOrderNoException4() throws Exception {
Commander c = buildCommanderObjectNoPaymentException3(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
sleep(queueTaskTime / 10); queueTaskTime *= d;
c.placeOrder(order); Commander c = buildCommanderObjectNoPaymentException3();
c.placeOrder(order); var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order); sleep(queueTaskTime / 10);
assertFalse(StringUtils.isBlank(order.id)); c.placeOrder(order);
c.placeOrder(order);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderUnknownException() throws Exception { void testPlaceOrderUnknownException() throws Exception {
Commander c = buildCommanderObjectUnknownException(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
c.placeOrder(order); queueTaskTime *= d;
assertFalse(StringUtils.isBlank(order.id)); messageTime *= d;
employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObjectUnknownException();
var order = new Order(new User("K", "J"), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderShortDuration() throws Exception { void testPlaceOrderShortDuration() throws Exception {
Commander c = buildCommanderObject(true); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
sleep(paymentTime); queueTaskTime *= d;
c.placeOrder(order); messageTime *= d;
assertFalse(StringUtils.isBlank(order.id)); employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObject(true);
var order = new Order(new User("K", "J"), "pen", 1f);
sleep(paymentTime);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderShortDuration2() throws Exception { void testPlaceOrderShortDuration2() throws Exception {
Commander c = buildCommanderObject(false); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
sleep(paymentTime); queueTaskTime *= d;
c.placeOrder(order); messageTime *= d;
assertFalse(StringUtils.isBlank(order.id)); employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObject(false);
var order = new Order(new User("K", "J"), "pen", 1f);
sleep(paymentTime);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderNoExceptionShortMsgDuration() throws Exception { void testPlaceOrderNoExceptionShortMsgDuration() throws Exception {
Commander c = buildCommanderObjectNoPaymentException1(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
sleep(messageTime); queueTaskTime *= d;
c.placeOrder(order); messageTime *= d;
assertFalse(StringUtils.isBlank(order.id)); employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObjectNoPaymentException1();
var order = new Order(new User("K", "J"), "pen", 1f);
sleep(messageTime);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderNoExceptionShortQueueDuration() throws Exception { void testPlaceOrderNoExceptionShortQueueDuration() throws Exception {
Commander c = buildCommanderObjectUnknownException(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", "J"), "pen", 1f); paymentTime *= d;
sleep(queueTime); queueTaskTime *= d;
c.placeOrder(order); messageTime *= d;
assertFalse(StringUtils.isBlank(order.id)); employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObjectUnknownException();
var order = new Order(new User("K", "J"), "pen", 1f);
sleep(queueTime);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderWithDatabase() throws Exception { void testPlaceOrderWithDatabase() throws Exception {
Commander c = buildCommanderObjectWithDB(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", null), "pen", 1f); paymentTime *= d;
c.placeOrder(order); queueTaskTime *= d;
assertFalse(StringUtils.isBlank(order.id)); messageTime *= d;
employeeTime *= d;
queueTime *= d;
Commander c = buildCommanderObjectWithDB();
var order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
@Test @Test
void testPlaceOrderWithDatabaseAndExceptions() throws Exception { void testPlaceOrderWithDatabaseAndExceptions() throws Exception {
for (double d = 0.1; d < 2; d = d + 0.1) {
paymentTime *= d;
queueTaskTime *= d;
messageTime *= d;
employeeTime *= d;
queueTime *= d;
for (Exception e : exceptionList) { for (Exception e : exceptionList) {
Commander c = buildCommanderObjectWithDB(true, true, e); Commander c = buildCommanderObjectWithDB(true, true, e);
var order = new Order(new User("K", null), "pen", 1f); var order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithDB(true, false, e); c = buildCommanderObjectWithDB(true, false, e);
order = new Order(new User("K", null), "pen", 1f); order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithDB(false, false, e); c = buildCommanderObjectWithDB(false, false, e);
order = new Order(new User("K", null), "pen", 1f); order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithDB(false, true, e); c = buildCommanderObjectWithDB(false, true, e);
order = new Order(new User("K", null), "pen", 1f); order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); assertFalse(StringUtils.isBlank(order.id));
}
} }
} }
@Test @Test
void testPlaceOrderWithoutDatabase() throws Exception { void testPlaceOrderWithoutDatabase() throws Exception {
Commander c = buildCommanderObjectWithoutDB(); for (double d = 0.1; d < 2; d = d + 0.1) {
var order = new Order(new User("K", null), "pen", 1f); paymentTime *= d;
c.placeOrder(order); queueTaskTime *= d;
assertFalse(StringUtils.isBlank(order.id)); messageTime *= d;
} employeeTime *= d;
queueTime *= d;
@Test Commander c = buildCommanderObjectWithoutDB();
void testPlaceOrderWithoutDatabaseAndExceptions() throws Exception {
for (Exception e : exceptionList) {
Commander c = buildCommanderObjectWithoutDB(true, true, e);
var order = new Order(new User("K", null), "pen", 1f); var order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); assertFalse(StringUtils.isBlank(order.id));
}
c = buildCommanderObjectWithoutDB(true, false, e); }
order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order); @Test
assertFalse(StringUtils.isBlank(order.id)); void testPlaceOrderWithoutDatabaseAndExceptions() throws Exception {
for (double d = 0.1; d < 2; d = d + 0.1) {
c = buildCommanderObjectWithoutDB(false, false, e); paymentTime *= d;
order = new Order(new User("K", null), "pen", 1f); queueTaskTime *= d;
c.placeOrder(order); messageTime *= d;
assertFalse(StringUtils.isBlank(order.id)); employeeTime *= d;
queueTime *= d;
c = buildCommanderObjectWithoutDB(false, true, e);
order = new Order(new User("K", null), "pen", 1f); for (Exception e : exceptionList) {
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id)); Commander c = buildCommanderObjectWithoutDB(true, true, e);
var order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithoutDB(true, false, e);
order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithoutDB(false, false, e);
order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
c = buildCommanderObjectWithoutDB(false, true, e);
order = new Order(new User("K", null), "pen", 1f);
c.placeOrder(order);
assertFalse(StringUtils.isBlank(order.id));
}
} }
} }