#354 add general boolean method to services for feature status. Change user.toString

feature-toggle/src/main/java/com/iluwatar/featuretoggle/pattern/Service.java

@@ -7,4 +7,6 @@ public interface Service {
 
   String getWelcomeMessage(User user);
 
+  boolean isEnhanced();
+
 }

feature-toggle/src/main/java/com/iluwatar/featuretoggle/pattern/propertiesversion/PropertiesFeatureToggleVersion.java

@@ -7,21 +7,36 @@ import java.util.Properties;
 
 public class PropertiesFeatureToggleVersion implements Service {
 
-  private Properties properties;
+  private boolean isEnhanced;
 
+  /**
+   *
+   * @param properties {@link Properties} used to configure the service and toggle features.
+   */
   public PropertiesFeatureToggleVersion(final Properties properties) {
-    this.properties = properties;
+    if (properties == null) {
+      throw new IllegalArgumentException("No Properties Provided.");
+    } else {
+      try {
+        isEnhanced = (boolean) properties.get("enhancedWelcome");
+      } catch (Exception e) {
+        throw new IllegalArgumentException("Invalid Enhancement Settings Provided.");
+      }
+    }
   }
 
   @Override
   public String getWelcomeMessage(final User user) {
 
-    final boolean enhancedWelcome = (boolean) properties.get("enhancedWelcome");
+    if (isEnhanced()) {
-
-    if (enhancedWelcome) {
       return "Welcome " + user + ". You're using the enhanced welcome message.";
     }
 
     return "Welcome to the application.";
   }
+
+  @Override
+  public boolean isEnhanced() {
+    return isEnhanced;
+  }
 }

feature-toggle/src/main/java/com/iluwatar/featuretoggle/pattern/tieredversion/TieredFeatureToggleVersion.java

@@ -15,4 +15,9 @@ public class TieredFeatureToggleVersion implements Service {
     return "I suppose you can use this software.";
   }
 
+  @Override
+  public boolean isEnhanced() {
+    return true;
+  }
+
 }

feature-toggle/src/test/java/com/iluwatar/featuretoggle/pattern/propertiesversion/PropertiesFeatureToggleVersionTest.java

@@ -8,6 +8,8 @@ import org.junit.Test;
 import java.util.Properties;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 public class PropertiesFeatureToggleVersionTest {
 
@@ -16,6 +18,7 @@ public class PropertiesFeatureToggleVersionTest {
     final Properties properties = new Properties();
     properties.put("enhancedWelcome",true);
     Service service = new PropertiesFeatureToggleVersion(properties);
+    assertTrue(service.isEnhanced());
     final String welcomeMessage = service.getWelcomeMessage(new User("Jamie No Code"));
     assertEquals("Welcome Jamie No Code. You're using the enhanced welcome message.",welcomeMessage);
   }
@@ -25,6 +28,7 @@ public class PropertiesFeatureToggleVersionTest {
     final Properties properties = new Properties();
     properties.put("enhancedWelcome",false);
     Service service = new PropertiesFeatureToggleVersion(properties);
+    assertFalse(service.isEnhanced());
     final String welcomeMessage = service.getWelcomeMessage(new User("Jamie No Code"));
     assertEquals("Welcome to the application.",welcomeMessage);
   }

feature-toggle/src/test/java/com/iluwatar/featuretoggle/pattern/tieredversion/TieredFeatureToggleVersionTest.java

@@ -7,6 +7,7 @@ import org.junit.Before;
 import org.junit.Test;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 public class TieredFeatureToggleVersionTest {
 
@@ -33,4 +34,9 @@ public class TieredFeatureToggleVersionTest {
     final String expected = "I suppose you can use this software.";
     assertEquals(expected, welcomeMessage);
   }
+
+  @Test
+  public void testIsEnhancedAlwaysTrueAsTiered() throws Exception {
+    assertTrue(service.isEnhanced());
+  }
 }