Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

This commit is contained in:
Narendra Pathai
2018-10-20 17:50:52 +05:30
parent 2f569d670a
commit 543eb9a4be
73 changed files with 207 additions and 298 deletions

View File

@ -36,7 +36,7 @@ public class FrontController {
}
private Command getCommand(String request) {
Class commandClass = getCommandClass(request);
Class<?> commandClass = getCommandClass(request);
try {
return (Command) commandClass.newInstance();
} catch (Exception e) {
@ -44,8 +44,8 @@ public class FrontController {
}
}
private static Class getCommandClass(String request) {
Class result;
private static Class<?> getCommandClass(String request) {
Class<?> result;
try {
result = Class.forName("com.iluwatar.front.controller." + request + "Command");
} catch (ClassNotFoundException e) {

View File

@ -34,7 +34,7 @@ import static org.junit.jupiter.api.Assertions.assertSame;
public class ApplicationExceptionTest {
@Test
public void testCause() throws Exception {
public void testCause() {
final Exception cause = new Exception();
assertSame(cause, new ApplicationException(cause).getCause());
}