Minor refactorings and code style changes. 1) Removed several use of raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments

This commit is contained in:
Narendra Pathai
2018-10-20 17:50:52 +05:30
parent 2f569d670a
commit 543eb9a4be
73 changed files with 207 additions and 298 deletions

View File

@@ -110,8 +110,6 @@ public class App {
LOGGER.info("Executor was shut down and Exiting.");
executor.shutdownNow();
}
} catch (InterruptedException ie) {
LOGGER.error(ie.getMessage());
} catch (Exception e) {
LOGGER.error(e.getMessage());
}

View File

@@ -58,8 +58,6 @@ public class ServiceExecutor implements Runnable {
Thread.sleep(1000);
}
} catch (InterruptedException ie) {
LOGGER.error(ie.getMessage());
} catch (Exception e) {
LOGGER.error(e.getMessage());
}

View File

@@ -80,8 +80,6 @@ public class TaskGenerator implements Task, Runnable {
// Make the current thread to sleep after every Message submission.
Thread.sleep(1000);
}
} catch (InterruptedException ie) {
LOGGER.error(ie.getMessage());
} catch (Exception e) {
LOGGER.error(e.getMessage());
}

View File

@@ -42,7 +42,7 @@ public class MessageQueueTest {
msgQueue.submitMsg(new Message("MessageQueue Test"));
// retrieve message
assertEquals(msgQueue.retrieveMsg().getMsg(), "MessageQueue Test");
assertEquals("MessageQueue Test", msgQueue.retrieveMsg().getMsg());
}
}

View File

@@ -39,6 +39,6 @@ public class MessageTest {
// Parameterized constructor test.
String testMsg = "Message Test";
Message msg = new Message(testMsg);
assertEquals(msg.getMsg(), testMsg);
assertEquals(testMsg, msg.getMsg());
}
}