gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

refactoring: Critical Sonar Issues (#1833)

Browse Source 
* Resolve Sonar Code Smell: Define a constant instead of duplicating this literal 'Space rocket <' 4 times.

* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'Error connecting to MongoDB' 4 times.

* Fix checkstyle violation.

* Resolve Sonar Critical Code Smell: Define a constant instead of duplicating this literal 'LITERAL 0' 4 times.

Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
This commit is contained in:
Simran Keshri 2021-10-13 13:15:22 +05:30 committed by GitHub
parent cab9048e06
commit 5a644f1092
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 32 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java
View File

@ -59,9 +59,12 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j @Slf4j
public class App { public class App {
private static final String ROCKET_LAUNCH_LOG_PATTERN = "Space rocket <%s> launched successfully";
/** /**
* Program entry point. * Program entry point.
*/ */
public static void main(String[] args) throws Exception { public static void main(String[] args) throws Exception {
// construct a new executor that will run async tasks // construct a new executor that will run async tasks
var executor = new ThreadAsyncExecutor(); var executor = new ThreadAsyncExecutor();
@ -87,9 +90,9 @@ public class App {
asyncResult5.await(); asyncResult5.await();
// log the results of the tasks, callbacks log immediately when complete // log the results of the tasks, callbacks log immediately when complete
log("Space rocket <" + result1 + "> launch complete"); log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result1));
log("Space rocket <" + result2 + "> launch complete"); log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result2));
log("Space rocket <" + result3 + "> launch complete"); log(String.format(ROCKET_LAUNCH_LOG_PATTERN, result3));
} }
/** /**
@ -102,7 +105,7 @@ public class App {
private static <T> Callable<T> lazyval(T value, long delayMillis) { private static <T> Callable<T> lazyval(T value, long delayMillis) {
return () -> { return () -> {
Thread.sleep(delayMillis); Thread.sleep(delayMillis);
log("Space rocket <" + value + "> launched successfully"); log(String.format(ROCKET_LAUNCH_LOG_PATTERN, value));
return value; return value;
}; };
} }

32
bytecode/src/main/java/com/iluwatar/bytecode/App.java
View File

@ -42,6 +42,14 @@ import lombok.extern.slf4j.Slf4j;
@Slf4j @Slf4j
public class App { public class App {
private static final String LITERAL_0 = "LITERAL 0";
private static final String HEALTH_PATTERN = "%s_HEALTH";
private static final String GET_AGILITY = "GET_AGILITY";
private static final String GET_WISDOM = "GET_WISDOM";
private static final String ADD = "ADD";
private static final String LITERAL_2 = "LITERAL 2";
private static final String DIVIDE = "DIVIDE";
/** /**
* Main app method. * Main app method.
* *
@ -53,17 +61,17 @@ public class App {
new Wizard(45, 7, 11, 0, 0), new Wizard(45, 7, 11, 0, 0),
new Wizard(36, 18, 8, 0, 0)); new Wizard(36, 18, 8, 0, 0));
vm.execute(InstructionConverterUtil.convertToByteCode("LITERAL 0")); vm.execute(InstructionConverterUtil.convertToByteCode(LITERAL_0));
vm.execute(InstructionConverterUtil.convertToByteCode("LITERAL 0")); vm.execute(InstructionConverterUtil.convertToByteCode(LITERAL_0));
vm.execute(InstructionConverterUtil.convertToByteCode("GET_HEALTH")); vm.execute(InstructionConverterUtil.convertToByteCode(String.format(HEALTH_PATTERN, "GET")));
vm.execute(InstructionConverterUtil.convertToByteCode("LITERAL 0")); vm.execute(InstructionConverterUtil.convertToByteCode(LITERAL_0));
vm.execute(InstructionConverterUtil.convertToByteCode("GET_AGILITY")); vm.execute(InstructionConverterUtil.convertToByteCode(GET_AGILITY));
vm.execute(InstructionConverterUtil.convertToByteCode("LITERAL 0")); vm.execute(InstructionConverterUtil.convertToByteCode(LITERAL_0));
vm.execute(InstructionConverterUtil.convertToByteCode("GET_WISDOM")); vm.execute(InstructionConverterUtil.convertToByteCode(GET_WISDOM));
vm.execute(InstructionConverterUtil.convertToByteCode("ADD")); vm.execute(InstructionConverterUtil.convertToByteCode(ADD));
vm.execute(InstructionConverterUtil.convertToByteCode("LITERAL 2")); vm.execute(InstructionConverterUtil.convertToByteCode(LITERAL_2));
vm.execute(InstructionConverterUtil.convertToByteCode("DIVIDE")); vm.execute(InstructionConverterUtil.convertToByteCode(DIVIDE));
vm.execute(InstructionConverterUtil.convertToByteCode("ADD")); vm.execute(InstructionConverterUtil.convertToByteCode(ADD));
vm.execute(InstructionConverterUtil.convertToByteCode("SET_HEALTH")); vm.execute(InstructionConverterUtil.convertToByteCode(String.format(HEALTH_PATTERN, "SET")));
} }
} }

9
caching/src/main/java/com/iluwatar/caching/DbManager.java
View File

@ -50,6 +50,7 @@ public final class DbManager {
private static boolean useMongoDB; private static boolean useMongoDB;
private static Map<String, UserAccount> virtualDB; private static Map<String, UserAccount> virtualDB;
private static final String ERROR_MESSAGE_LOG = "Error connecting to MongoDB";
private DbManager() { private DbManager() {
} }
@ -85,7 +86,7 @@ public final class DbManager {
try { try {
connect(); connect();
} catch (ParseException e) { } catch (ParseException e) {
LOGGER.error("Error connecting to MongoDB", e); LOGGER.error(ERROR_MESSAGE_LOG, e);
} }
} }
var iterable = db var iterable = db
@ -112,7 +113,7 @@ public final class DbManager {
try { try {
connect(); connect();
} catch (ParseException e) { } catch (ParseException e) {
LOGGER.error("Error connecting to MongoDB", e); LOGGER.error(ERROR_MESSAGE_LOG, e);
} }
} }
db.getCollection(CachingConstants.USER_ACCOUNT).insertOne( db.getCollection(CachingConstants.USER_ACCOUNT).insertOne(
@ -134,7 +135,7 @@ public final class DbManager {
try { try {
connect(); connect();
} catch (ParseException e) { } catch (ParseException e) {
LOGGER.error("Error connecting to MongoDB", e); LOGGER.error(ERROR_MESSAGE_LOG, e);
} }
} }
db.getCollection(CachingConstants.USER_ACCOUNT).updateOne( db.getCollection(CachingConstants.USER_ACCOUNT).updateOne(
@ -155,7 +156,7 @@ public final class DbManager {
try { try {
connect(); connect();
} catch (ParseException e) { } catch (ParseException e) {
LOGGER.error("Error connecting to MongoDB", e); LOGGER.error(ERROR_MESSAGE_LOG, e);
} }
} }
db.getCollection(CachingConstants.USER_ACCOUNT).updateOne( db.getCollection(CachingConstants.USER_ACCOUNT).updateOne(