📍Use lombok, reformat, and optimize the code (#1560)

* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>

data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java

@@ -31,8 +31,7 @@ import com.iluwatar.datatransfer.product.ProductResource;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * The Data Transfer Object pattern is a design pattern in which an data transfer object is used to
@@ -50,10 +49,9 @@ import org.slf4j.LoggerFactory;
  * thought as a traditional example and the second is an enum based implementation.
  *
  */
+@Slf4j
 public class App {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(App.class);
-
   /**
    * Method as act client and request to server for details.
    *

data-transfer-object/src/main/java/com/iluwatar/datatransfer/customer/CustomerDto.java

@@ -23,39 +23,20 @@
 
 package com.iluwatar.datatransfer.customer;
 
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+
 /**
  * {@link CustomerDto} is a data transfer object POJO. Instead of sending individual information to
  * client We can send related information together in POJO.
  *
  * <p>Dto will not have any business logic in it.
  */
+@Getter
+@RequiredArgsConstructor
 public class CustomerDto {
   private final String id;
   private final String firstName;
   private final String lastName;
 
-  /**
-   * Constructor.
-   *
-   * @param id        customer id
-   * @param firstName customer first name
-   * @param lastName  customer last name
-   */
-  public CustomerDto(String id, String firstName, String lastName) {
-    this.id = id;
-    this.firstName = firstName;
-    this.lastName = lastName;
-  }
-
-  public String getId() {
-    return id;
-  }
-
-  public String getFirstName() {
-    return firstName;
-  }
-
-  public String getLastName() {
-    return lastName;
-  }
 }

data-transfer-object/src/main/java/com/iluwatar/datatransfer/customer/CustomerResource.java

@@ -24,23 +24,16 @@
 package com.iluwatar.datatransfer.customer;
 
 import java.util.List;
+import lombok.RequiredArgsConstructor;
 
 /**
  * The resource class which serves customer information. This class act as server in the demo. Which
  * has all customer details.
  */
+@RequiredArgsConstructor
 public class CustomerResource {
   private final List<CustomerDto> customers;
 
-  /**
-   * Initialise resource with existing customers.
-   *
-   * @param customers initialize resource with existing customers. Act as database.
-   */
-  public CustomerResource(List<CustomerDto> customers) {
-    this.customers = customers;
-  }
-
   /**
    * Get all customers.
    *

data-transfer-object/src/test/java/com/iluwatar/datatransfer/AppTest.java

@@ -29,15 +29,15 @@ import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 
 class AppTest {
 
-    /**
-     * Issue: Add at least one assertion to this test case.
-     *
-     * Solution: Inserted assertion to check whether the execution of the main method in {@link App#main(String[])}
-     * throws an exception.
-     */
+  /**
+   * Issue: Add at least one assertion to this test case.
+   *
+   * Solution: Inserted assertion to check whether the execution of the main method in {@link App#main(String[])}
+   * throws an exception.
+   */
 
-    @Test
-    void shouldExecuteApplicationWithoutException() {
-        assertDoesNotThrow(() -> App.main(new String[]{}));
-    }
+  @Test
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
+  }
 }

data-transfer-object/src/test/java/com/iluwatar/datatransfer/customer/CustomerResourceTest.java

@@ -36,9 +36,10 @@ import org.junit.jupiter.api.Test;
 /**
  * tests {@link CustomerResource}.
  */
-public class CustomerResourceTest {
+class CustomerResourceTest {
+
   @Test
-  public void shouldGetAllCustomers() {
+  void shouldGetAllCustomers() {
     var customers = List.of(new CustomerDto("1", "Melody", "Yates"));
     var customerResource = new CustomerResource(customers);
     var allCustomers = customerResource.getAllCustomers();
@@ -50,7 +51,7 @@ public class CustomerResourceTest {
   }
 
   @Test
-  public void shouldSaveCustomer() {
+  void shouldSaveCustomer() {
     var customer = new CustomerDto("1", "Rita", "Reynolds");
     var customerResource = new CustomerResource(new ArrayList<>());
 
@@ -63,7 +64,7 @@ public class CustomerResourceTest {
   }
 
   @Test
-  public void shouldDeleteCustomer() {
+  void shouldDeleteCustomer() {
     var customer = new CustomerDto("1", "Terry", "Nguyen");
     var customers = new ArrayList<>(List.of(customer));
     var customerResource = new CustomerResource(customers);