📍Use lombok, reformat, and optimize the code (#1560)
* Use lombok, reformat, and optimize the code * Fix merge conflicts and some sonar issues Co-authored-by: va1m <va1m@email.com>
This commit is contained in:
@ -24,21 +24,17 @@
|
||||
package com.iluwatar.eda.event;
|
||||
|
||||
import com.iluwatar.eda.model.User;
|
||||
import lombok.Getter;
|
||||
import lombok.RequiredArgsConstructor;
|
||||
|
||||
/**
|
||||
* The {@link UserCreatedEvent} should should be dispatched whenever a user has been created. This
|
||||
* class can be extended to contain details about the user has been created. In this example, the
|
||||
* entire {@link User} object is passed on as data with the event.
|
||||
*/
|
||||
@RequiredArgsConstructor
|
||||
@Getter
|
||||
public class UserCreatedEvent extends AbstractEvent {
|
||||
|
||||
private final User user;
|
||||
|
||||
public UserCreatedEvent(User user) {
|
||||
this.user = user;
|
||||
}
|
||||
|
||||
public User getUser() {
|
||||
return user;
|
||||
}
|
||||
}
|
||||
|
@ -24,21 +24,17 @@
|
||||
package com.iluwatar.eda.event;
|
||||
|
||||
import com.iluwatar.eda.model.User;
|
||||
import lombok.Getter;
|
||||
import lombok.RequiredArgsConstructor;
|
||||
|
||||
/**
|
||||
* The {@link UserUpdatedEvent} should should be dispatched whenever a user has been updated. This
|
||||
* class can be extended to contain details about the user has been updated. In this example, the
|
||||
* entire {@link User} object is passed on as data with the event.
|
||||
*/
|
||||
@RequiredArgsConstructor
|
||||
@Getter
|
||||
public class UserUpdatedEvent extends AbstractEvent {
|
||||
|
||||
private final User user;
|
||||
|
||||
public UserUpdatedEvent(User user) {
|
||||
this.user = user;
|
||||
}
|
||||
|
||||
public User getUser() {
|
||||
return user;
|
||||
}
|
||||
}
|
||||
|
@ -25,16 +25,14 @@ package com.iluwatar.eda.handler;
|
||||
|
||||
import com.iluwatar.eda.event.UserCreatedEvent;
|
||||
import com.iluwatar.eda.framework.Handler;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import lombok.extern.slf4j.Slf4j;
|
||||
|
||||
/**
|
||||
* Handles the {@link UserCreatedEvent} message.
|
||||
*/
|
||||
@Slf4j
|
||||
public class UserCreatedEventHandler implements Handler<UserCreatedEvent> {
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(UserCreatedEventHandler.class);
|
||||
|
||||
@Override
|
||||
public void onEvent(UserCreatedEvent event) {
|
||||
LOGGER.info("User '{}' has been Created!", event.getUser().getUsername());
|
||||
|
@ -25,16 +25,14 @@ package com.iluwatar.eda.handler;
|
||||
|
||||
import com.iluwatar.eda.event.UserUpdatedEvent;
|
||||
import com.iluwatar.eda.framework.Handler;
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import lombok.extern.slf4j.Slf4j;
|
||||
|
||||
/**
|
||||
* Handles the {@link UserUpdatedEvent} message.
|
||||
*/
|
||||
@Slf4j
|
||||
public class UserUpdatedEventHandler implements Handler<UserUpdatedEvent> {
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(UserUpdatedEventHandler.class);
|
||||
|
||||
@Override
|
||||
public void onEvent(UserUpdatedEvent event) {
|
||||
LOGGER.info("User '{}' has been Updated!", event.getUser().getUsername());
|
||||
|
@ -25,20 +25,16 @@ package com.iluwatar.eda.model;
|
||||
|
||||
import com.iluwatar.eda.event.UserCreatedEvent;
|
||||
import com.iluwatar.eda.event.UserUpdatedEvent;
|
||||
import lombok.Getter;
|
||||
import lombok.RequiredArgsConstructor;
|
||||
|
||||
/**
|
||||
* This {@link User} class is a basic pojo used to demonstrate user data sent along with the {@link
|
||||
* UserCreatedEvent} and {@link UserUpdatedEvent} events.
|
||||
*/
|
||||
@RequiredArgsConstructor
|
||||
@Getter
|
||||
public class User {
|
||||
|
||||
private final String username;
|
||||
|
||||
public User(String username) {
|
||||
this.username = username;
|
||||
}
|
||||
|
||||
public String getUsername() {
|
||||
return username;
|
||||
}
|
||||
}
|
||||
|
@ -31,14 +31,14 @@ import org.junit.jupiter.api.Test;
|
||||
/**
|
||||
* {@link UserCreatedEventTest} tests and verifies {@link AbstractEvent} behaviour.
|
||||
*/
|
||||
public class UserCreatedEventTest {
|
||||
class UserCreatedEventTest {
|
||||
|
||||
/**
|
||||
* This unit test should correctly return the {@link AbstractEvent} class type when calling the
|
||||
* {@link AbstractEvent#getType() getType} method.
|
||||
*/
|
||||
@Test
|
||||
public void testGetEventType() {
|
||||
void testGetEventType() {
|
||||
var user = new User("iluwatar");
|
||||
var userCreatedEvent = new UserCreatedEvent(user);
|
||||
assertEquals(UserCreatedEvent.class, userCreatedEvent.getType());
|
||||
|
@ -36,14 +36,14 @@ import org.junit.jupiter.api.Test;
|
||||
/**
|
||||
* Event Dispatcher unit tests to assert and verify correct event dispatcher behaviour
|
||||
*/
|
||||
public class EventDispatcherTest {
|
||||
class EventDispatcherTest {
|
||||
|
||||
/**
|
||||
* This unit test should register events and event handlers correctly with the event dispatcher
|
||||
* and events should be dispatched accordingly.
|
||||
*/
|
||||
@Test
|
||||
public void testEventDriverPattern() {
|
||||
void testEventDriverPattern() {
|
||||
|
||||
var dispatcher = spy(new EventDispatcher());
|
||||
var userCreatedEventHandler = spy(new UserCreatedEventHandler());
|
||||
|
Reference in New Issue
Block a user