📍Use lombok, reformat, and optimize the code (#1560)

* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>
This commit is contained in:
va1m
2021-03-13 13:19:21 +01:00
committed by GitHub
parent 0e26a6adb5
commit 5cf2fe009b
681 changed files with 2472 additions and 4966 deletions

View File

@ -35,17 +35,17 @@ import org.junit.jupiter.api.Test;
/**
* Test Properties Toggle
*/
public class PropertiesFeatureToggleVersionTest {
class PropertiesFeatureToggleVersionTest {
@Test
public void testNullPropertiesPassed() {
void testNullPropertiesPassed() {
assertThrows(IllegalArgumentException.class, () -> {
new PropertiesFeatureToggleVersion(null);
});
}
@Test
public void testNonBooleanProperty() {
void testNonBooleanProperty() {
assertThrows(IllegalArgumentException.class, () -> {
final var properties = new Properties();
properties.setProperty("enhancedWelcome", "Something");
@ -54,7 +54,7 @@ public class PropertiesFeatureToggleVersionTest {
}
@Test
public void testFeatureTurnedOn() {
void testFeatureTurnedOn() {
final var properties = new Properties();
properties.put("enhancedWelcome", true);
var service = new PropertiesFeatureToggleVersion(properties);
@ -64,7 +64,7 @@ public class PropertiesFeatureToggleVersionTest {
}
@Test
public void testFeatureTurnedOff() {
void testFeatureTurnedOff() {
final var properties = new Properties();
properties.put("enhancedWelcome", false);
var service = new PropertiesFeatureToggleVersion(properties);

View File

@ -35,34 +35,34 @@ import org.junit.jupiter.api.Test;
/**
* Test Tiered Feature Toggle
*/
public class TieredFeatureToggleVersionTest {
class TieredFeatureToggleVersionTest {
final User paidUser = new User("Jamie Coder");
final User freeUser = new User("Alan Defect");
final Service service = new TieredFeatureToggleVersion();
@BeforeEach
public void setUp() {
void setUp() {
UserGroup.addUserToPaidGroup(paidUser);
UserGroup.addUserToFreeGroup(freeUser);
}
@Test
public void testGetWelcomeMessageForPaidUser() {
void testGetWelcomeMessageForPaidUser() {
final var welcomeMessage = service.getWelcomeMessage(paidUser);
final var expected = "You're amazing Jamie Coder. Thanks for paying for this awesome software.";
assertEquals(expected, welcomeMessage);
}
@Test
public void testGetWelcomeMessageForFreeUser() {
void testGetWelcomeMessageForFreeUser() {
final var welcomeMessage = service.getWelcomeMessage(freeUser);
final var expected = "I suppose you can use this software.";
assertEquals(expected, welcomeMessage);
}
@Test
public void testIsEnhancedAlwaysTrueAsTiered() {
void testIsEnhancedAlwaysTrueAsTiered() {
assertTrue(service.isEnhanced());
}
}

View File

@ -32,24 +32,24 @@ import org.junit.jupiter.api.Test;
/**
* Test User Group specific feature
*/
public class UserGroupTest {
class UserGroupTest {
@Test
public void testAddUserToFreeGroup() {
void testAddUserToFreeGroup() {
var user = new User("Free User");
UserGroup.addUserToFreeGroup(user);
assertFalse(UserGroup.isPaid(user));
}
@Test
public void testAddUserToPaidGroup() {
void testAddUserToPaidGroup() {
var user = new User("Paid User");
UserGroup.addUserToPaidGroup(user);
assertTrue(UserGroup.isPaid(user));
}
@Test
public void testAddUserToPaidWhenOnFree() {
void testAddUserToPaidWhenOnFree() {
var user = new User("Paid User");
UserGroup.addUserToFreeGroup(user);
assertThrows(IllegalArgumentException.class, () -> {
@ -58,7 +58,7 @@ public class UserGroupTest {
}
@Test
public void testAddUserToFreeWhenOnPaid() {
void testAddUserToFreeWhenOnPaid() {
var user = new User("Free User");
UserGroup.addUserToPaidGroup(user);
assertThrows(IllegalArgumentException.class, () -> {