📍Use lombok, reformat, and optimize the code (#1560)
* Use lombok, reformat, and optimize the code * Fix merge conflicts and some sonar issues Co-authored-by: va1m <va1m@email.com>
This commit is contained in:
@ -37,8 +37,8 @@ Taking our stew example from above. First we have a `Stew` class where its data
|
||||
private class data, making the stew's ingredient mutable to class methods.
|
||||
|
||||
```java
|
||||
@Slf4j
|
||||
public class Stew {
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(Stew.class);
|
||||
private int numPotatoes;
|
||||
private int numCarrots;
|
||||
private int numMeat;
|
||||
@ -99,8 +99,8 @@ public class StewData {
|
||||
return numPeppers;
|
||||
}
|
||||
}
|
||||
@Slf4j
|
||||
public class ImmutableStew {
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(ImmutableStew.class);
|
||||
private final StewData data;
|
||||
public ImmutableStew(int numPotatoes, int numCarrots, int numMeat, int numPeppers) {
|
||||
data = new StewData(numPotatoes, numCarrots, numMeat, numPeppers);
|
||||
|
@ -23,16 +23,14 @@
|
||||
|
||||
package com.iluwatar.privateclassdata;
|
||||
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import lombok.extern.slf4j.Slf4j;
|
||||
|
||||
/**
|
||||
* Immutable stew class, protected with Private Class Data pattern.
|
||||
*/
|
||||
@Slf4j
|
||||
public class ImmutableStew {
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(ImmutableStew.class);
|
||||
|
||||
private final StewData data;
|
||||
|
||||
public ImmutableStew(int numPotatoes, int numCarrots, int numMeat, int numPeppers) {
|
||||
|
@ -23,16 +23,14 @@
|
||||
|
||||
package com.iluwatar.privateclassdata;
|
||||
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
import lombok.extern.slf4j.Slf4j;
|
||||
|
||||
/**
|
||||
* Mutable stew class.
|
||||
*/
|
||||
@Slf4j
|
||||
public class Stew {
|
||||
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(Stew.class);
|
||||
|
||||
private int numPotatoes;
|
||||
private int numCarrots;
|
||||
private int numMeat;
|
||||
|
@ -53,7 +53,7 @@ public class ImmutableStewTest {
|
||||
* Verify if mixing the stew doesn't change the internal state
|
||||
*/
|
||||
@Test
|
||||
public void testMix() {
|
||||
void testMix() {
|
||||
var stew = new Stew(1, 2, 3, 4);
|
||||
var expectedMessage = "Mixing the stew we find: 1 potatoes, 2 carrots, 3 meat and 4 peppers";
|
||||
|
||||
@ -69,7 +69,7 @@ public class ImmutableStewTest {
|
||||
* Verify if tasting the stew actually removes one of each ingredient
|
||||
*/
|
||||
@Test
|
||||
public void testDrink() {
|
||||
void testDrink() {
|
||||
final var stew = new Stew(1, 2, 3, 4);
|
||||
stew.mix();
|
||||
|
||||
|
@ -53,7 +53,7 @@ public class StewTest {
|
||||
* Verify if mixing the stew doesn't change the internal state
|
||||
*/
|
||||
@Test
|
||||
public void testMix() {
|
||||
void testMix() {
|
||||
final var stew = new ImmutableStew(1, 2, 3, 4);
|
||||
final var expectedMessage = "Mixing the immutable stew we find: 1 potatoes, "
|
||||
+ "2 carrots, 3 meat and 4 peppers";
|
||||
|
Reference in New Issue
Block a user