📍Use lombok, reformat, and optimize the code (#1560)

* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>

sharding/src/main/java/com/iluwatar/sharding/Data.java

@@ -77,8 +77,8 @@ public class Data {
   @Override
   public String toString() {
     return "Data {" + "key="
-      + key + ", value='" + value
-      + '\'' + ", type=" + type + '}';
+        + key + ", value='" + value
+        + '\'' + ", type=" + type + '}';
   }
 }
 

sharding/src/main/java/com/iluwatar/sharding/HashShardManager.java

@@ -23,8 +23,7 @@
 
 package com.iluwatar.sharding;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * ShardManager with hash strategy. The purpose of this strategy is to reduce the
@@ -32,10 +31,9 @@ import org.slf4j.LoggerFactory;
  * in a way that achieves a balance between the size of each shard and the average
  * load that each shard will encounter.
  */
+@Slf4j
 public class HashShardManager extends ShardManager {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(HashShardManager.class);
-
   @Override
   public int storeData(Data data) {
     var shardId = allocateShard(data);

sharding/src/main/java/com/iluwatar/sharding/LookupShardManager.java

@@ -26,19 +26,17 @@ package com.iluwatar.sharding;
 import java.security.SecureRandom;
 import java.util.HashMap;
 import java.util.Map;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import java.util.Random;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * ShardManager with lookup strategy. In this strategy the sharding logic implements
  * a map that routes a request for data to the shard that contains that data by using
  * the shard key.
  */
+@Slf4j
 public class LookupShardManager extends ShardManager {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(LookupShardManager.class);
-
   private final Map<Integer, Integer> lookupMap = new HashMap<>();
 
   @Override

sharding/src/main/java/com/iluwatar/sharding/RangeShardManager.java

@@ -23,17 +23,15 @@
 
 package com.iluwatar.sharding;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * ShardManager with range strategy. This strategy groups related items together in the same shard,
  * and orders them by shard key.
  */
+@Slf4j
 public class RangeShardManager extends ShardManager {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(RangeShardManager.class);
-
   @Override
   public int storeData(Data data) {
     var shardId = allocateShard(data);

sharding/src/main/java/com/iluwatar/sharding/ShardManager.java

@@ -25,17 +25,14 @@ package com.iluwatar.sharding;
 
 import java.util.HashMap;
 import java.util.Map;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import lombok.extern.slf4j.Slf4j;
 
 /**
  * Abstract class for ShardManager.
  */
+@Slf4j
 public abstract class ShardManager {
 
-  private static final Logger LOGGER = LoggerFactory.getLogger(ShardManager.class);
-
   protected Map<Integer, Shard> shardMap;
 
   public ShardManager() {

sharding/src/test/java/com/iluwatar/sharding/ShardManagerTest.java

@@ -85,7 +85,7 @@ class ShardManagerTest {
     assertEquals(shard, tmpShard);
   }
 
-  class TestShardManager extends ShardManager {
+  static class TestShardManager extends ShardManager {
 
     @Override
     public int storeData(Data data) {