📍Use lombok, reformat, and optimize the code (#1560)

* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>
This commit is contained in:
va1m
2021-03-13 13:19:21 +01:00
committed by GitHub
parent 0e26a6adb5
commit 5cf2fe009b
681 changed files with 2472 additions and 4966 deletions

View File

@@ -23,8 +23,7 @@
package com.iluwatar.stepbuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import lombok.extern.slf4j.Slf4j;
/**
* Step Builder Pattern
@@ -56,10 +55,9 @@ import org.slf4j.LoggerFactory;
*
* @see <a href="http://rdafbn.blogspot.co.uk/2012/07/step-builder-pattern_28.html">http://rdafbn.blogspot.co.uk/2012/07/step-builder-pattern_28.html</a>
*/
@Slf4j
public class App {
private static final Logger LOGGER = LoggerFactory.getLogger(App.class);
/**
* Program entry point.
*

View File

@@ -41,7 +41,7 @@ public class CharacterStepBuilderTest {
* Build a new wizard {@link Character} and verify if it has the expected attributes
*/
@Test
public void testBuildWizard() {
void testBuildWizard() {
final var character = CharacterStepBuilder.newBuilder()
.name("Merlin")
.wizardClass("alchemist")
@@ -69,7 +69,7 @@ public class CharacterStepBuilderTest {
* expected attributes
*/
@Test
public void testBuildPoorWizard() {
void testBuildPoorWizard() {
final var character = CharacterStepBuilder.newBuilder()
.name("Merlin")
.wizardClass("alchemist")
@@ -88,7 +88,7 @@ public class CharacterStepBuilderTest {
* Build a new wizard {@link Character} and verify if it has the expected attributes
*/
@Test
public void testBuildWeakWizard() {
void testBuildWeakWizard() {
final var character = CharacterStepBuilder.newBuilder()
.name("Merlin")
.wizardClass("alchemist")
@@ -104,12 +104,11 @@ public class CharacterStepBuilderTest {
}
/**
* Build a new warrior {@link Character} and verify if it has the expected attributes
*/
@Test
public void testBuildWarrior() {
void testBuildWarrior() {
final var character = CharacterStepBuilder.newBuilder()
.name("Cuauhtemoc")
.fighterClass("aztec")
@@ -137,7 +136,7 @@ public class CharacterStepBuilderTest {
* expected attributes
*/
@Test
public void testBuildPoorWarrior() {
void testBuildPoorWarrior() {
final var character = CharacterStepBuilder.newBuilder()
.name("Poor warrior")
.fighterClass("none")
@@ -157,7 +156,7 @@ public class CharacterStepBuilderTest {
* has the expected attributes
*/
@Test
public void testBuildWeakWarrior() {
void testBuildWeakWarrior() {
final var character = CharacterStepBuilder.newBuilder()
.name("Weak warrior")
.fighterClass("none")