gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

📍Use lombok, reformat, and optimize the code (#1560)

Browse Source 
* Use lombok, reformat, and optimize the code

* Fix merge conflicts and some sonar issues

Co-authored-by: va1m <va1m@email.com>
This commit is contained in:
va1m
2021-03-13 13:19:21 +01:00
committed by GitHub
parent 0e26a6adb5
commit 5cf2fe009b
681 changed files with 2472 additions and 4966 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java
View File

@ -23,16 +23,14 @@
package com.iluwatar.visitor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import lombok.extern.slf4j.Slf4j;
/**
* CommanderVisitor.
*/
@Slf4j
public class CommanderVisitor implements UnitVisitor {
private static final Logger LOGGER = LoggerFactory.getLogger(CommanderVisitor.class);
@Override
public void visitSoldier(Soldier soldier) {
// Do nothing

6
visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java
View File

@ -23,16 +23,14 @@
package com.iluwatar.visitor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import lombok.extern.slf4j.Slf4j;
/**
* SergeantVisitor.
*/
@Slf4j
public class SergeantVisitor implements UnitVisitor {
private static final Logger LOGGER = LoggerFactory.getLogger(SergeantVisitor.class);
@Override
public void visitSoldier(Soldier soldier) {
// Do nothing

6
visitor/src/main/java/com/iluwatar/visitor/SoldierVisitor.java
View File

@ -23,16 +23,14 @@
package com.iluwatar.visitor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import lombok.extern.slf4j.Slf4j;
/**
* SoldierVisitor.
*/
@Slf4j
public class SoldierVisitor implements UnitVisitor {
private static final Logger LOGGER = LoggerFactory.getLogger(SoldierVisitor.class);
@Override
public void visitSoldier(Soldier soldier) {
LOGGER.info("Greetings {}", soldier);

2
visitor/src/test/java/com/iluwatar/visitor/UnitTest.java
View File

@ -55,7 +55,7 @@ public abstract class UnitTest<U extends Unit> {
}
@Test
public void testAccept() {
void testAccept() {
final var children = new Unit[5];
Arrays.setAll(children, (i) -> mock(Unit.class));

6
visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java
View File

@ -96,7 +96,7 @@ public abstract class VisitorTest<V extends UnitVisitor> {
}
@Test
public void testVisitCommander() {
void testVisitCommander() {
this.visitor.visitCommander(new Commander());
if (this.commanderResponse.isPresent()) {
assertEquals(this.commanderResponse.get(), appender.getLastMessage());
@ -105,7 +105,7 @@ public abstract class VisitorTest<V extends UnitVisitor> {
}
@Test
public void testVisitSergeant() {
void testVisitSergeant() {
this.visitor.visitSergeant(new Sergeant());
if (this.sergeantResponse.isPresent()) {
assertEquals(this.sergeantResponse.get(), appender.getLastMessage());
@ -114,7 +114,7 @@ public abstract class VisitorTest<V extends UnitVisitor> {
}
@Test
public void testVisitSoldier() {
void testVisitSoldier() {
this.visitor.visitSoldier(new Soldier());
if (this.soldierResponse.isPresent()) {
assertEquals(this.soldierResponse.get(), appender.getLastMessage());