From 5d8806858b387b4a05c6275ab706d79f43c9e91e Mon Sep 17 00:00:00 2001 From: Amit Dixit Date: Thu, 1 Dec 2016 16:29:35 +0530 Subject: [PATCH] Review comments++ --- module/src/main/java/com/iluwatar/module/App.java | 8 ++------ .../java/com/iluwatar/module/ConsoleLoggerModule.java | 4 +++- .../main/java/com/iluwatar/module/FileLoggerModule.java | 4 +++- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/module/src/main/java/com/iluwatar/module/App.java b/module/src/main/java/com/iluwatar/module/App.java index a72050fb3..1c117722f 100644 --- a/module/src/main/java/com/iluwatar/module/App.java +++ b/module/src/main/java/com/iluwatar/module/App.java @@ -45,12 +45,8 @@ public final class App { public static void prepare() throws FileNotFoundException { /* Create new singleton objects and prepare their modules */ - fileLoggerModule = FileLoggerModule.getSingleton(); - consoleLoggerModule = ConsoleLoggerModule.getSingleton(); - - /* Prepare modules */ - fileLoggerModule.prepare(); - consoleLoggerModule.prepare(); + fileLoggerModule = FileLoggerModule.getSingleton().prepare(); + consoleLoggerModule = ConsoleLoggerModule.getSingleton().prepare(); } /** diff --git a/module/src/main/java/com/iluwatar/module/ConsoleLoggerModule.java b/module/src/main/java/com/iluwatar/module/ConsoleLoggerModule.java index 9692d7091..0efdd9033 100644 --- a/module/src/main/java/com/iluwatar/module/ConsoleLoggerModule.java +++ b/module/src/main/java/com/iluwatar/module/ConsoleLoggerModule.java @@ -56,12 +56,14 @@ public final class ConsoleLoggerModule { /** * Following method performs the initialization */ - public void prepare() { + public ConsoleLoggerModule prepare() { LOGGER.debug("ConsoleLoggerModule::prepare();"); this.output = new PrintStream(System.out); this.error = new PrintStream(System.err); + + return this; } /** diff --git a/module/src/main/java/com/iluwatar/module/FileLoggerModule.java b/module/src/main/java/com/iluwatar/module/FileLoggerModule.java index b1329b358..e80444dab 100644 --- a/module/src/main/java/com/iluwatar/module/FileLoggerModule.java +++ b/module/src/main/java/com/iluwatar/module/FileLoggerModule.java @@ -64,12 +64,14 @@ public final class FileLoggerModule { * @throws FileNotFoundException if program is not able to find log files (output.txt and * error.txt) */ - public void prepare() throws FileNotFoundException { + public FileLoggerModule prepare() throws FileNotFoundException { LOGGER.debug("FileLoggerModule::prepare();"); this.output = new PrintStream(new FileOutputStream(OUTPUT_FILE)); this.error = new PrintStream(new FileOutputStream(ERROR_FILE)); + + return this; } /**