Java 11 migrate 7 remaining f (#1115)

* Moves facade to Java 11

* Moves factory-kit to Java 11

* Moves factory-method to Java 11

* Moves feature-toggle to Java 11

* Moves fluentinterface to Java 11

* Moves flux to Java 11

* Moves flyweight to Java 11

* Moves front-controller to Java 11

* Uses stream properly

* Resolves issues with ci

flyweight/src/main/java/com/iluwatar/flyweight/AlchemistShop.java

@@ -23,7 +23,6 @@
 
 package com.iluwatar.flyweight;
 
-import java.util.Collections;
 import java.util.List;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -42,7 +41,7 @@ public class AlchemistShop {
    * Constructor.
    */
   public AlchemistShop() {
-    PotionFactory factory = new PotionFactory();
+    var factory = new PotionFactory();
     topShelf = List.of(
         factory.createPotion(PotionType.INVISIBILITY),
         factory.createPotion(PotionType.INVISIBILITY),
@@ -68,7 +67,7 @@ public class AlchemistShop {
    * @return The top shelf potions
    */
   public final List<Potion> getTopShelf() {
-    return Collections.unmodifiableList(this.topShelf);
+    return List.copyOf(this.topShelf);
   }
 
   /**
@@ -77,24 +76,16 @@ public class AlchemistShop {
    * @return The bottom shelf potions
    */
   public final List<Potion> getBottomShelf() {
-    return Collections.unmodifiableList(this.bottomShelf);
+    return List.copyOf(this.bottomShelf);
   }
 
   /**
    * Enumerate potions.
    */
   public void enumerate() {
-
     LOGGER.info("Enumerating top shelf potions\n");
-
-    for (Potion p : topShelf) {
-      p.drink();
-    }
-
+    topShelf.forEach(Potion::drink);
     LOGGER.info("Enumerating bottom shelf potions\n");
-
-    for (Potion p : bottomShelf) {
-      p.drink();
-    }
+    bottomShelf.forEach(Potion::drink);
   }
 }

flyweight/src/main/java/com/iluwatar/flyweight/App.java

@@ -43,7 +43,7 @@ public class App {
    * @param args command line args
    */
   public static void main(String[] args) {
-    AlchemistShop alchemistShop = new AlchemistShop();
+    var alchemistShop = new AlchemistShop();
     alchemistShop.enumerate();
   }
 }

flyweight/src/main/java/com/iluwatar/flyweight/PotionFactory.java

@@ -40,7 +40,7 @@ public class PotionFactory {
   }
 
   Potion createPotion(PotionType type) {
-    Potion potion = potions.get(type);
+    var potion = potions.get(type);
     if (potion == null) {
       switch (type) {
         case HEALING:

flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java

@@ -23,14 +23,12 @@
 
 package com.iluwatar.flyweight;
 
-import org.junit.jupiter.api.Test;
-
-import java.util.ArrayList;
-import java.util.List;
-
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
+import java.util.ArrayList;
+import org.junit.jupiter.api.Test;
+
 /**
  * Date: 12/12/15 - 10:54 PM
  *
@@ -39,18 +37,18 @@ import static org.junit.jupiter.api.Assertions.assertNotNull;
 public class AlchemistShopTest {
 
   @Test
-  public void testShop() throws Exception {
-    final AlchemistShop shop = new AlchemistShop();
+  public void testShop() {
+    final var shop = new AlchemistShop();
 
-    final List<Potion> bottomShelf = shop.getBottomShelf();
+    final var bottomShelf = shop.getBottomShelf();
     assertNotNull(bottomShelf);
     assertEquals(5, bottomShelf.size());
 
-    final List<Potion> topShelf = shop.getTopShelf();
+    final var topShelf = shop.getTopShelf();
     assertNotNull(topShelf);
     assertEquals(8, topShelf.size());
 
-    final List<Potion> allPotions = new ArrayList<>();
+    final var allPotions = new ArrayList<Potion>();
     allPotions.addAll(topShelf);
     allPotions.addAll(bottomShelf);
 

flyweight/src/test/java/com/iluwatar/flyweight/AppTest.java

@@ -26,15 +26,12 @@ package com.iluwatar.flyweight;
 import org.junit.jupiter.api.Test;
 
 /**
- * 
  * Application test
- *
  */
 public class AppTest {
 
   @Test
   public void test() {
-    String[] args = {};
-    App.main(args);
+    App.main(new String[]{});
   }
 }