gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sonar bug fix & test cases

Browse Source
This commit is contained in:
atayal
2021-11-12 08:07:41 +05:30
parent 3a6a20c5db
commit 68354cce2f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
commander/src/main/java/com/iluwatar/commander/Commander.java
View File

@ -242,7 +242,7 @@ public class Commander {
if (System.currentTimeMillis() - qt.order.createdTime >= this.queueTime) { if (System.currentTimeMillis() - qt.order.createdTime >= this.queueTime) {
// since payment time is lesser than queuetime it would have already failed.. // since payment time is lesser than queuetime it would have already failed..
// additional check not needed // additional check not needed
LOG.trace(ORDER_ID + ": Queue time for order over, failed..", qt.order.id); LOG.trace("Order " + qt.order.id + ": Queue time for order over, failed..");
return; return;
} else if (qt.taskType.equals(TaskType.PAYMENT) && !qt.order.paid.equals(PaymentStatus.TRYING) } else if (qt.taskType.equals(TaskType.PAYMENT) && !qt.order.paid.equals(PaymentStatus.TRYING)
|| qt.taskType.equals(TaskType.MESSAGING) && (qt.messageType == 1 || qt.taskType.equals(TaskType.MESSAGING) && (qt.messageType == 1
@ -476,8 +476,8 @@ public class Commander {
&& System.currentTimeMillis() - o.createdTime < messageTime) { && System.currentTimeMillis() - o.createdTime < messageTime) {
var qt = new QueueTask(order, TaskType.MESSAGING, 1); var qt = new QueueTask(order, TaskType.MESSAGING, 1);
updateQueue(qt); updateQueue(qt);
LOG.warn(ORDER_ID + ": Error in sending Payment Error message, " LOG.warn("Order " + order.id + ": Error in sending Payment Error message, "
+ "trying to queue task and add to employee handle..", order.id); + "trying to queue task and add to employee handle..");
employeeHandleIssue(o); employeeHandleIssue(o);
} }
} }