gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Hexagonal pattern: Remove unnecessary factories

Browse Source
This commit is contained in:
Ilkka Seppälä
2016-09-17 09:07:06 +03:00
parent 914d1353a1
commit 6aa58e8ae6
13 changed files with 66 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
hexagonal/src/test/java/com/iluwatar/hexagonal/database/MongoTicketRepositoryTest.java
View File

@@ -76,9 +76,9 @@ public class MongoTicketRepositoryTest {
@Test
public void testCrudOperations() {
// create new lottery ticket and save it
PlayerDetails details = PlayerDetails.create("foo@bar.com", "123-123", "07001234");
PlayerDetails details = new PlayerDetails("foo@bar.com", "123-123", "07001234");
LotteryNumbers random = LotteryNumbers.createRandom();
LotteryTicket original = LotteryTicket.create(new LotteryTicketId(), details, random);
LotteryTicket original = new LotteryTicket(new LotteryTicketId(), details, random);
Optional<LotteryTicketId> saved = repository.save(original);
assertEquals(1, repository.getTicketsCollection().count());
assertTrue(saved.isPresent());

12
hexagonal/src/test/java/com/iluwatar/hexagonal/domain/LotteryTicketTest.java
View File

@@ -34,16 +34,16 @@ public class LotteryTicketTest {
@Test
public void testEquals() {
PlayerDetails details1 = PlayerDetails.create("bob@foo.bar", "1212-121212", "+34332322");
PlayerDetails details1 = new PlayerDetails("bob@foo.bar", "1212-121212", "+34332322");
LotteryNumbers numbers1 = LotteryNumbers.create(new HashSet<Integer>(Arrays.asList(1, 2, 3, 4)));
LotteryTicket ticket1 = LotteryTicket.create(new LotteryTicketId(), details1, numbers1);
PlayerDetails details2 = PlayerDetails.create("bob@foo.bar", "1212-121212", "+34332322");
LotteryTicket ticket1 = new LotteryTicket(new LotteryTicketId(), details1, numbers1);
PlayerDetails details2 = new PlayerDetails("bob@foo.bar", "1212-121212", "+34332322");
LotteryNumbers numbers2 = LotteryNumbers.create(new HashSet<Integer>(Arrays.asList(1, 2, 3, 4)));
LotteryTicket ticket2 = LotteryTicket.create(new LotteryTicketId(), details2, numbers2);
LotteryTicket ticket2 = new LotteryTicket(new LotteryTicketId(), details2, numbers2);
assertEquals(ticket1, ticket2);
PlayerDetails details3 = PlayerDetails.create("elsa@foo.bar", "1223-121212", "+49332322");
PlayerDetails details3 = new PlayerDetails("elsa@foo.bar", "1223-121212", "+49332322");
LotteryNumbers numbers3 = LotteryNumbers.create(new HashSet<Integer>(Arrays.asList(1, 2, 3, 8)));
LotteryTicket ticket3 = LotteryTicket.create(new LotteryTicketId(), details3, numbers3);
LotteryTicket ticket3 = new LotteryTicket(new LotteryTicketId(), details3, numbers3);
assertFalse(ticket1.equals(ticket3));
}
}

6
hexagonal/src/test/java/com/iluwatar/hexagonal/domain/PlayerDetailsTest.java
View File

@@ -36,10 +36,10 @@ public class PlayerDetailsTest {
@Test
public void testEquals() {
PlayerDetails details1 = PlayerDetails.create("tom@foo.bar", "11212-123434", "+12323425");
PlayerDetails details2 = PlayerDetails.create("tom@foo.bar", "11212-123434", "+12323425");
PlayerDetails details1 = new PlayerDetails("tom@foo.bar", "11212-123434", "+12323425");
PlayerDetails details2 = new PlayerDetails("tom@foo.bar", "11212-123434", "+12323425");
assertEquals(details1, details2);
PlayerDetails details3 = PlayerDetails.create("john@foo.bar", "16412-123439", "+34323432");
PlayerDetails details3 = new PlayerDetails("john@foo.bar", "16412-123439", "+34323432");
assertFalse(details1.equals(details3));
}
}

2
hexagonal/src/test/java/com/iluwatar/hexagonal/eventlog/MongoEventLogTest.java
View File

@@ -59,7 +59,7 @@ public class MongoEventLogTest {
@Test
public void testFundTransfers() {
PlayerDetails playerDetails = PlayerDetails.create("john@wayne.com", "000-000", "03432534543");
PlayerDetails playerDetails = new PlayerDetails("john@wayne.com", "000-000", "03432534543");
mongoEventLog.prizeError(playerDetails, 1000);
assertEquals(1, mongoEventLog.getEventsCollection().count());
mongoEventLog.prizeError(playerDetails, 1000);

4
hexagonal/src/test/java/com/iluwatar/hexagonal/test/LotteryTestUtils.java
View File

@@ -50,8 +50,8 @@ public class LotteryTestUtils {
*/
public static LotteryTicket createLotteryTicket(String email, String account, String phone,
Set<Integer> givenNumbers) {
PlayerDetails details = PlayerDetails.create(email, account, phone);
PlayerDetails details = new PlayerDetails(email, account, phone);
LotteryNumbers numbers = LotteryNumbers.create(givenNumbers);
return LotteryTicket.create(new LotteryTicketId(), details, numbers);
return new LotteryTicket(new LotteryTicketId(), details, numbers);
}
}