Resolves checkstyle errors for naked-objects null-object object-mother object-pool observer queue-load-leveling (#1082)

* Reduces checkstyle errors in naked-objects

* Reduces checkstyle errors in null-object

* Reduces checkstyle errors in object-mother

* Reduces checkstyle errors in object-pool

* Reduces checkstyle errors in observer

* Reduces checkstyle errors in queue-load-leveling

observer/src/main/java/com/iluwatar/observer/App.java

@@ -30,25 +30,23 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
  * The Observer pattern is a software design pattern in which an object, called the subject,
  * maintains a list of its dependents, called observers, and notifies them automatically of any
  * state changes, usually by calling one of their methods. It is mainly used to implement
  * distributed event handling systems. The Observer pattern is also a key part in the familiar
  * model–view–controller (MVC) architectural pattern. The Observer pattern is implemented in
  * numerous programming libraries and systems, including almost all GUI toolkits.
- * <p>
- * In this example {@link Weather} has a state that can be observed. The {@link Orcs} and
- * {@link Hobbits} register as observers and receive notifications when the {@link Weather} changes.
- * 
+ *
+ * <p>In this example {@link Weather} has a state that can be observed. The {@link Orcs} and {@link
+ * Hobbits} register as observers and receive notifications when the {@link Weather} changes.
  */
 public class App {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(App.class);
 
   /**
-   * Program entry point
-   * 
+   * Program entry point.
+   *
    * @param args command line args
    */
   public static void main(String[] args) {
@@ -64,13 +62,13 @@ public class App {
 
     // Generic observer inspired by Java Generics and Collection by Naftalin & Wadler
     LOGGER.info("--Running generic version--");
-    GWeather gWeather = new GWeather();
-    gWeather.addObserver(new GOrcs());
-    gWeather.addObserver(new GHobbits());
+    GWeather genericWeather = new GWeather();
+    genericWeather.addObserver(new GOrcs());
+    genericWeather.addObserver(new GHobbits());
 
-    gWeather.timePasses();
-    gWeather.timePasses();
-    gWeather.timePasses();
-    gWeather.timePasses();
+    genericWeather.timePasses();
+    genericWeather.timePasses();
+    genericWeather.timePasses();
+    genericWeather.timePasses();
   }
 }

observer/src/main/java/com/iluwatar/observer/Hobbits.java

@@ -27,9 +27,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
- * Hobbits
- *
+ * Hobbits.
  */
 public class Hobbits implements WeatherObserver {
 

observer/src/main/java/com/iluwatar/observer/Orcs.java

@@ -27,9 +27,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
- * Orcs
- *
+ * Orcs.
  */
 public class Orcs implements WeatherObserver {
 

observer/src/main/java/com/iluwatar/observer/Weather.java

@@ -23,17 +23,14 @@
 
 package com.iluwatar.observer;
 
+import java.util.ArrayList;
+import java.util.List;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.List;
-
 /**
- * 
  * Weather can be observed by implementing {@link WeatherObserver} interface and registering as
  * listener.
- * 
  */
 public class Weather {
 
@@ -56,7 +53,7 @@ public class Weather {
   }
 
   /**
-   * Makes time pass for weather
+   * Makes time pass for weather.
    */
   public void timePasses() {
     WeatherType[] enumValues = WeatherType.values();

observer/src/main/java/com/iluwatar/observer/WeatherObserver.java

@@ -24,9 +24,7 @@
 package com.iluwatar.observer;
 
 /**
- * 
  * Observer interface.
- * 
  */
 public interface WeatherObserver {
 

observer/src/main/java/com/iluwatar/observer/WeatherType.java

@@ -24,9 +24,7 @@
 package com.iluwatar.observer;
 
 /**
- * 
- * WeatherType enumeration
- * 
+ * WeatherType enumeration.
  */
 public enum WeatherType {
 

observer/src/main/java/com/iluwatar/observer/generic/GHobbits.java

@@ -28,9 +28,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
- * GHobbits
- *
+ * GHobbits.
  */
 public class GHobbits implements Race {
 

observer/src/main/java/com/iluwatar/observer/generic/GOrcs.java

@@ -28,9 +28,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
- * GOrcs
- *
+ * GOrcs.
  */
 public class GOrcs implements Race {
 

observer/src/main/java/com/iluwatar/observer/generic/GWeather.java

@@ -28,9 +28,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 /**
- * 
- * GWeather
- *
+ * GWeather.
  */
 public class GWeather extends Observable<GWeather, Race, WeatherType> {
 
@@ -43,7 +41,7 @@ public class GWeather extends Observable<GWeather, Race, WeatherType> {
   }
 
   /**
-   * Makes time pass for weather
+   * Makes time pass for weather.
    */
   public void timePasses() {
     WeatherType[] enumValues = WeatherType.values();

observer/src/main/java/com/iluwatar/observer/generic/Observable.java

@@ -27,7 +27,7 @@ import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 
 /**
- * Generic observer inspired by Java Generics and Collection by {@literal Naftalin & Wadler}
+ * Generic observer inspired by Java Generics and Collection by {@literal Naftalin & Wadler}.
  *
  * @param <S> Subject
  * @param <O> Observer
@@ -50,7 +50,7 @@ public abstract class Observable<S extends Observable<S, O, A>, O extends Observ
   }
 
   /**
-   * Notify observers
+   * Notify observers.
    */
   @SuppressWarnings("unchecked")
   public void notifyObservers(A argument) {

observer/src/main/java/com/iluwatar/observer/generic/Observer.java

@@ -24,7 +24,8 @@
 package com.iluwatar.observer.generic;
 
 /**
- * Observer
+ * Observer.
+ *
  * @param <S> Observable
  * @param <O> Observer
  * @param <A> Action

observer/src/main/java/com/iluwatar/observer/generic/Race.java

@@ -26,9 +26,7 @@ package com.iluwatar.observer.generic;
 import com.iluwatar.observer.WeatherType;
 
 /**
- * 
- * Race
- *
+ * Race.
  */
 public interface Race extends Observer<GWeather, Race, WeatherType> {
 }