gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #323 from DevFactory/code-quality-fix-5

Browse Source 
Code quality fixes
This commit is contained in:
Ilkka Seppälä
2015-12-30 19:47:19 +02:00
parent befe509582 191078735f
commit 7c6e1fc3d8
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
naked-objects/fixture/src/main/java/domainapp/fixture/modules/simple/SimpleObjectCreate.java
View File

@ -55,9 +55,9 @@ public class SimpleObjectCreate extends FixtureScript {
@Override
protected void execute(final ExecutionContext ec) {
String name = checkParam("name", ec, String.class);
String paramName = checkParam("name", ec, String.class);
this.simpleObject = wrap(simpleObjects).create(name);
this.simpleObject = wrap(simpleObjects).create(paramName);
// also make available to UI
ec.addResult(this, simpleObject);

6
naked-objects/fixture/src/main/java/domainapp/fixture/scenarios/RecreateSimpleObjects.java
View File

@ -69,10 +69,10 @@ public class RecreateSimpleObjects extends FixtureScript {
protected void execute(final ExecutionContext ec) {
// defaults
final int number = defaultParam("number", ec, 3);
final int paramNumber = defaultParam("number", ec, 3);
// validate
if (number < 0 || number > names.size()) {
if (paramNumber < 0 || paramNumber > names.size()) {
throw new IllegalArgumentException(String.format("number must be in range [0,%d)",
names.size()));
}
@ -82,7 +82,7 @@ public class RecreateSimpleObjects extends FixtureScript {
//
ec.executeChild(this, new SimpleObjectsTearDown());
for (int i = 0; i < number; i++) {
for (int i = 0; i < paramNumber; i++) {
final SimpleObjectCreate fs = new SimpleObjectCreate().setName(names.get(i));
ec.executeChild(this, fs.getName(), fs);
simpleObjects.add(fs.getSimpleObject());