diff --git a/value-object/src/main/java/com/iluwatar/value/object/App.java b/value-object/src/main/java/com/iluwatar/value/object/App.java index 012f93b74..85779fcb7 100644 --- a/value-object/src/main/java/com/iluwatar/value/object/App.java +++ b/value-object/src/main/java/com/iluwatar/value/object/App.java @@ -14,11 +14,9 @@ package com.iluwatar.value.object; * * For more specific and strict rules to implement value objects check the rules from Stephen * Colebourne's term VALJO : http://blog.joda.org/2014/03/valjos-value-java-objects.html - * */ public class App { /** - * * This practice creates three HeroStats(Value object) and checks equality between those. */ public static void main(String[] args) { diff --git a/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java b/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java index 9a3e2e4bf..101837db0 100644 --- a/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java +++ b/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java @@ -7,14 +7,12 @@ package com.iluwatar.value.object; */ public class HeroStat { - // Stats for a hero private final int strength; private final int intelligence; private final int luck; - // All constructors must be private. private HeroStat(int strength, int intelligence, int luck) { super(); @@ -87,7 +85,6 @@ public class HeroStat { return true; } - // The clone() method should not be public. Just don't override it. } diff --git a/value-object/src/test/java/com/iluwatar/value/object/HeroStatTest.java b/value-object/src/test/java/com/iluwatar/value/object/HeroStatTest.java index 162d9e736..785a4d8fe 100644 --- a/value-object/src/test/java/com/iluwatar/value/object/HeroStatTest.java +++ b/value-object/src/test/java/com/iluwatar/value/object/HeroStatTest.java @@ -15,7 +15,7 @@ import org.junit.Test; public class HeroStatTest { /** - * Tester for equals() and hashCode() methods of a class. Using guava's EqualsTester + * Tester for equals() and hashCode() methods of a class. Using guava's EqualsTester. * * @see http://static.javadoc.io/com.google.guava/guava-testlib/19.0/com/google/common/testing/ * EqualsTester.html @@ -33,15 +33,12 @@ public class HeroStatTest { */ @Test public void testToString() { - HeroStat heroStatA = HeroStat.valueOf(3, 9, 2); HeroStat heroStatB = HeroStat.valueOf(3, 9, 2); HeroStat heroStatC = HeroStat.valueOf(3, 9, 8); assertThat(heroStatA.toString(), is(heroStatB.toString())); assertThat(heroStatA.toString(), is(not(heroStatC.toString()))); - - } }