gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replase system.println with logger

Browse Source
This commit is contained in:
SrdjanPaunovic 2017-06-04 20:49:15 +02:00
parent 09fb79099f
commit 85acb1cf6c
5 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
extension-objects/etc/extension_obj1.png
View File

Binary file not shown.
Side by Side

Before

Width:  |  Height:  |  Size: 14 KiB

23
extension-objects/src/main/java/App.java
View File

@ -5,6 +5,8 @@ import units.CommanderUnit;
import units.SergeantUnit; import units.SergeantUnit;
import units.SoldierUnit; import units.SoldierUnit;
import units.Unit; import units.Unit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/** /**
* Created by Srdjan on 26-Apr-17. * Created by Srdjan on 26-Apr-17.
@ -19,20 +21,19 @@ public class App {
public static void main(String[] args) { public static void main(String[] args) {
//Create 3 different units //Create 3 different units
Unit unit = new SoldierUnit("SoldierUnit1"); Unit soldierUnit = new SoldierUnit("SoldierUnit1");
Unit unit1 = new SergeantUnit("SergeantUnit1"); Unit sergeantUnit = new SergeantUnit("SergeantUnit1");
Unit unit2 = new CommanderUnit("CommanderUnit1"); Unit commanderUnit = new CommanderUnit("CommanderUnit1");
//check for each unit to have an extension //check for each unit to have an extension
checkExtensionsForUnit(unit); checkExtensionsForUnit(soldierUnit);
checkExtensionsForUnit(unit1); checkExtensionsForUnit(sergeantUnit);
checkExtensionsForUnit(unit2); checkExtensionsForUnit(commanderUnit);
} }
private static void checkExtensionsForUnit(Unit unit) { private static void checkExtensionsForUnit(Unit unit) {
//separate for better view final Logger logger = LoggerFactory.getLogger(App.class);
System.out.println();
SoldierExtension soldierExtension = (SoldierExtension) unit.getUnitExtension("SoldierExtension"); SoldierExtension soldierExtension = (SoldierExtension) unit.getUnitExtension("SoldierExtension");
SergeantExtension sergeantExtension = (SergeantExtension) unit.getUnitExtension("SergeantExtension"); SergeantExtension sergeantExtension = (SergeantExtension) unit.getUnitExtension("SergeantExtension");
@ -42,19 +43,19 @@ public class App {
if (soldierExtension != null) { if (soldierExtension != null) {
soldierExtension.soldierReady(); soldierExtension.soldierReady();
} else { } else {
System.out.println(unit.getName() + " without SoldierExtension"); logger.info(unit.getName() + " without SoldierExtension");
} }
if (sergeantExtension != null) { if (sergeantExtension != null) {
sergeantExtension.sergeantReady(); sergeantExtension.sergeantReady();
} else { } else {
System.out.println(unit.getName() + " without SergeantExtension"); logger.info(unit.getName() + " without SergeantExtension");
} }
if (commanderExtension != null) { if (commanderExtension != null) {
commanderExtension.commanderReady(); commanderExtension.commanderReady();
} else { } else {
System.out.println(unit.getName() + " without CommanderExtension"); logger.info(unit.getName() + " without CommanderExtension");
} }
} }
} }

6
extension-objects/src/main/java/concreteextensions/Commander.java
View File

@ -1,6 +1,8 @@
package concreteextensions; package concreteextensions;
import abstractextensions.CommanderExtension; import abstractextensions.CommanderExtension;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import units.CommanderUnit; import units.CommanderUnit;
/** /**
@ -14,8 +16,10 @@ public class Commander implements CommanderExtension {
this.unit = commanderUnit; this.unit = commanderUnit;
} }
final Logger logger = LoggerFactory.getLogger(Commander.class);
@Override @Override
public void commanderReady() { public void commanderReady() {
System.out.println("[Commander] " + unit.getName() + " is ready!"); logger.info("[Commander] " + unit.getName() + " is ready!");
} }
} }

6
extension-objects/src/main/java/concreteextensions/Sergeant.java
View File

@ -1,6 +1,8 @@
package concreteextensions; package concreteextensions;
import abstractextensions.SergeantExtension; import abstractextensions.SergeantExtension;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import units.SergeantUnit; import units.SergeantUnit;
/** /**
@ -14,8 +16,10 @@ public class Sergeant implements SergeantExtension {
this.unit = sergeantUnit; this.unit = sergeantUnit;
} }
final Logger logger = LoggerFactory.getLogger(Sergeant.class);
@Override @Override
public void sergeantReady() { public void sergeantReady() {
System.out.println("[Sergeant] " + unit.getName() + " is ready! "); logger.info("[Sergeant] " + unit.getName() + " is ready! ");
} }
} }

6
extension-objects/src/main/java/concreteextensions/Soldier.java
View File

@ -1,6 +1,8 @@
package concreteextensions; package concreteextensions;
import abstractextensions.SoldierExtension; import abstractextensions.SoldierExtension;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import units.SoldierUnit; import units.SoldierUnit;
/** /**
@ -14,8 +16,10 @@ public class Soldier implements SoldierExtension {
this.unit = soldierUnit; this.unit = soldierUnit;
} }
final Logger logger = LoggerFactory.getLogger(Soldier.class);
@Override @Override
public void soldierReady() { public void soldierReady() {
System.out.println("[Solider] " + unit.getName() + " is ready!"); logger.info("[Solider] " + unit.getName() + " is ready!");
} }
} }