From 8cc843465bf892fe1a61c814bb21dcee02842f49 Mon Sep 17 00:00:00 2001 From: Ilkka Seppala Date: Sun, 17 May 2015 21:46:51 +0300 Subject: [PATCH] Code improvements. --- .../src/main/java/com/iluwatar/CoffeeMakingTask.java | 2 +- .../src/main/java/com/iluwatar/PotatoPeelingTask.java | 2 +- thread-pool/src/main/java/com/iluwatar/Task.java | 6 +++--- thread-pool/src/main/java/com/iluwatar/Worker.java | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java b/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java index 9117b4691..f299b28a3 100644 --- a/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java +++ b/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java @@ -7,7 +7,7 @@ package com.iluwatar; */ public class CoffeeMakingTask extends Task { - private static int TIME_PER_CUP = 300; + private static final int TIME_PER_CUP = 300; public CoffeeMakingTask(int numCups) { super(numCups * TIME_PER_CUP); diff --git a/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java b/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java index 51b77444f..7195aed37 100644 --- a/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java +++ b/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java @@ -7,7 +7,7 @@ package com.iluwatar; */ public class PotatoPeelingTask extends Task { - private static int TIME_PER_POTATO = 500; + private static final int TIME_PER_POTATO = 500; public PotatoPeelingTask(int numPotatoes) { super(numPotatoes * TIME_PER_POTATO); diff --git a/thread-pool/src/main/java/com/iluwatar/Task.java b/thread-pool/src/main/java/com/iluwatar/Task.java index 378bb432d..ad75fde3b 100644 --- a/thread-pool/src/main/java/com/iluwatar/Task.java +++ b/thread-pool/src/main/java/com/iluwatar/Task.java @@ -9,10 +9,10 @@ public abstract class Task { private static int nextId = 1; - private int id; - private int timeMs; + private final int id; + private final int timeMs; - public Task(int timeMs) { + public Task(final int timeMs) { this.id = nextId++; this.timeMs = timeMs; } diff --git a/thread-pool/src/main/java/com/iluwatar/Worker.java b/thread-pool/src/main/java/com/iluwatar/Worker.java index 8dab04063..8694043e8 100644 --- a/thread-pool/src/main/java/com/iluwatar/Worker.java +++ b/thread-pool/src/main/java/com/iluwatar/Worker.java @@ -7,9 +7,9 @@ package com.iluwatar; */ public class Worker implements Runnable { - private Task task; + private final Task task; - public Worker(Task task) { + public Worker(final Task task) { this.task = task; }