gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#354 Fixed CheckStyle Issues

Browse Source
This commit is contained in:
Joseph McCarthy
2016-01-26 19:20:28 +00:00
parent 32f9cf3ab1
commit 91b2379fd0
7 changed files with 100 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
feature-toggle/pom.xml
View File

@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent> <parent>
<artifactId>java-design-patterns</artifactId> <artifactId>java-design-patterns</artifactId>
@ -20,5 +20,5 @@
<scope>test</scope> <scope>test</scope>
</dependency> </dependency>
</dependencies> </dependencies>
</project> </project>

2
feature-toggle/src/main/java/com/iluwatar/featuretoggle/pattern/tieredversion/TieredFeatureToggleVersion.java
View File

@ -8,7 +8,7 @@ public class TieredFeatureToggleVersion implements Service {
@Override @Override
public String getWelcomeMessage(User user) { public String getWelcomeMessage(User user) {
if(UserGroup.isPaid(user)){ if (UserGroup.isPaid(user)) {
return "You're amazing " + user.getName() + ". Thanks for paying for this awesome software."; return "You're amazing " + user.getName() + ". Thanks for paying for this awesome software.";
} }

27
feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java
View File

@ -3,26 +3,37 @@ package com.iluwatar.featuretoggle.user;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
/**
* Contains the lists of users of different groups paid and free
*/
public class UserGroup { public class UserGroup {
private static List<User> freeGroup = new ArrayList<>(); private static List<User> freeGroup = new ArrayList<>();
private static List<User> paidGroup = new ArrayList<>(); private static List<User> paidGroup = new ArrayList<>();
public static void addUserToFreeGroup(final User user){ /**
if(paidGroup.contains(user)){ *
* @param user {@link User} to be added to the free group
*/
public static void addUserToFreeGroup(final User user) {
if (paidGroup.contains(user)) {
throw new IllegalArgumentException("User all ready member of paid group."); throw new IllegalArgumentException("User all ready member of paid group.");
}else{ } else {
if(!freeGroup.contains(user)){ if (!freeGroup.contains(user)) {
freeGroup.add(user); freeGroup.add(user);
} }
} }
} }
public static void addUserToPaidGroup(final User user){ /**
if(freeGroup.contains(user)){ *
* @param user {@link User} to be added to the paid group
*/
public static void addUserToPaidGroup(final User user) {
if (freeGroup.contains(user)) {
throw new IllegalArgumentException("User all ready member of free group."); throw new IllegalArgumentException("User all ready member of free group.");
}else{ } else {
if(!paidGroup.contains(user)){ if (!paidGroup.contains(user)) {
paidGroup.add(user); paidGroup.add(user);
} }
} }

6
feature-toggle/src/main/test/com/iluwatar/featuretoggle/pattern/tieredversion/TieredFeatureToggleVersionTest.java
View File

@ -6,7 +6,7 @@ import com.iluwatar.featuretoggle.user.UserGroup;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.*; import static org.junit.Assert.assertEquals;
public class TieredFeatureToggleVersionTest { public class TieredFeatureToggleVersionTest {
@ -24,13 +24,13 @@ public class TieredFeatureToggleVersionTest {
public void testGetWelcomeMessageForPaidUser() throws Exception { public void testGetWelcomeMessageForPaidUser() throws Exception {
final String welcomeMessage = service.getWelcomeMessage(paidUser); final String welcomeMessage = service.getWelcomeMessage(paidUser);
final String expected = "You're amazing Jamie Coder. Thanks for paying for this awesome software."; final String expected = "You're amazing Jamie Coder. Thanks for paying for this awesome software.";
assertEquals(expected,welcomeMessage); assertEquals(expected, welcomeMessage);
} }
@Test @Test
public void testGetWelcomeMessageForFreeUser() throws Exception { public void testGetWelcomeMessageForFreeUser() throws Exception {
final String welcomeMessage = service.getWelcomeMessage(freeUser); final String welcomeMessage = service.getWelcomeMessage(freeUser);
final String expected = "I suppose you can use this software."; final String expected = "I suppose you can use this software.";
assertEquals(expected,welcomeMessage); assertEquals(expected, welcomeMessage);
} }
} }