From 95f2c19780de4d065eef45bdaf4bd95fd0874f60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kriszti=C3=A1n=20Nagy?= Date: Sun, 18 Dec 2016 16:08:59 +0100 Subject: [PATCH] Sonar bug fixes using Yoda condition in equals expression when comparing String literal with String object. Using try-with-resources if we use Scanner to close the underlying stream is a good practice to handle resources. Minimal refactor. --- .../java/com/iluwatar/hexagonal/service/ConsoleLottery.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java index e8ff6c949..f7f7b274d 100644 --- a/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java +++ b/hexagonal/src/main/java/com/iluwatar/hexagonal/service/ConsoleLottery.java @@ -67,7 +67,7 @@ public class ConsoleLottery { addFundsToLotteryAccount(bank, scanner); } else if ("3".equals(cmd)) { submitTicket(service, scanner); - } else if (cmd.equals("4")) { + } else if ("4".equals(cmd)) { checkTicket(service, scanner); } else if ("5".equals(cmd)) { exit = true;