gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #532 from leogtzr/master

Browse Source 
Adding initialization-on-demand idiom and noninstantiable class instead of interface constant idiom
This commit is contained in:
Ilkka Seppälä
2017-01-23 08:21:07 +02:00
committed by GitHub
parent 115a85301c c6d0d28557
commit 9ec0935a1c
13 changed files with 32 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hexagonal/src/main/java/com/iluwatar/hexagonal/banking/MongoBank.java
View File

@ -29,6 +29,7 @@ import com.mongodb.client.model.UpdateOptions;
import org.bson.Document;
import java.util.ArrayList;
import java.util.List;
/**
* Mongo based banking adapter
@ -110,7 +111,7 @@ public class MongoBank implements WireTransfers {
@Override
public int getFunds(String bankAccount) {
Document search = new Document("_id", bankAccount);
ArrayList<Document> results = accountsCollection.find(search).limit(1).into(new ArrayList<Document>());
List<Document> results = accountsCollection.find(search).limit(1).into(new ArrayList<Document>());
if (results.size() > 0) {
return results.get(0).getInteger("funds");
} else {

8
hexagonal/src/main/java/com/iluwatar/hexagonal/database/MongoTicketRepository.java
View File

@ -35,8 +35,10 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import java.util.Set;
/**
* Mongo lottery ticket database
@ -142,7 +144,7 @@ public class MongoTicketRepository implements LotteryTicketRepository {
@Override
public Optional<LotteryTicket> findById(LotteryTicketId id) {
Document find = new Document("ticketId", id.getId());
ArrayList<Document> results = ticketsCollection.find(find).limit(1).into(new ArrayList<Document>());
List<Document> results = ticketsCollection.find(find).limit(1).into(new ArrayList<Document>());
if (results.size() > 0) {
LotteryTicket lotteryTicket = docToTicket(results.get(0));
return Optional.of(lotteryTicket);
@ -166,7 +168,7 @@ public class MongoTicketRepository implements LotteryTicketRepository {
@Override
public Map<LotteryTicketId, LotteryTicket> findAll() {
Map<LotteryTicketId, LotteryTicket> map = new HashMap<>();
ArrayList<Document> docs = ticketsCollection.find(new Document()).into(new ArrayList<Document>());
List<Document> docs = ticketsCollection.find(new Document()).into(new ArrayList<Document>());
for (Document doc: docs) {
LotteryTicket lotteryTicket = docToTicket(doc);
map.put(lotteryTicket.getId(), lotteryTicket);
@ -183,7 +185,7 @@ public class MongoTicketRepository implements LotteryTicketRepository {
PlayerDetails playerDetails = new PlayerDetails(doc.getString("email"), doc.getString("bank"),
doc.getString("phone"));
int[] numArray = Arrays.asList(doc.getString("numbers").split(",")).stream().mapToInt(Integer::parseInt).toArray();
HashSet<Integer> numbers = new HashSet<>();
Set<Integer> numbers = new HashSet<>();
for (int num: numArray) {
numbers.add(num);
}