gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added tests for service-locator pattern

Browse Source 
Fix NPE when requested service is unknown
This commit is contained in:
Jeroen Meulemeester
2015-12-29 19:25:29 +01:00
parent fcfdbe71f5
commit a375b2d28b
2 changed files with 45 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
service-locator/src/main/java/com/iluwatar/servicelocator/ServiceLocator.java
View File

@ -32,7 +32,9 @@ public class ServiceLocator {
*/
InitContext ctx = new InitContext();
serviceObj = (Service) ctx.lookup(serviceJndiName);
serviceCache.addService(serviceObj);
if (serviceObj != null) { // Only cache a service if it actually exists
serviceCache.addService(serviceObj);
}
return serviceObj;
}
}