From a3c4d36c3dae6f7ca8286ebcd60ea3d2f336747f Mon Sep 17 00:00:00 2001
From: venkatrs-ch197 <65022470+venkatrs-ch197@users.noreply.github.com>
Date: Sun, 31 May 2020 13:15:28 +0530
Subject: [PATCH] Added Java 11 support and created constants in App.java
 (#1238)

Co-authored-by: cherukumilliv <VenkatRamaSubbarago.Cherukumilli@Cevalogistics.com>
---
 module/src/main/java/com/iluwatar/module/App.java      | 10 ++++++----
 .../java/com/iluwatar/module/FileLoggerModuleTest.java | 10 +++++-----
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/module/src/main/java/com/iluwatar/module/App.java b/module/src/main/java/com/iluwatar/module/App.java
index 1b6cbbd23..d50693440 100644
--- a/module/src/main/java/com/iluwatar/module/App.java
+++ b/module/src/main/java/com/iluwatar/module/App.java
@@ -37,6 +37,8 @@ import java.io.FileNotFoundException;
  */
 public class App {
 
+  private static final String ERROR = "Error";
+  private static final String MESSAGE = "Message";
   public static FileLoggerModule fileLoggerModule;
   public static ConsoleLoggerModule consoleLoggerModule;
 
@@ -71,12 +73,12 @@ public class App {
   public static void execute(final String... args) {
 
     /* Send logs on file system */
-    fileLoggerModule.printString("Message");
-    fileLoggerModule.printErrorString("Error");
+    fileLoggerModule.printString(MESSAGE);
+    fileLoggerModule.printErrorString(ERROR);
 
     /* Send logs on console */
-    consoleLoggerModule.printString("Message");
-    consoleLoggerModule.printErrorString("Error");
+    consoleLoggerModule.printString(MESSAGE);
+    consoleLoggerModule.printErrorString(ERROR);
   }
 
   /**
diff --git a/module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java b/module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java
index e88b466f2..646bba642 100644
--- a/module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java
+++ b/module/src/test/java/com/iluwatar/module/FileLoggerModuleTest.java
@@ -65,7 +65,7 @@ public final class FileLoggerModuleTest {
   public void testFileMessage() throws IOException {
 
     /* Get singletong instance of File Logger Module */
-    final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
+    final var fileLoggerModule = FileLoggerModule.getSingleton();
 
     /* Prepare the essential sub modules, to perform the sequence of jobs */
     fileLoggerModule.prepare();
@@ -89,7 +89,7 @@ public final class FileLoggerModuleTest {
   public void testNoFileMessage() throws IOException {
 
     /* Get singletong instance of File Logger Module */
-    final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
+    final var fileLoggerModule = FileLoggerModule.getSingleton();
 
     /* Prepare the essential sub modules, to perform the sequence of jobs */
     fileLoggerModule.prepare();
@@ -111,7 +111,7 @@ public final class FileLoggerModuleTest {
   public void testFileErrorMessage() throws FileNotFoundException {
 
     /* Get singletong instance of File Logger Module */
-    final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
+    final var fileLoggerModule = FileLoggerModule.getSingleton();
 
     /* Prepare the essential sub modules, to perform the sequence of jobs */
     fileLoggerModule.prepare();
@@ -136,7 +136,7 @@ public final class FileLoggerModuleTest {
   public void testNoFileErrorMessage() throws FileNotFoundException {
 
     /* Get singletong instance of File Logger Module */
-    final FileLoggerModule fileLoggerModule = FileLoggerModule.getSingleton();
+    final var fileLoggerModule = FileLoggerModule.getSingleton();
 
     /* Prepare the essential sub modules, to perform the sequence of jobs */
     fileLoggerModule.prepare();
@@ -157,7 +157,7 @@ public final class FileLoggerModuleTest {
   private static final String readFirstLine(final String file) {
 
     String firstLine = null;
-    try (BufferedReader bufferedReader = new BufferedReader(new FileReader(file))) {
+    try (var bufferedReader = new BufferedReader(new FileReader(file))) {
 
       while (bufferedReader.ready()) {