diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java index be57406dd..97fdddf14 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java @@ -23,28 +23,17 @@ package com.iluwatar.acyclicvisitor; /** - * The Acyclic Visitor pattern allows new - * functions to be added to existing class - * hierarchies without affecting those - * hierarchies, and without creating the - * dependency cycles that are inherent to - * the GoF Visitor pattern, by making the - * Visitor base class degenerate + * The Acyclic Visitor pattern allows new functions to be added to existing class + * hierarchies without affecting those hierarchies, and without creating the dependency + * cycles that are inherent to the GoF Visitor pattern, by making the Visitor base class + * degenerate *
- * In this example the visitor base - * class is {@link ModemVisitor}. - * The base class of the visited - * hierarchy is {@link Modem} and - * has two children {@link Hayes} - * and {@link Zoom} each one having - * its own visitor interface {@link Hayes} - * and {@link ZoomVisitor} respectively. - * {@link ConfigureForUnixVisitor} and - * {@link ConfigureForDosVisitor} implement - * each derivative's visit method - * only if it is required + * In this example the visitor base class is {@link ModemVisitor}. The base class of the + * visited hierarchy is {@link Modem} and has two children {@link Hayes} and {@link Zoom} + * each one having its own visitor interface {@link Hayes} and {@link ZoomVisitor} + * respectively. {@link ConfigureForUnixVisitor} and {@link ConfigureForDosVisitor} + * implement each derivative's visit method only if it is required */ - public class App { /** diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitor.java index aee1dfa38..b71893474 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitor.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitor.java @@ -26,12 +26,9 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * CongigureForDosVisitor class - * implements both zoom's and - * hayes' visit method for Dos - * manufacturer + * CongigureForDosVisitor class implements both zoom's and hayes' visit method + * for Dos manufacturer */ - public class ConfigureForDosVisitor implements ModemVisitor, HayesVisitor, ZoomVisitor { private static final Logger LOGGER = LoggerFactory.getLogger(ConfigureForDosVisitor.class); diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java index c2402d2bc..9e35ea0a6 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java @@ -26,9 +26,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * CongigureForDosVisitor class - * implements both zoom's visit - * method for Unix manufacturer + * CongigureForDosVisitor class implements both zoom's visit method for Unix + * manufacturer */ public class ConfigureForUnixVisitor implements ModemVisitor, ZoomVisitor { diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java index d829e7f02..30408a758 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java @@ -26,10 +26,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * Hayes class implements its - * accept method + * Hayes class implements its accept method */ - public class Hayes extends Modem { private static final Logger LOGGER = LoggerFactory.getLogger(ConfigureForDosVisitor.class); diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Modem.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Modem.java index b7e4d3f6b..57207a466 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Modem.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Modem.java @@ -25,7 +25,6 @@ package com.iluwatar.acyclicvisitor; /** * Modem abstract class */ - public abstract class Modem { public abstract void accept(ModemVisitor modemVisitor); } diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ModemVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ModemVisitor.java index eac2bd4a8..f5668756c 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ModemVisitor.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ModemVisitor.java @@ -25,7 +25,6 @@ package com.iluwatar.acyclicvisitor; /** * ZoomVisitor interface */ - public interface ModemVisitor { // Visitor is a degenerate base class for all visitors. } diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.java index 099bdc63d..176a22ea4 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.java @@ -26,10 +26,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * Zoom class implements its - * accept method + * Zoom class implements its accept method */ - public class Zoom extends Modem { private static final Logger LOGGER = LoggerFactory.getLogger(ConfigureForDosVisitor.class); diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java index 5f6fa0cd3..85646921c 100644 --- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java +++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java @@ -25,7 +25,6 @@ package com.iluwatar.acyclicvisitor; /** * ZoomVisitor interface */ - public interface ZoomVisitor { void visit(Zoom zoom); }