diff --git a/aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java b/aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java index 2ffa9cd42..fa229832b 100644 --- a/aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java +++ b/aggregator-microservices/aggregator-service/src/test/java/com/iluwatar/aggregator/microservices/AggregatorTest.java @@ -48,7 +48,7 @@ class AggregatorTest { @BeforeEach public void setup() { - MockitoAnnotations.initMocks(this); + MockitoAnnotations.openMocks(this); } /** diff --git a/api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java b/api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java index 94e76583e..2f71ee4f4 100644 --- a/api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java +++ b/api-gateway/api-gateway-service/src/test/java/com/iluwatar/api/gateway/ApiGatewayTest.java @@ -48,7 +48,7 @@ class ApiGatewayTest { @BeforeEach public void setup() { - MockitoAnnotations.initMocks(this); + MockitoAnnotations.openMocks(this); } /** diff --git a/async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java b/async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java index b644e0e23..495cb6b6e 100644 --- a/async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java +++ b/async-method-invocation/src/test/java/com/iluwatar/async/method/invocation/ThreadAsyncExecutorTest.java @@ -68,7 +68,7 @@ class ThreadAsyncExecutorTest { @BeforeEach void setUp() { - MockitoAnnotations.initMocks(this); + MockitoAnnotations.openMocks(this); } /** diff --git a/data-bus/src/test/java/com/iluwatar/databus/DataBusTest.java b/data-bus/src/test/java/com/iluwatar/databus/DataBusTest.java index 9278c965b..ca1c936d0 100644 --- a/data-bus/src/test/java/com/iluwatar/databus/DataBusTest.java +++ b/data-bus/src/test/java/com/iluwatar/databus/DataBusTest.java @@ -46,7 +46,7 @@ class DataBusTest { @BeforeEach void setUp() { - MockitoAnnotations.initMocks(this); + MockitoAnnotations.openMocks(this); } @Test diff --git a/pom.xml b/pom.xml index cfd0de127..cb726a43e 100644 --- a/pom.xml +++ b/pom.xml @@ -62,7 +62,7 @@ 1.7.30 1.2.3 1.1.0 - 1.11.289 + 1.12.13 2.0.1 2.12.3 2.3.1 @@ -72,7 +72,7 @@ 2.0.0 3.5.0 1.18.14 - 1.10.21 + 1.11.5 3.27.0-GA 3.0.0-M5 3.1.0 diff --git a/serverless/pom.xml b/serverless/pom.xml index 1cf2cb8a5..8ee367fa3 100644 --- a/serverless/pom.xml +++ b/serverless/pom.xml @@ -44,16 +44,6 @@ com.amazonaws aws-java-sdk-dynamodb ${aws-java-sdk-dynamodb.version} - - - com.amazonaws - aws-java-sdk-s3 - - - com.amazonaws - aws-java-sdk-kms - - com.amazonaws @@ -80,15 +70,15 @@ junit-jupiter-engine test + + org.mockito + mockito-core + test + - org.mockito - mockito-core - test - - - junit - junit - test + org.hamcrest + hamcrest-core + test diff --git a/serverless/src/test/java/com/iluwatar/serverless/baas/api/FindPersonApiHandlerTest.java b/serverless/src/test/java/com/iluwatar/serverless/baas/api/FindPersonApiHandlerTest.java index 8eb209e06..003fdf0df 100644 --- a/serverless/src/test/java/com/iluwatar/serverless/baas/api/FindPersonApiHandlerTest.java +++ b/serverless/src/test/java/com/iluwatar/serverless/baas/api/FindPersonApiHandlerTest.java @@ -23,6 +23,9 @@ package com.iluwatar.serverless.baas.api; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; + import static org.mockito.Mockito.mock; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; @@ -32,31 +35,29 @@ import com.amazonaws.services.lambda.runtime.Context; import com.amazonaws.services.lambda.runtime.events.APIGatewayProxyRequestEvent; import com.iluwatar.serverless.baas.model.Person; import java.util.Map; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Mock; -import org.mockito.runners.MockitoJUnitRunner; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; /** * Unit tests for FindPersonApiHandler Created by dheeraj.mummar on 3/5/18. */ -@RunWith(MockitoJUnitRunner.class) -public class FindPersonApiHandlerTest { +class FindPersonApiHandlerTest { private FindPersonApiHandler findPersonApiHandler; @Mock private DynamoDBMapper dynamoDbMapper; - @Before + @BeforeEach public void setUp() { + MockitoAnnotations.openMocks(this); this.findPersonApiHandler = new FindPersonApiHandler(); this.findPersonApiHandler.setDynamoDbMapper(dynamoDbMapper); } @Test - public void handleRequest() { + void handleRequest() { findPersonApiHandler.handleRequest(apiGatewayProxyRequestEvent(), mock(Context.class)); verify(dynamoDbMapper, times(1)).load(Person.class, "37e7a1fe-3544-473d-b764-18128f02d72d"); } diff --git a/serverless/src/test/java/com/iluwatar/serverless/baas/api/SavePersonApiHandlerTest.java b/serverless/src/test/java/com/iluwatar/serverless/baas/api/SavePersonApiHandlerTest.java index bf4a59273..d9b12a71f 100644 --- a/serverless/src/test/java/com/iluwatar/serverless/baas/api/SavePersonApiHandlerTest.java +++ b/serverless/src/test/java/com/iluwatar/serverless/baas/api/SavePersonApiHandlerTest.java @@ -34,18 +34,18 @@ import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; import com.iluwatar.serverless.baas.model.Address; import com.iluwatar.serverless.baas.model.Person; -import org.junit.Assert; -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; import org.mockito.Mock; -import org.mockito.runners.MockitoJUnitRunner; +import org.mockito.MockitoAnnotations; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotNull; /** * Unit tests for SavePersonApiHandler Created by dheeraj.mummar on 3/4/18. */ -@RunWith(MockitoJUnitRunner.class) -public class SavePersonApiHandlerTest { +class SavePersonApiHandlerTest { private SavePersonApiHandler savePersonApiHandler; @@ -54,31 +54,32 @@ public class SavePersonApiHandlerTest { private final ObjectMapper objectMapper = new ObjectMapper(); - @Before + @BeforeEach public void setUp() { + MockitoAnnotations.openMocks(this); this.savePersonApiHandler = new SavePersonApiHandler(); this.savePersonApiHandler.setDynamoDbMapper(dynamoDbMapper); } @Test - public void handleRequestSavePersonSuccessful() throws JsonProcessingException { + void handleRequestSavePersonSuccessful() throws JsonProcessingException { var person = newPerson(); var body = objectMapper.writeValueAsString(person); var request = apiGatewayProxyRequestEvent(body); var ctx = mock(Context.class); var apiGatewayProxyResponseEvent = this.savePersonApiHandler.handleRequest(request, ctx); verify(dynamoDbMapper, times(1)).save(person); - Assert.assertNotNull(apiGatewayProxyResponseEvent); - Assert.assertEquals(Integer.valueOf(201), apiGatewayProxyResponseEvent.getStatusCode()); + assertNotNull(apiGatewayProxyResponseEvent); + assertEquals(Integer.valueOf(201), apiGatewayProxyResponseEvent.getStatusCode()); } @Test - public void handleRequestSavePersonException() { + void handleRequestSavePersonException() { var request = apiGatewayProxyRequestEvent("invalid sample request"); var ctx = mock(Context.class); var apiGatewayProxyResponseEvent = this.savePersonApiHandler.handleRequest(request, ctx); - Assert.assertNotNull(apiGatewayProxyResponseEvent); - Assert.assertEquals(Integer.valueOf(400), apiGatewayProxyResponseEvent.getStatusCode()); + assertNotNull(apiGatewayProxyResponseEvent); + assertEquals(Integer.valueOf(400), apiGatewayProxyResponseEvent.getStatusCode()); } private APIGatewayProxyRequestEvent apiGatewayProxyRequestEvent(String body) {