gaspersic/java-design-patterns
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sonar fix - add test cases for CommanderTest

Browse Source
This commit is contained in:
atayal
2021-11-05 19:06:03 +05:30
parent e68c9be3ef
commit bf95764075
1 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
commander/src/test/java/com/iluwatar/commander/CommanderTest.java
View File

@ -4,6 +4,7 @@ import com.iluwatar.commander.employeehandle.EmployeeDatabase;
import com.iluwatar.commander.employeehandle.EmployeeHandle; import com.iluwatar.commander.employeehandle.EmployeeHandle;
import com.iluwatar.commander.exceptions.DatabaseUnavailableException; import com.iluwatar.commander.exceptions.DatabaseUnavailableException;
import com.iluwatar.commander.exceptions.ItemUnavailableException; import com.iluwatar.commander.exceptions.ItemUnavailableException;
import com.iluwatar.commander.exceptions.PaymentDetailsErrorException;
import com.iluwatar.commander.exceptions.ShippingNotPossibleException; import com.iluwatar.commander.exceptions.ShippingNotPossibleException;
import com.iluwatar.commander.messagingservice.MessagingDatabase; import com.iluwatar.commander.messagingservice.MessagingDatabase;
import com.iluwatar.commander.messagingservice.MessagingService; import com.iluwatar.commander.messagingservice.MessagingService;
@ -20,6 +21,7 @@ import java.util.ArrayList;
import java.util.List; import java.util.List;
import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertTrue;
class CommanderTest { class CommanderTest {
@ -31,6 +33,16 @@ class CommanderTest {
private final long messageTime = 5_000; private final long messageTime = 5_000;
private final long employeeTime = 2_000; private final long employeeTime = 2_000;
private static List<Exception> exceptionList = new ArrayList<>();
static {
exceptionList.add(new DatabaseUnavailableException());
exceptionList.add(new ShippingNotPossibleException());
exceptionList.add(new ItemUnavailableException());
exceptionList.add(new PaymentDetailsErrorException());
exceptionList.add(new IllegalStateException());
}
private Commander buildCommanderObject() { private Commander buildCommanderObject() {
return buildCommanderObject(false); return buildCommanderObject(false);
} }
@ -301,13 +313,7 @@ class CommanderTest {
@Test @Test
void testPlaceOrderWithDatabaseAndExceptions() throws Exception { void testPlaceOrderWithDatabaseAndExceptions() throws Exception {
List<Exception> l = new ArrayList<Exception>(); for (Exception e : exceptionList) {
l.add(new DatabaseUnavailableException());
l.add(new ShippingNotPossibleException());
l.add(new ItemUnavailableException());
l.add(new IllegalStateException());
for (Exception e : l) {
Commander c = buildCommanderObjectWithDB(true, true, e); Commander c = buildCommanderObjectWithDB(true, true, e);
var order = new Order(new User("K", null), "pen", 1f); var order = new Order(new User("K", null), "pen", 1f);
@ -342,12 +348,7 @@ class CommanderTest {
@Test @Test
void testPlaceOrderWithoutDatabaseAndExceptions() throws Exception { void testPlaceOrderWithoutDatabaseAndExceptions() throws Exception {
List<Exception> l = new ArrayList<>(); for (Exception e : exceptionList) {
l.add(new ShippingNotPossibleException());
l.add(new ItemUnavailableException());
l.add(new IllegalStateException());
for (Exception e : l) {
Commander c = buildCommanderObjectWithoutDB(true, true, e); Commander c = buildCommanderObjectWithoutDB(true, true, e);
var order = new Order(new User("K", null), "pen", 1f); var order = new Order(new User("K", null), "pen", 1f);