Update to JUnit5 across all modules (#1668)

* Updated saga to JUnit 5

* Update fix for CI job in trampoline module

* Updated update-method module to JUnit 5

* Upgraded to latest JUnit Jupiter
JUnit 4 is not needed when using JUnit-Vintage

* Reverted change to access modifier on Trampoline

* Cleanup to resolve code smells

* Formatting

* Formatting

* Migrating to JUnit5 and updating some Mockito patterns

* Migrating to JUnit5

* Migrating to JUnit5

* Migrating to JUnit 5

* Formatting cleanup

* Added missing scope for junit

* Fixed tests that were not running previously.

Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>

leader-followers/src/test/java/com/AppTest.java

@@ -23,20 +23,20 @@
 
 package com;
 
-import com.iluwatar.leaderfollowers.App;
-import org.junit.Test;
-
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 
+import com.iluwatar.leaderfollowers.App;
+import org.junit.jupiter.api.Test;
+
 /**
  *
  * Application test
  *
  */
-public class AppTest {
+class AppTest {
 
     @Test
-    public void shouldExecuteApplicationWithoutException() {
+    void shouldExecuteApplicationWithoutException() {
         assertDoesNotThrow(() -> App.main(new String[]{}));
     }
 

leader-followers/src/test/java/com/TaskHandlerTest.java

@@ -23,22 +23,23 @@
 
 package com;
 
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
 import com.iluwatar.leaderfollowers.Task;
 import com.iluwatar.leaderfollowers.TaskHandler;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 /**
  * Tests for TaskHandler
  */
-public class TaskHandlerTest {
+class TaskHandlerTest {
 
     @Test
-    public void testHandleTask() throws InterruptedException {
+    void testHandleTask() throws InterruptedException {
         var taskHandler = new TaskHandler();
         var handle = new Task(100);
         taskHandler.handleTask(handle);
-        Assert.assertTrue(handle.isFinished());
+        assertTrue(handle.isFinished());
     }
 
 }

leader-followers/src/test/java/com/TaskSetTest.java

@@ -23,30 +23,31 @@
 
 package com;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
 import com.iluwatar.leaderfollowers.Task;
 import com.iluwatar.leaderfollowers.TaskSet;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 /**
  * Tests for TaskSet
  */
-public class TaskSetTest {
+class TaskSetTest {
 
     @Test
-    public void testAddTask() throws InterruptedException {
+    void testAddTask() throws InterruptedException {
         var taskSet = new TaskSet();
         taskSet.addTask(new Task(10));
-        Assert.assertTrue(taskSet.getSize() == 1);
+        assertEquals(1, taskSet.getSize());
     }
 
     @Test
-    public void testGetTask() throws InterruptedException {
+    void testGetTask() throws InterruptedException {
         var taskSet = new TaskSet();
         taskSet.addTask(new Task(100));
         Task task = taskSet.getTask();
-        Assert.assertTrue(task.getTime() == 100);
-        Assert.assertTrue(taskSet.getSize() == 0);
+        assertEquals(100, task.getTime());
+        assertEquals(0, taskSet.getSize());
     }
 
 }

leader-followers/src/test/java/com/WorkCenterTest.java

@@ -23,43 +23,45 @@
 
 package com;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
 import com.iluwatar.leaderfollowers.TaskHandler;
 import com.iluwatar.leaderfollowers.TaskSet;
 import com.iluwatar.leaderfollowers.WorkCenter;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 /**
  * Tests for WorkCenter
  */
-public class WorkCenterTest {
+class WorkCenterTest {
 
   @Test
-  public void testCreateWorkers() {
+  void testCreateWorkers() {
     var taskSet = new TaskSet();
     var taskHandler = new TaskHandler();
     var workCenter = new WorkCenter();
     workCenter.createWorkers(5, taskSet, taskHandler);
-    Assert.assertEquals(workCenter.getWorkers().size(), 5);
-    Assert.assertEquals(workCenter.getWorkers().get(0), workCenter.getLeader());
+    assertEquals(5, workCenter.getWorkers().size());
+    assertEquals(workCenter.getWorkers().get(0), workCenter.getLeader());
   }
 
   @Test
-  public void testNullLeader() {
+  void testNullLeader() {
     var workCenter = new WorkCenter();
     workCenter.promoteLeader();
-    Assert.assertNull(workCenter.getLeader());
+    assertNull(workCenter.getLeader());
   }
 
   @Test
-  public void testPromoteLeader() {
+  void testPromoteLeader() {
     var taskSet = new TaskSet();
     var taskHandler = new TaskHandler();
     var workCenter = new WorkCenter();
     workCenter.createWorkers(5, taskSet, taskHandler);
     workCenter.removeWorker(workCenter.getLeader());
     workCenter.promoteLeader();
-    Assert.assertEquals(workCenter.getWorkers().size(), 4);
-    Assert.assertEquals(workCenter.getWorkers().get(0), workCenter.getLeader());
+    assertEquals(4, workCenter.getWorkers().size());
+    assertEquals(workCenter.getWorkers().get(0), workCenter.getLeader());
   }
 }